You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/11 21:26:54 UTC
[GitHub] [calcite] julianhyde commented on a change in pull request #1070:
[CALCITE-2808]Add the JSON_LENGTH function
julianhyde commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r264437796
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5300,6 +5302,30 @@ SqlCall JsonDepthFunctionCall() :
}
}
+SqlCall JsonLengthFunctionCall() :
+{
+ final SqlNode[] args = new SqlNode[1];
+ SqlNode e;
+ final Span span;
+ List<SqlNode> behavior;
+}
+{
+ <JSON_LENGTH> { span = span(); }
+ <LPAREN> [
Review comment:
Sorry if i've missed a lot of context. But if JSON_LENGTH is syntactically just a regular function then I don't think we need to change Parser.jj.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services