You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/06/29 07:01:27 UTC

[GitHub] zeppelin pull request #1106: [ZEPPELIN-1082] Restore Interpreter page layout...

GitHub user minahlee opened a pull request:

    https://github.com/apache/zeppelin/pull/1106

    [ZEPPELIN-1082] Restore Interpreter page layout change

    ### What is this PR for?
    Apply margin-bottom: 20px on `box` class by removing `home` class
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1082](https://issues.apache.org/jira/browse/ZEPPELIN-1082)
    
    ### Screenshots (if appropriate)
    **Before**
    <img width="1280" alt="screen shot 2016-06-28 at 11 56 16 pm" src="https://cloud.githubusercontent.com/assets/8503346/16443219/554778b6-3d8c-11e6-884f-8a7024e5d3d1.png">
    
    
    **After**
    <img width="1280" alt="screen shot 2016-06-28 at 11 56 48 pm" src="https://cloud.githubusercontent.com/assets/8503346/16443239/6142ccc4-3d8c-11e6-914f-87f523bf8275.png">
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1082

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1106
    
----
commit fcace59a6a31da219af09d03607a30e7a97aa0f3
Author: Mina Lee <mi...@apache.org>
Date:   2016-06-29T06:49:46Z

    Remove home class to make space between boxes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1106: [ZEPPELIN-1082] Restore Interpreter page layout change

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1106
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1106: [ZEPPELIN-1082] Restore Interpreter page layout change

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1106
  
    Tested, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1106: [ZEPPELIN-1082] Restore Interpreter page layout change

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1106
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1106: [ZEPPELIN-1082] Restore Interpreter page layout...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1106: [ZEPPELIN-1082] Restore Interpreter page layout change

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1106
  
    LGTM \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1106: [ZEPPELIN-1082] Restore Interpreter page layout change

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1106
  
    Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---