You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Norbert Luksa (Jira)" <ji...@apache.org> on 2020/02/20 13:54:00 UTC

[jira] [Commented] (ORC-592) Add test coverage for corrupt protobuf objects

    [ https://issues.apache.org/jira/browse/ORC-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040991#comment-17040991 ] 

Norbert Luksa commented on ORC-592:
-----------------------------------

The PR for ORC-601 also fixes this.

> Add test coverage for corrupt protobuf objects
> ----------------------------------------------
>
>                 Key: ORC-592
>                 URL: https://issues.apache.org/jira/browse/ORC-592
>             Project: ORC
>          Issue Type: Test
>          Components: C++
>            Reporter: Quanlong Huang
>            Assignee: Norbert Luksa
>            Priority: Major
>
> Commit bf5b780 of ORC-469 unintentionally removes some safety checks in StringDictionaryColumnReader, which causes regression issues like ORC-590.
> We should add test coverage for checking corrupt protobuf objects to avoid regressions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)