[GitHub] [incubator-superset] willbarrett commented on pull request #10480: fix(#10479): dashboard slug is cleared on import

[GitBox <gi...@apache.org>]

willbarrett commented on pull request #10480:
URL: https://github.com/apache/incubator-superset/pull/10480#issuecomment-668211673


   In order to avoid introducing destructive changes, how about this as an alternative?
   
   1. Attempt to insert with the given slug
   2. If the slug exists (unique key error), add a random postfix to the slug and re-attempt the insert
   
   That would effectively attempt to retain the slug, but fall back to a behavior that preserves existing data.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org