You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/11 18:38:11 UTC
[jira] [Commented] (BEAM-394) AvroCoder is Serializable with
non-serializable fields
[ https://issues.apache.org/jira/browse/BEAM-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371377#comment-15371377 ]
ASF GitHub Bot commented on BEAM-394:
-------------------------------------
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-beam/pull/624
[BEAM-394] Updated the AvroCoder class to set unserializable fields as transient
* Updated AvroCoder to mark non-serializable fields as transient.
* Updated the findbugs_filter to remove ignored errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilganeli/incubator-beam BEAM-394
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #624
----
commit 131b425914a25b5b6a39e47b948f22571b11ac07
Author: Ilya Ganelin <il...@capitalone.com>
Date: 2016-07-11T18:36:45Z
Updated the AvroCoder class to set unserializable fields as transient. Updated the findbugs_filter to remove ignored errors.
----
> AvroCoder is Serializable with non-serializable fields
> ------------------------------------------------------
>
> Key: BEAM-394
> URL: https://issues.apache.org/jira/browse/BEAM-394
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L30]: Non-transient non-serializable instance field in serializable class.
> Applies to AvroCoder fields:
> * decoder
> * encoder
> * reader
> * writer
> * schema
> These should likely be marked transient and ensure they are properly initialized after deserialization.
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)