You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/06/28 14:31:49 UTC
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2786: Reduce merge overlap logging
EdColeman commented on code in PR #2786:
URL: https://github.com/apache/accumulo/pull/2786#discussion_r908558104
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/MergeInfo.java:
##########
@@ -93,10 +100,16 @@ public boolean needsToBeChopped(KeyExtent otherExtent) {
}
public boolean overlaps(KeyExtent otherExtent) {
- boolean result = this.extent.overlaps(otherExtent);
- if (!result && needsToBeChopped(otherExtent))
- return true;
- return result;
+ return previouslyEvaluatedOverlaps.computeIfAbsent(otherExtent, b -> {
+ boolean result = this.extent.overlaps(otherExtent);
+ if (!result && needsToBeChopped(otherExtent))
+ result = true;
+ if (result)
+ LOG.debug("mergeInfo overlaps: {} true", extent);
Review Comment:
```suggestion
LOG.debug("mergeInfo {} overlaps: {}", otherExtent, extent);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org