You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/12/08 18:03:53 UTC
Re: [PR] [SPARK-54596][CORE][K8S] Burst-aware Memory Allocation Algorithm for Spark@K8S [spark]
dongjoon-hyun commented on code in PR #53190:
URL: https://github.com/apache/spark/pull/53190#discussion_r2599599853
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala:
##########
@@ -528,6 +529,101 @@ class BasicExecutorFeatureStepSuite extends SparkFunSuite with BeforeAndAfter {
}
+ test("when turning on bursty memory overhead, configure request and limit correctly with" +
Review Comment:
nit. It would be great if you can add a test prefix like other test cases.
```scala
test("when turning on bursty memory overhead, ...
test("SPARK-54596: when turning on bursty memory overhead, ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org