You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Shanzita (via GitHub)" <gi...@apache.org> on 2026/10/06 19:45:20 UTC
Re: [PR] CASSJAVA-124: Add GRACEFUL_DISCONNECT support (CEP-59) [cassandra-java-driver]
Shanzita commented on PR #2091:
URL: https://github.com/apache/cassandra-java-driver/pull/2091#issuecomment-6024154804
Thanks both — implemented the agreed design in a023ccf6.
Graceful disconnect now stays local to the connection that receives it:
- Removed the internal node-scoped `GracefulDisconnectEvent` and the `EventBus` propagation. `ChannelPool` no longer registers a listener or closes the whole pool when the event arrives.
- Each connection that receives `GRACEFUL_DISCONNECT` drains itself in `InFlightHandler` (unchanged), and the node is marked DOWN through the existing infrastructure once it reaches zero connections — nothing marks it DOWN directly.
- Metrics are still incremented per received event: the pool's query-connection callback and the control connection each increment `session.graceful-disconnects` / `node.graceful-disconnects`.
Test updates: dropped the two propagation tests in `ChannelPoolGracefulDisconnectTest` (pool-wide close / other-node ignore) and kept a metrics-only assertion; the per-connection draining stays covered by `InFlightHandlerTest`. Removed the `eventBus.fire` assertion from `ControlConnectionEventsTest`. The graceful-disconnect unit tests all pass.
Still on my side: re-run the manual `nodetool drain` validation against a CEP-59 cluster (the IT is skipped in CI) and report back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org