[GitHub] [iceberg] rdblue commented on a change in pull request #4082: Core: Add reference structures to TableMetadata to unblock TableMetadata API changes

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4082:
URL: https://github.com/apache/iceberg/pull/4082#discussion_r803262740



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadataParser.java
##########
@@ -433,6 +434,7 @@ static TableMetadata fromJson(FileIO io, String metadataLocation, JsonNode node)
     return new TableMetadata(metadataLocation, formatVersion, uuid, location,
         lastSequenceNumber, lastUpdatedMillis, lastAssignedColumnId, currentSchemaId, schemas, defaultSpecId, specs,
         lastAssignedPartitionId, defaultSortOrderId, sortOrders, properties, currentVersionId,
-        snapshots, entries.build(), metadataEntries.build(), ImmutableList.of() /* no changes from the file */);
+        snapshots, entries.build(), metadataEntries.build(), ImmutableMap.of(), ImmutableList.of() /* no changes from
+         the file */);

Review comment:
       Can you wrap the line on the argument, rather than in the middle of a comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org