You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/24 03:46:45 UTC
[GitHub] [incubator-yunikorn-core] wilfred-s opened a new pull request #107:
[YUNIKORN-30] fix flaky unit test
wilfred-s opened a new pull request #107: [YUNIKORN-30] fix flaky unit test
URL: https://github.com/apache/incubator-yunikorn-core/pull/107
Production code fixes for incorrect logging only
Clean up of smoke test logic and unused code
Fix lint testing to use head ref from git
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #107:
[YUNIKORN-30] fix flaky unit test
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #107: [YUNIKORN-30] fix flaky unit test
URL: https://github.com/apache/incubator-yunikorn-core/pull/107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull
request #107: [YUNIKORN-30] fix flaky unit test
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #107: [YUNIKORN-30] fix flaky unit test
URL: https://github.com/apache/incubator-yunikorn-core/pull/107#discussion_r396921093
##########
File path: pkg/scheduler/scheduler.go
##########
@@ -548,6 +548,8 @@ func (s *Scheduler) GetClusterSchedulingContext() *ClusterSchedulingContext {
// Visible by tests
func (s *Scheduler) MultiStepSchedule(nAlloc int) {
for i := 0; i < nAlloc; i++ {
+ log.Logger().Debug("Scheduler manual stepping",
+ zap.Int("count", i))
Review comment:
Can we remove this?
Even this is DEBUG, it would print too many lines of logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org