[GitHub] [superset] kgabryje commented on pull request #23655: feat: add verbose map to get /dataset/ endpoint

["kgabryje (via GitHub)" <gi...@apache.org>]

kgabryje commented on PR #23655:
URL: https://github.com/apache/superset/pull/23655#issuecomment-1512722149

   
   > Btw, as the elements of both `columns` and `metrics` contain `verbose_name`, could it potentially be more simple to just create a `useVerboseName(dataset)` hook in the frontend that extracts the `verboseMap` from the requested `dataset`?
   
   +1 to that! I had no clue that each `column`/`metric` contains its `verbose_name`, I assumed we can only take them from `verbose_names` on top level of dataset endpoint response
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org