You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2020/01/15 22:13:52 UTC
[GitHub] [geode] jinmeiliao opened pull request #4596: GEODE-7699:
use ConfigurationInfo to wrap the get result
Co-authored-by: Dale Emery <de...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/4596 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #4596:
GEODE-7699: use ConfigurationInfo to wrap the get result
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
On the topic of naming: given how this class is currently used and the other classes names it seems like this class should include "Result" in it. It is only used as part of the result of a get. I think we should consider also using it in the result of list but in either case this class is a "result".
The primary thing this class has (compared to other results) is the identity of the thing it describes. So would a good name be "IdentifiableResult"?
[ Full content available at: https://github.com/apache/geode/pull/4596 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #4596: GEODE-7699: use
ConfigurationInfo to wrap the get result
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
@jmelchio
[ Full content available at: https://github.com/apache/geode/pull/4596 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #4596:
GEODE-7699: use ConfigurationInfo to wrap the get result
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
It seems like a better name for this class would be "GroupResult". I like that you updated the class comment to say it is per group. It seems like this class should include a group name so that it would be self describing.
[ Full content available at: https://github.com/apache/geode/pull/4596 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org