You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/11/16 21:24:35 UTC
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11946
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
IMPALA-7233: [DOCS] Support for IANA timezone database
- Updated the timezone section
- Added the sections on customizing timezone db and aliases
Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
---
M docs/topics/impala_timestamp.xml
1 file changed, 278 insertions(+), 281 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11946/1
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11946
to look at the new patch set (#2).
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
IMPALA-7233: [DOCS] Support for IANA timezone database
- Updated the timezone section
- Added the sections on customizing timezone db and aliases
Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
---
M docs/impala.ditamap
A docs/topics/impala_custom_timezones.xml
M docs/topics/impala_timestamp.xml
3 files changed, 337 insertions(+), 290 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11946/2
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
IMPALA-7233: [DOCS] Support for IANA timezone database
- Updated the timezone section
- Added the sections on customizing timezone db and aliases
Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Reviewed-on: http://gerrit.cloudera.org:8080/11946
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M docs/impala.ditamap
A docs/topics/impala_custom_timezones.xml
M docs/topics/impala_timestamp.xml
3 files changed, 347 insertions(+), 304 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Zoltan Ivanfi, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11946
to look at the new patch set (#4).
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
IMPALA-7233: [DOCS] Support for IANA timezone database
- Updated the timezone section
- Added the sections on customizing timezone db and aliases
Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
---
M docs/impala.ditamap
A docs/topics/impala_custom_timezones.xml
M docs/topics/impala_timestamp.xml
3 files changed, 347 insertions(+), 304 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11946/4
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Nov 2018 13:16:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193
PS1, Line 193: Configuring custom time zones:
> I think that it would be better to move custom timezone databases/aliases t
I agree.
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@272
PS1, Line 272: 2017c
Instead of '2017c' probably we should use a more generic directory name here and below, e.g. 'latest'.
('2017c' is the version of tzdb that I tested this script with, but the script should work with other tzdb versions as well).
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367
PS1, Line 367: turned off by
: default to avoid performance overhead
> I think that this was true before 3.1, but in 3.1 the conversion became muc
Turning on '-convert_legacy_hive_parquet_utc_timestamps' still has a cost, so I think we should keep this sentence.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 15:47:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Zoltan Ivanfi (Code Review)" <ge...@cloudera.org>.
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: values the same way it stores
: without any adjustment.
> This paragraph is about Text file, and the next paragraph is about Parquet
Sorry, my bad. I didn't notice the "in text tables" part. Should we make the table format references bold maybe or create separate subsections for textfile and Parquet to prevent confusion?
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 08:31:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@180
PS1, Line 180: + INTERVAL <varname>n-hours</varname></codeph> can be affected Daylight Saving Time, which
> nit: missing 'by'?
Done
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193
PS1, Line 193: Configuring custom time zones:
> I agree.
Done
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193
PS1, Line 193: Configuring custom time zones:
> I think that it would be better to move custom timezone databases/aliases t
Done
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@272
PS1, Line 272: 2017c
> Instead of '2017c' probably we should use a more generic directory name her
Done
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: values the same way it stores
: without any adjustment.
> This part of the sentence is not clear for me.
Hive reads and writes TIMESTAMP values without converting with respect to time zones. Better?
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367
PS1, Line 367: turned off by
: default to avoid performance overhead
> Turning on '-convert_legacy_hive_parquet_utc_timestamps' still has a cost,
Done
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 03:15:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/158/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 20:01:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Zoltan Ivanfi (Code Review)" <ge...@cloudera.org>.
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367
PS1, Line 367: turned off by
: default to avoid performance overhead
> I still think that the improvement should mentioned, e.g "Before 3.1, this
I would rephrase "eliminated most of the overhead" as "scales well to multiple threads" or similar. The overhead is still there, it just does not effectively make Impala run in a single thread when doing the adjustments.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 16:08:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/4/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/4/docs/topics/impala_timestamp.xml@228
PS4, Line 228: s
I think 's' is not needed here.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 10:48:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(1 comment)
> (1 comment)
Reworded
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: values the same way it stores
: without any adjustment.
> This sentence seems to contradict the description below. Hive 2.x _does_ ad
This paragraph is about Text file, and the next paragraph is about Parquet files. The incompatibility only exists in Parquet files, right?
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 19:24:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: values the same way it stores
: without any adjustment.
> I agree that difference between text and Parquet could be emphasized. For e
Done
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 20:02:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Zoltan Ivanfi, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11946
to look at the new patch set (#3).
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
IMPALA-7233: [DOCS] Support for IANA timezone database
- Updated the timezone section
- Added the sections on customizing timezone db and aliases
Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
---
M docs/impala.ditamap
A docs/topics/impala_custom_timezones.xml
M docs/topics/impala_timestamp.xml
3 files changed, 342 insertions(+), 296 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11946/3
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/4/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/4/docs/topics/impala_timestamp.xml@228
PS4, Line 228: s
> I think 's' is not needed here.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 19:01:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Zoltan Ivanfi (Code Review)" <ge...@cloudera.org>.
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: values the same way it stores
: without any adjustment.
> Hive reads and writes TIMESTAMP values without converting with respect to t
This sentence seems to contradict the description below. Hive 2.x _does_ adjust timestamps with respect to time zones. That is the cause of the incompatibility with Impala, which does not.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 15:45:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 5:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/159/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 19:01:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/155/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 03:15:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/152/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 21:24:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/158/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 20:18:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@180
PS1, Line 180: + INTERVAL <varname>n-hours</varname></codeph> can be affected Daylight Saving Time, which
nit: missing 'by'?
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193
PS1, Line 193: Configuring custom time zones:
I think that it would be better to move custom timezone databases/aliases to a separate topic/file if possible, as only probably only a small subset of users will be interested in these.
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: values the same way it stores
: without any adjustment.
This part of the sentence is not clear for me.
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367
PS1, Line 367: turned off by
: default to avoid performance overhead
I think that this was true before 3.1, but in 3.1 the conversion became much faster, so the main reason is compatibility: the result of an existing non-buggy query should not change in a minor version.
I think that IMPALA-3307 could be mentioned as the reason for speedup. convert_legacy_hive_parquet_utc_timestamps is known by users to be extremely slow, so the change could be highlighted to make it clear that this a much small issue now.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 14:36:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367
PS1, Line 367: turned off by
: default to avoid performance overhead
> Done
I still think that the improvement should mentioned, e.g "Before 3.1, this option had severe impact on multi-threaded performance. The new timezone implementation in 3.1 eliminated most of the overhead."
One reason why I would recommend switching this on is that 3.2 will include int64 encoded timestamps, where timezone handling is no longer influenced by this flag, but decided by metadate in the .parquet file. This means that if this flag is turned off, then int64 and int96 timestamps will behave differently.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 16:03:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/156/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 19:31:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Zoltan Ivanfi, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11946
to look at the new patch set (#5).
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
IMPALA-7233: [DOCS] Support for IANA timezone database
- Updated the timezone section
- Added the sections on customizing timezone db and aliases
Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
---
M docs/impala.ditamap
A docs/topics/impala_custom_timezones.xml
M docs/topics/impala_timestamp.xml
3 files changed, 347 insertions(+), 304 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11946/5
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/152/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Nov 2018 21:34:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/156/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 19:25:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 5: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/159/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 19:08:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:
http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333
PS1, Line 333: e hour value out of range.
: select dayofweek('2004-06-13'
> Sorry, my bad. I didn't notice the "in text tables" part. Should we make th
I agree that difference between text and Parquet could be emphasized. For example:
Interoperability between Hive and Impala is different depending on the file format:
- Text - ...
- Parquet - ...
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 17:15:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/155/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a
Gerrit-Change-Number: 11946
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 03:18:23 +0000
Gerrit-HasComments: No