[GitHub] [airflow] kaxil commented on a change in pull request #13392: Add upgrade check option to list checks

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r553068262



##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
     return all_rule_statuses
 
 
+def list_checks():
+    print()
+    print("Upgrade Checks:")
+    for rule in ALL_RULES:
+        rule_name = rule.__class__.__name__
+        print("- {} [{}]".format(rule.title, rule_name))

Review comment:
       Would be awesome to have a tabular format (makes it more readable) like below but not a requirement for this PR :)
   
   ```
   | ClassName                                | Description                                                       |
   |------------------------------------------|-------------------------------------------------------------------|
   | VersionCheckRule                         | Check for latest versions of apache-airflow and checker           |
   | AirflowMacroPluginRemovedRule            | Remove airflow.AirflowMacroPlugin class                           |
   | BaseOperatorMetaclassRule                | Ensure users are not using custom metaclasses in custom operators |
   | ChainBetweenDAGAndOperatorNotAllowedRule | Chain between DAG and operator not allowed.                       |
   | ConnTypeIsNotNullableRule                | Connection.conn_type is not nullable                              |
   | DbApiRule                                | Hooks that run DB functions must inherit from DBApiHook           |
   | FernetEnabledRule                        | Fernet is enabled by default                                      |
   | GCPServiceAccountKeyRule                 | GCP service account key deprecation                               |
   | HostnameCallable                         | Unify hostname_callable option in core section                    |
   | ImportChangesRule                        | Changes in import paths of hooks, operators, sensors and others   |
   | LegacyUIDeprecated                       | Legacy UI is deprecated by default                                |
   | LoggingConfigurationRule                 | Logging configuration has been moved to new section               |
   | MesosExecutorRemovedRule                 | Removal of Mesos Executor                                         |
   | NoAdditionalArgsInOperatorsRule          | No additional argument allowed in BaseOperator.                   |
   | PodTemplateFileRule                      | Users must set a kubernetes.pod_template_file value               |
   | SendGridEmailerMovedRule                 | SendGrid email uses old airflow.contrib module                    |
   | TaskHandlersMovedRule                    | Changes in import path of remote task handlers                    |
   | UndefinedJinjaVariablesRule              | Jinja Template Variables cannot be undefined                      |
   | UniqueConnIdRule                         | Connection.conn_id is not unique                                  |
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org