You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/12/15 03:14:59 UTC
Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Bugs: MESOS-4137
https://issues.apache.org/jira/browse/MESOS-4137
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
Diff: https://reviews.apache.org/r/41378/diff/
Testing
-------
make (OSX, Centos7)
make check (OSX, Centos7)
sudo bin/mesos-tests.sh (Centos7)
Thanks,
Joseph Wu
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review112257
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Dec. 22, 2015, 1:35 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 1:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp a43e355405b37443601c0993d36821c50056c24f
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review111577
-----------------------------------------------------------
Bad patch!
Reviews applied: [41002, 41003, 41004, 41061, 41111]
Failed command: ./support/apply-review.sh -n -r 41111
Error:
2015-12-22 04:23:32 URL:https://reviews.apache.org/r/41111/diff/raw/ [5617/5617] -> "41111.patch" [1]
error: patch failed: src/Makefile.am:1731
error: src/Makefile.am: patch does not apply
- Mesos ReviewBot
On Dec. 22, 2015, 1:35 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 1:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp a43e355405b37443601c0993d36821c50056c24f
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 5:35 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Remove `ContainerLogger` injection from the `Docker` class.
Bugs: MESOS-4137
https://issues.apache.org/jira/browse/MESOS-4137
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp a43e355405b37443601c0993d36821c50056c24f
src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
Diff: https://reviews.apache.org/r/41378/diff/
Testing
-------
make (OSX, Centos7)
make check (OSX, Centos7)
sudo bin/mesos-tests.sh (Centos7)
Thanks,
Joseph Wu
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 226
> > <https://reviews.apache.org/r/41378/diff/1/?file=1164065#file1164065line226>
> >
> > If we expect NULL to be a valid option we should make it an Option.
>
> Joseph Wu wrote:
> NULL is not a valid argument. But for some of these tests, I thought it would unnecessarily bloat the test code to create an unused `ContainerLogger`.
Note: the latest diff removed this change.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review110398
-----------------------------------------------------------
On Dec. 21, 2015, 5:35 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 5:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp a43e355405b37443601c0993d36821c50056c24f
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 226
> > <https://reviews.apache.org/r/41378/diff/1/?file=1164065#file1164065line226>
> >
> > If we expect NULL to be a valid option we should make it an Option.
NULL is not a valid argument. But for some of these tests, I thought it would unnecessarily bloat the test code to create an unused `ContainerLogger`.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review110398
-----------------------------------------------------------
On Dec. 14, 2015, 6:14 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
> src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review110398
-----------------------------------------------------------
src/tests/environment.cpp (line 226)
<https://reviews.apache.org/r/41378/#comment170227>
If we expect NULL to be a valid option we should make it an Option.
- Timothy Chen
On Dec. 15, 2015, 2:14 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 2:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
> src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 20, 2015, 3:24 p.m., Benjamin Hindman wrote:
> > So, are you sure we need `CreateContainerLogger` and not just `ContainerLogger::create`? If we're not extending it than I don't know that we need it for now. Also, this looks nice and mechanical given https://reviews.apache.org/r/41294 but please see comment there. Thanks!
Yup, the test helper was removed.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review111433
-----------------------------------------------------------
On Dec. 21, 2015, 5:35 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 5:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp a43e355405b37443601c0993d36821c50056c24f
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41378: Logger Module: Update tests that use the
DockerContainerizer to pass in a ContainerLogger.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41378/#review111433
-----------------------------------------------------------
So, are you sure we need `CreateContainerLogger` and not just `ContainerLogger::create`? If we're not extending it than I don't know that we need it for now. Also, this looks nice and mechanical given https://reviews.apache.org/r/41294 but please see comment there. Thanks!
- Benjamin Hindman
On Dec. 15, 2015, 2:14 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41378/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 2:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
> src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
>
> Diff: https://reviews.apache.org/r/41378/diff/
>
>
> Testing
> -------
>
> make (OSX, Centos7)
> make check (OSX, Centos7)
> sudo bin/mesos-tests.sh (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>