[GitHub] [knox] smolnar82 commented on a diff in pull request #687: KNOX-2848: Prevent overwriting generated descriptors/providers

[GitBox <gi...@apache.org>]

smolnar82 commented on code in PR #687:
URL: https://github.com/apache/knox/pull/687#discussion_r1038248513


##########
gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/TopologiesResource.java:
##########
@@ -424,6 +429,14 @@ public Response uploadSimpleDescriptor(@PathParam("name") String name,
     return response;
   }
 
+  private boolean existingGeneratedTopology(String fileName, TopologyService topologyService, GatewayConfig config) {
+    for (org.apache.knox.gateway.topology.Topology topology : topologyService.getTopologies()) {

Review Comment:
   I do not see where we check if the given topology is `readOnly`. This implementation will prevent creating/overwriting all topologies, won't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org