You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/05/01 18:38:21 UTC
[Apache Bloodhound] #50: Implement ticket view
#50: Implement ticket view
-----------------------+-------------------------------------
Reporter: gjm | Owner: jdreimann
Type: task | Status: new
Priority: major | Milestone: RC1 for initial release
Component: dashboard | Version:
Keywords: |
-----------------------+-------------------------------------
Current design is in
https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
templates/ticket.html
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: closed
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: fixed | Keywords: ticket bootstrap
------------------------+-------------------------------------
Changes (by gjm):
* status: accepted => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Gary <ga...@wandisco.com>.
Joe,
I assigned this to you only to check that this design is complete. I
don't think that implementation has been looked at with another ticket.
Obviously others are welcome to comment but if you think it is ready,
set the owner to nobody or update the ticket with any necessary
information if it isn't.
Cheers,
Gary
On 05/01/2012 05:38 PM, Apache Bloodhound wrote:
> #50: Implement ticket view
> -----------------------+-------------------------------------
> Reporter: gjm | Owner: jdreimann
> Type: task | Status: new
> Priority: major | Milestone: RC1 for initial release
> Component: dashboard | Version:
> Keywords: |
> -----------------------+-------------------------------------
> Current design is in
>
> https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
> templates/ticket.html
>
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by olemis):
Attached patches implement ticket view powered by ''bootstrap'' . Apply
them against r1335612 , on top of patches implementing #40 i.e.
{{{
#!sh
$ hg qapplied
t40/t40_r1335525_theme_requires_dashboard.diff
t40/t40_r1335525_move_milestone_view_theme.diff
t50/t50_r1335612_textarea_padding.diff
t50/t50_r1335612_ticket.diff
}}}
... after applying these there's still a pending [#63 issue related to
comments and threads] .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Joachim Dreimann <jo...@wandisco.com>.
I've had a look and make some minor modifications. This should now be
ready to be implemented, as long as the comments I've made are taken
account of. Suggestions for how to resolve them are encouraged!
- Joe
On 2 May 2012 12:15, Apache Bloodhound
<bl...@incubator.apache.org> wrote:
> #50: Implement ticket view
> ------------------------+-------------------------------------
> Reporter: gjm | Owner: jdreimann
> Type: task | Status: new
> Priority: major | Milestone: RC1 for initial release
> Component: dashboard | Version:
> Resolution: | Keywords:
> ------------------------+-------------------------------------
>
> Comment (by jdreimann):
>
> I've updated the style now (r1332992) , so it should be good to go.
>
> I'd just like to reiterate that the way it looks should be a close match
> once implemented, but some of the code is messy:
> - There's an empty div with a fixed height to push the footer further down
> - The way the relative date/time is aligned in comments isn't viable -
> they stick out of the application frame on the left.
> - The comment box is not a full 100% wide, which it should be. This may be
> because it has to be wrapped in a <form> to achieve this, but I'm not
> sure.
>
> The actual implementation should fix these three issues, and I'm open to
> suggestions on how to fix them in the mockups too.
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:1>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: jdreimann
Type: task | Status: new
Priority: major | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords:
------------------------+-------------------------------------
Comment (by jdreimann):
I've updated the style now (r1332992) , so it should be good to go.
I'd just like to reiterate that the way it looks should be a close match
once implemented, but some of the code is messy:
- There's an empty div with a fixed height to push the footer further down
- The way the relative date/time is aligned in comments isn't viable -
they stick out of the application frame on the left.
- The comment box is not a full 100% wide, which it should be. This may be
because it has to be wrapped in a <form> to achieve this, but I'm not
sure.
The actual implementation should fix these three issues, and I'm open to
suggestions on how to fix them in the mockups too.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by gjm):
That sounds fine. I think it is important not to race too far ahead. In-
place edit will remain on the list of things to do but it is something
that can slip to the next milestone.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by gjm):
r1338129 applies the ticket.diff patch (textarea_padding.diff largely
ignored as it mostly touched unrelated files)
widget_macros_nocomment.diff does not really belong here so creating a
general comment cleanup ticket for it to be a part of -> #70
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by gjm):
Does this ticket specifically require the in-place edit code. Given that
we cannot guarantee js being active, perhaps we should make sure that we
get a reasonable experience without the in-place editing before
considering this feature?
My current thoughts on the second point are put in ticket:40#comment:2 -
we do need a quick resolution for this if it is likely to hold up work.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by olemis):
Please '''in dashboard plugin''' apply
[attachment:t50_r1328362_widget_macros_nocomment.diff another patch]
fixing a minor issue . Apply it on top of the patches uploaded to
implement #40 ( against r1328362 ). Consider this order :
{{{
#!sh
$ hg qapplied
t40/t40_r1328362_duplicate_webui.diff
t40/t40_r1328362_glyphicons_dashboard.diff
t40/t40_r1328362_remove_milestone_view.diff
t50/t50_r1328362_widget_macros_nocomment.diff
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Changes (by olemis):
* keywords: => ticket bootstrap
Comment:
I started to review this ticket so as to provide Genshi template(s)
implementing bootstrap styles, controls , best practices ... just like
before (e.g. #15 , #41 , #10 , #8 , #58 , #59 ) . In order to get this
done IMO first we should decide what to do with the following subjects :
1. Decide how to implement in-place edit .
a. Will we use ''jEditable'' ?
b. Otherwise what other js framework | library will be used ?
1. This is a task illustrating that we really should move
forward with #40 and merge theme and dashboard plugins into
a single '''Bloodhound UI''' plugin.
I look forward to your comments . It seems I really cannot start working
on this until I know what's going to happen with subjects above .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords:
------------------------+-------------------------------------
Changes (by olemis):
* owner: unassigned => olemis
* status: assigned => accepted
* cc: olemis+bh@… (added)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by olemis):
Yes ... '''(2)''' has been [ sorted out temporarily] .
About '''(1)''' after looking at
[https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
templates/ticket.html the mockup] it seems (to me ''';)''' that in-place
editing is required (cmiiw)
Nonetheless , at least for this initial release what I'm doing is trying
to make legacy ticket web UI look like as similar to
[https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
templates/ticket.html the mockup] as possible , but keeping ''Modify
ticket section'' at the bottom. We can decide later what to do in order to
introduce in-place editing . Is that ok ?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords: ticket bootstrap
------------------------+-------------------------------------
Comment (by olemis):
Screenshots illustrate how ticket web UI looks like after applying patches
mentioned above.
[[Image(bh_theme_x_23_ticket_box_attachments.png, width=600)]]
[[Image(bh_theme_x_24_ticket_changelog.png, width=600)]]
[[Image(bh_theme_x_25_ticket_modify.png, width=600)]]
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #50: Implement ticket view
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#50: Implement ticket view
------------------------+-------------------------------------
Reporter: gjm | Owner: unassigned
Type: task | Status: assigned
Priority: critical | Milestone: RC1 for initial release
Component: dashboard | Version:
Resolution: | Keywords:
------------------------+-------------------------------------
Changes (by jdreimann):
* status: new => assigned
* owner: jdreimann => unassigned
* priority: major => critical
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/50#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker