You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/06 13:20:47 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Spaceman1984 opened a new pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187
…bases
### Description
This PR adds the ability to run the cloudstack-setup-databases script without having to know the root user credentials.
The cloud and cloud_usage databases and cloud user have to be manually configured prior to running the script.
It will allow the script to be called like this:
./cloudstack-setup-databases user:password -s
Using this flag will instruct to skip the SQL files responsible for creating the databases, user and granting permissions to the user. It will still run all other SQL scripts that need to be run before starting the management server for the first time. Initial databases and user creation will be the responsibility of the administrator.
<!--- Describe your changes in DETAIL - And how has behavior functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviors, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This has been tested by creating the cloud and cloud_usage databases and cloud user prior to executing the script like this:
./cloudstack-setup-databases user:password -s
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665927710
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
The database creation, and user creation is skipped and the root user and password is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r666787861
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -188,7 +188,10 @@ for full help
sys.exit(1)
def setupDBSchema(self):
- if not self.rootuser:
+ if self.options.schemaonly and self.rootuser != None:
+ self.info("--schema-only and --deploy-as cannot be passed together\n", None)
Review comment:
Done
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-875498153
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-888866912
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-891361846
<b>Trillian test result (tid-1448)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46832 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5187-t1448-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 87 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 490.01 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 528.37 | test_vpc_redundant.py
test_disable_oobm_ha_state_ineligible | `Error` | 1512.83 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665934089
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -188,7 +188,7 @@ for full help
sys.exit(1)
def setupDBSchema(self):
- if not self.rootuser:
+ if not self.options.createschema and not self.rootuser:
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665988233
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
I think, it is better to allow only one option
_cloudstack-setup-databases cloud:<dbpassword>@<host>:<post> [ --schema-only | --deploy-as=root:<password> ]_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-875481141
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665895974
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -576,7 +580,11 @@ for example:
self.parser.add_option("-j", "--encryption-jar-path", action="store", dest="encryptionJarPath", help="The path to the jasypt library to be used to encrypt the values in db.properties")
self.parser.add_option("-n", "--encryption-key-file", action="store", dest="encryptionKeyFile", help="The name of the file in which encryption key to be generated")
self.parser.add_option("-b", "--mysql-bin-path", action="store", dest="mysqlbinpath", help="The mysql installed bin path")
-
+ self.parser.add_option("-s", "--create-schema-only", action="store_true", dest="createschema", default=False,
Review comment:
'_--schema-only_' option should be ok here ?
```suggestion
self.parser.add_option("-s", "--schema-only", action="store_true", dest="schemaonly", default=False,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877163804
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665988233
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
I think, it is better to allow only one option
`cloudstack-setup-databases cloud:<dbpassword>@<mysql-host>:<port> [ --schema-only | --deploy-as=root:<password> ]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-875481656
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-875499960
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-888894192
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665990828
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
ok, I'll make it fail if you pass both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r666744068
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -188,7 +188,10 @@ for full help
sys.exit(1)
def setupDBSchema(self):
- if not self.rootuser:
+ if self.options.schemaonly and self.rootuser != None:
+ self.info("--schema-only and --deploy-as cannot be passed together\n", None)
Review comment:
@Spaceman1984 It is better to check this, soon after parsing the options passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665895974
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -576,7 +580,11 @@ for example:
self.parser.add_option("-j", "--encryption-jar-path", action="store", dest="encryptionJarPath", help="The path to the jasypt library to be used to encrypt the values in db.properties")
self.parser.add_option("-n", "--encryption-key-file", action="store", dest="encryptionKeyFile", help="The name of the file in which encryption key to be generated")
self.parser.add_option("-b", "--mysql-bin-path", action="store", dest="mysqlbinpath", help="The mysql installed bin path")
-
+ self.parser.add_option("-s", "--create-schema-only", action="store_true", dest="createschema", default=False,
Review comment:
'_--schema-only_' option should be ok ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877162625
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-889535808
<b>Trillian test result (tid-1404)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55784 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5187-t1404-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.55 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.18 | test_primary_storage.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 521.22 | test_internal_lb.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3606.28 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3614.50 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 89.41 | test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | test_snapshots.py
test_01_secure_vm_migration | `Error` | 158.48 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 271.83 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 144.80 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.66 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | `Failure` | 1510.42 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-875996513
<b>Trillian test result (tid-1215)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5187-t1215-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 530.12 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 502.25 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665932620
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -576,7 +580,11 @@ for example:
self.parser.add_option("-j", "--encryption-jar-path", action="store", dest="encryptionJarPath", help="The path to the jasypt library to be used to encrypt the values in db.properties")
self.parser.add_option("-n", "--encryption-key-file", action="store", dest="encryptionKeyFile", help="The name of the file in which encryption key to be generated")
self.parser.add_option("-b", "--mysql-bin-path", action="store", dest="mysqlbinpath", help="The mysql installed bin path")
-
+ self.parser.add_option("-s", "--create-schema-only", action="store_true", dest="createschema", default=False,
+ help="Creates the db schema without having to pass root credentials - "\
Review comment:
This will allow flexibility in the sense that if 2 people in an organization are given two different roles. One person can create the databases and another can fire scripts on it without having the root credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877522028
<b>Trillian test result (tid-1226)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40205 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5187-t1226-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 552.13 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877164069
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877044810
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-895985674
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-888893842
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-888867100
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877148367
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-888884476
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-875499237
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877147899
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665940656
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -576,7 +580,11 @@ for example:
self.parser.add_option("-j", "--encryption-jar-path", action="store", dest="encryptionJarPath", help="The path to the jasypt library to be used to encrypt the values in db.properties")
self.parser.add_option("-n", "--encryption-key-file", action="store", dest="encryptionKeyFile", help="The name of the file in which encryption key to be generated")
self.parser.add_option("-b", "--mysql-bin-path", action="store", dest="mysqlbinpath", help="The mysql installed bin path")
-
+ self.parser.add_option("-s", "--create-schema-only", action="store_true", dest="createschema", default=False,
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877029088
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665988233
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
I think, it is better to allow only one option
`cloudstack-setup-databases cloud:<dbpassword>@<host>:<post> [ --schema-only | --deploy-as=root:<password> ]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#issuecomment-877028802
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665895030
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -188,7 +188,7 @@ for full help
sys.exit(1)
def setupDBSchema(self):
- if not self.rootuser:
+ if not self.options.createschema and not self.rootuser:
Review comment:
options.createschemaonly makes it more readable, can you please change that.
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -576,7 +580,11 @@ for example:
self.parser.add_option("-j", "--encryption-jar-path", action="store", dest="encryptionJarPath", help="The path to the jasypt library to be used to encrypt the values in db.properties")
self.parser.add_option("-n", "--encryption-key-file", action="store", dest="encryptionKeyFile", help="The name of the file in which encryption key to be generated")
self.parser.add_option("-b", "--mysql-bin-path", action="store", dest="mysqlbinpath", help="The mysql installed bin path")
-
+ self.parser.add_option("-s", "--create-schema-only", action="store_true", dest="createschema", default=False,
+ help="Creates the db schema without having to pass root credentials - "\
Review comment:
any specific reason why we don't need to provide root credentials here ? I agree if we might not need it to create schema but in general, for running these kind of scripts I think it is good to ask the credentials. Correct me if anything else needs to consider. @Spaceman1984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665902675
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
@Spaceman1984 what's the behavior when both 'schema-only' and 'deploy-as' options are passed to the script, and have valid values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org