You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 10:01:08 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #22641: Disable SLAs for mapped operators

eladkal commented on a change in pull request #22641:
URL: https://github.com/apache/airflow/pull/22641#discussion_r839410735



##########
File path: airflow/models/mappedoperator.py
##########
@@ -278,6 +278,11 @@ def __attrs_post_init__(self):
         for k, v in self.partial_kwargs.items():
             if k in self.template_fields:
                 XComArg.apply_upstream_relationship(self, v)
+        if self.partial_kwargs.get('sla'):
+            raise AirflowException(
+                f"SLAs are unsupported with mapped tasks. Please set `sla=None` for task "
+                f"{self.task_id!r}."
+            )

Review comment:
       Should we consider chaning it to a notice/warnning and set it to None rather than raising exception?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org