You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mr...@apache.org on 2010/07/18 18:05:35 UTC
svn commit: r965252 - in
/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces: impl/
impl/dtd/ impl/dv/xs/ impl/xpath/ impl/xpath/regex/ impl/xs/ parsers/ util/
Author: mrglavas
Date: Sun Jul 18 16:05:34 2010
New Revision: 965252
URL: http://svn.apache.org/viewvc?rev=965252&view=rev
Log:
Minor improvement. Use StringBuffer.append(char) for one char length strings.
Modified:
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLDTDScannerImpl.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLScanner.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/XPath.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/regex/RangeToken.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSComplexTypeDecl.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSParticleDecl.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSWildcardDecl.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/parsers/AbstractSAXParser.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/util/NamespaceSupport.java
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLDTDScannerImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLDTDScannerImpl.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLDTDScannerImpl.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLDTDScannerImpl.java Sun Jul 18 16:05:34 2010
@@ -1469,7 +1469,7 @@ public class XMLDTDScannerImpl
if(fNamespaces && fEntityScanner.peekChar() == ':') {
fEntityScanner.scanChar();
XMLStringBuffer colonName = new XMLStringBuffer(name);
- colonName.append(":");
+ colonName.append(':');
String str = fEntityScanner.scanName();
if (str != null)
colonName.append(str);
@@ -1720,7 +1720,7 @@ public class XMLDTDScannerImpl
if(fNamespaces && fEntityScanner.peekChar() == ':') {
fEntityScanner.scanChar();
XMLStringBuffer colonName = new XMLStringBuffer(name);
- colonName.append(":");
+ colonName.append(':');
colonName.append(fEntityScanner.scanName());
reportFatalError("ColonNotLegalWithNS", new Object[] {colonName.toString()});
skipSeparator(true, !scanningInternalSubset());
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLScanner.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLScanner.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLScanner.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/XMLScanner.java Sun Jul 18 16:05:34 2010
@@ -663,7 +663,7 @@ public abstract class XMLScanner
if(fNamespaces && fEntityScanner.peekChar() == ':') {
fEntityScanner.scanChar();
XMLStringBuffer colonName = new XMLStringBuffer(target);
- colonName.append(":");
+ colonName.append(':');
String str = fEntityScanner.scanName();
if (str != null)
colonName.append(str);
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dtd/XMLDTDValidator.java Sun Jul 18 16:05:34 2010
@@ -1802,7 +1802,7 @@ public class XMLDTDValidator
buffer.append('(');
for (int i=0; i<attrDecl.simpleType.enumeration.length ; i++) {
if (i > 0) {
- buffer.append("|");
+ buffer.append('|');
}
buffer.append(attrDecl.simpleType.enumeration[i]);
}
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java Sun Jul 18 16:05:34 2010
@@ -765,7 +765,7 @@ public abstract class AbstractDateTimeDV
else if (value < 100)
message.append("00");
else if (value < 1000)
- message.append("0");
+ message.append('0');
message.append(value);
}
else if (nch == 2) {
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/XPath.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/XPath.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/XPath.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/XPath.java Sun Jul 18 16:05:34 2010
@@ -105,7 +105,7 @@ public class XPath {
StringBuffer buf=new StringBuffer();
for (int i=0;i<fLocationPaths.length;i++){
if (i>0){
- buf.append("|");
+ buf.append('|');
}
buf.append(fLocationPaths[i].toString());
}
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/regex/RangeToken.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/regex/RangeToken.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/regex/RangeToken.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xpath/regex/RangeToken.java Sun Jul 18 16:05:34 2010
@@ -553,9 +553,9 @@ final class RangeToken extends Token imp
ret = "\\s";
else {
StringBuffer sb = new StringBuffer();
- sb.append("[");
+ sb.append('[');
for (int i = 0; i < this.ranges.length; i += 2) {
- if ((options & RegularExpression.SPECIAL_COMMA) != 0 && i > 0) sb.append(",");
+ if ((options & RegularExpression.SPECIAL_COMMA) != 0 && i > 0) sb.append(',');
if (this.ranges[i] == this.ranges[i+1]) {
sb.append(escapeCharInCharClass(this.ranges[i]));
} else {
@@ -564,7 +564,7 @@ final class RangeToken extends Token imp
sb.append(escapeCharInCharClass(this.ranges[i+1]));
}
}
- sb.append("]");
+ sb.append(']');
ret = sb.toString();
}
} else {
@@ -578,7 +578,7 @@ final class RangeToken extends Token imp
StringBuffer sb = new StringBuffer();
sb.append("[^");
for (int i = 0; i < this.ranges.length; i += 2) {
- if ((options & RegularExpression.SPECIAL_COMMA) != 0 && i > 0) sb.append(",");
+ if ((options & RegularExpression.SPECIAL_COMMA) != 0 && i > 0) sb.append(',');
if (this.ranges[i] == this.ranges[i+1]) {
sb.append(escapeCharInCharClass(this.ranges[i]));
} else {
@@ -587,7 +587,7 @@ final class RangeToken extends Token imp
sb.append(escapeCharInCharClass(this.ranges[i+1]));
}
}
- sb.append("]");
+ sb.append(']');
ret = sb.toString();
}
}
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSComplexTypeDecl.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSComplexTypeDecl.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSComplexTypeDecl.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSComplexTypeDecl.java Sun Jul 18 16:05:34 2010
@@ -229,7 +229,7 @@ public class XSComplexTypeDecl implement
String contentType[] = {"EMPTY", "SIMPLE", "ELEMENT", "MIXED"};
String derivedBy[] = {"EMPTY", "EXTENSION", "RESTRICTION"};
- str.append("Complex type name='").append(fTargetNamespace).append(",").append(getTypeName()).append("', ");
+ str.append("Complex type name='").append(fTargetNamespace).append(',').append(getTypeName()).append("', ");
if (fBaseType != null) {
str.append(" base type name='").append(fBaseType.getName()).append("', ");
}
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSParticleDecl.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSParticleDecl.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSParticleDecl.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSParticleDecl.java Sun Jul 18 16:05:34 2010
@@ -132,12 +132,12 @@ public class XSParticleDecl implements X
appendParticle(buffer);
if (!(fMinOccurs == 0 && fMaxOccurs == 0 ||
fMinOccurs == 1 && fMaxOccurs == 1)) {
- buffer.append("{").append(fMinOccurs);
+ buffer.append('{').append(fMinOccurs);
if (fMaxOccurs == SchemaSymbols.OCCURRENCE_UNBOUNDED)
buffer.append("-UNBOUNDED");
else if (fMinOccurs != fMaxOccurs)
- buffer.append("-").append(fMaxOccurs);
- buffer.append("}");
+ buffer.append('-').append(fMaxOccurs);
+ buffer.append('}');
}
fDescription = buffer.toString();
}
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSWildcardDecl.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSWildcardDecl.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSWildcardDecl.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/XSWildcardDecl.java Sun Jul 18 16:05:34 2010
@@ -211,10 +211,10 @@ public class XSWildcardDecl implements X
buffer.append(", ");
buffer.append(SchemaSymbols.ATTVAL_TWOPOUNDDEFINEDSIBLING);
}
- buffer.append(")");
+ buffer.append(')');
}
- buffer.append("]");
+ buffer.append(']');
fDescription = buffer.toString();
}
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/parsers/AbstractSAXParser.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/parsers/AbstractSAXParser.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/parsers/AbstractSAXParser.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/parsers/AbstractSAXParser.java Sun Jul 18 16:05:34 2010
@@ -918,7 +918,7 @@ public abstract class AbstractSAXParser
// SAX2 extension
if (fDeclHandler != null) {
// used as a key to detect duplicate attribute definitions.
- String elemAttr = new StringBuffer(elementName).append("<").append(attributeName).toString();
+ String elemAttr = new StringBuffer(elementName).append('<').append(attributeName).toString();
if(fDeclaredAttrs.get(elemAttr) != null) {
// we aren't permitted to return duplicate attribute definitions
return;
@@ -933,7 +933,7 @@ public abstract class AbstractSAXParser
str.append(" (");
}
else {
- str.append("(");
+ str.append('(');
}
for (int i = 0; i < enumeration.length; i++) {
str.append(enumeration[i]);
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/util/NamespaceSupport.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/util/NamespaceSupport.java?rev=965252&r1=965251&r2=965252&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/util/NamespaceSupport.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/util/NamespaceSupport.java Sun Jul 18 16:05:34 2010
@@ -320,7 +320,7 @@ public class NamespaceSupport implements
StringBuffer buf = new StringBuffer();
for (int i=0;i<size;i++){
buf.append(prefixes[i]);
- buf.append(" ");
+ buf.append(' ');
}
return buf.toString();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org