[jira] [Commented] (TINKERPOP3-333) SubgraphStrategy (and others? Partition/ReadOnly) need VertexProperty support.

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624944#comment-14624944 ] 

stephen mallette commented on TINKERPOP3-333:
---------------------------------------------

Was just looking at this in greater detail - the {{asVertex}} member variable is set via:

https://github.com/apache/incubator-tinkerpop/blob/be3aa546be934a0e3e1bba0f090af18f1f6ab22d/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java#L53

essentially:

{code}
this.asVertex = null != cardinality || this.vertexPropertyKeyValues.length > 0;
{code}

but that doesn't will allow {{asVertex}} to be set to {{false}} if called as follows:

{code}
__.outV().property("name", "stephen")
{code}

which means it then isn't always reliable for determining if the property being set applies to a {{Vertex}} and therefore isn't good for determining if a partition key/value should be popped in as a meta-property. 

> SubgraphStrategy (and others? Partition/ReadOnly) need VertexProperty support.
> ------------------------------------------------------------------------------
>
>                 Key: TINKERPOP3-333
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-333
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: structure
>            Reporter: Marko A. Rodriguez
>            Assignee: stephen mallette
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)