[GitHub] [trafficserver] maskit commented on a change in pull request #7887: Fail parsing the request line version if there are too many characters

[GitBox <gi...@apache.org>]

maskit commented on a change in pull request #7887:
URL: https://github.com/apache/trafficserver/pull/7887#discussion_r643572717



##########
File path: proxy/hdrs/HTTP.cc
##########
@@ -1088,6 +1088,11 @@ http_parser_parse_req(HTTPParser *parser, HdrHeap *heap, HTTPHdrImpl *hh, const
     }
     url_end += 1;
 
+    // Make sure we didn't pickup odd characters in the url between the method and version
+    if (!url_is_compliant(url_start, url_end)) {

Review comment:
       The same check will be done later when `url_parse` is called, if `strict_uri_parsing` is `true`. In other words, there might be a case we want to accept an invalid URL? Adding this check here effectively makes the flag void.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org