[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql

[GitBox <gi...@apache.org>]

pan3793 commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1077042702


   > Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`
   
   The procedure is a dedicated syntax, `CALL procedure_name(arg1, arg2 ...)`, `CREATE ENGINE` is command style, the equality procedure style is something like `CALL stop_engine(engine_id: string)`
   
   >  I think it makes sense to just add this inside tpcds module
   
   I would like to add it into `kyuubi-extension-spark-common`, along with Z-Order syntax, and rename `ZorderSqlExtensions.g4` to a more common name, e.g. `KyuubiExtensions.g4`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org