You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sirona.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2015/05/20 10:00:18 UTC
Fwd: svn commit: r1680445 - /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Hello
Just curious, how can you get it?
---------- Message transféré ----------
De : <ol...@apache.org>
Date : 20 mai 2015 05:00
Objet : svn commit: r1680445 -
/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
À : <co...@sirona.incubator.apache.org>
Cc :
Author: olamy
Date: Wed May 20 03:00:02 2015
New Revision: 1680445
URL: http://svn.apache.org/r1680445
Log:
prevent NPE with null key
Modified:
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Modified:
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
URL:
http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1680445&r1=1680444&r2=1680445&view=diff
==============================================================================
---
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
(original)
+++
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Wed May 20 03:00:02 2015
@@ -60,6 +60,8 @@ public class AgentContext {
private static final Object[] EMPTY_ARRAY = new Object[0];
+ private static final InvocationListener[] EMPTY_LISTENERS_ARRAY = new
InvocationListener[0];
+
public static void addAgentParameter( String key, String value){
AGENT_PARAMETERS.put(key, value);
}
@@ -131,6 +133,9 @@ public class AgentContext {
}
public static InvocationListener[] listeners(final String key, final
byte[] buffer) {
+ if (key == null){
+ return EMPTY_LISTENERS_ARRAY;
+ }
InvocationListener[] listeners = LISTENERS_BY_KEY.get(key);
if (listeners == null && buffer != null) {
listeners = findListeners(key, buffer);
Re: svn commit: r1680445 - /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Ok so a proxy or something which should get skipped surely (ie no bytecode
to read)
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>
2015-05-20 13:09 GMT+02:00 Olivier Lamy <ol...@apache.org>:
> I got that:
> java.lang.NullPointerException
> at
> org.apache.sirona.javaagent.AgentContext.listeners(AgentContext.java:134)
> at
>
> org.apache.sirona.javaagent.SironaClassVisitor.visitMethod(SironaClassVisitor.java:109)
> at com.telstra.javaagent.deps.org.objectweb.asm.ClassReader.b(Unknown
> Source)
> at com.telstra.javaagent.deps.org.objectweb.asm.ClassReader.accept(Unknown
> Source)
> at com.telstra.javaagent.deps.org.objectweb.asm.ClassReader.accept(Unknown
> Source)
> at
>
> com.telstra.javaagent.jms.WeblogicThreadTransformer.transform(WeblogicThreadTransformer.java:87)
>
> I reckon this is a bit weird :-)
>
>
>
> On 20 May 2015 at 18:00, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> > Hello
> >
> > Just curious, how can you get it?
> > ---------- Message transféré ----------
> > De : <ol...@apache.org>
> > Date : 20 mai 2015 05:00
> > Objet : svn commit: r1680445 -
> >
> >
> /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> > À : <co...@sirona.incubator.apache.org>
> > Cc :
> >
> > Author: olamy
> > Date: Wed May 20 03:00:02 2015
> > New Revision: 1680445
> >
> > URL: http://svn.apache.org/r1680445
> > Log:
> > prevent NPE with null key
> >
> > Modified:
> >
> >
> >
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> >
> > Modified:
> >
> >
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> > URL:
> >
> >
> http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1680445&r1=1680444&r2=1680445&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> >
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> > (original)
> > +++
> >
> >
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> > Wed May 20 03:00:02 2015
> > @@ -60,6 +60,8 @@ public class AgentContext {
> >
> > private static final Object[] EMPTY_ARRAY = new Object[0];
> >
> > + private static final InvocationListener[] EMPTY_LISTENERS_ARRAY =
> new
> > InvocationListener[0];
> > +
> > public static void addAgentParameter( String key, String value){
> > AGENT_PARAMETERS.put(key, value);
> > }
> > @@ -131,6 +133,9 @@ public class AgentContext {
> > }
> >
> > public static InvocationListener[] listeners(final String key, final
> > byte[] buffer) {
> > + if (key == null){
> > + return EMPTY_LISTENERS_ARRAY;
> > + }
> > InvocationListener[] listeners = LISTENERS_BY_KEY.get(key);
> > if (listeners == null && buffer != null) {
> > listeners = findListeners(key, buffer);
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: svn commit: r1680445 - /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Posted by Olivier Lamy <ol...@apache.org>.
I got that:
java.lang.NullPointerException
at org.apache.sirona.javaagent.AgentContext.listeners(AgentContext.java:134)
at
org.apache.sirona.javaagent.SironaClassVisitor.visitMethod(SironaClassVisitor.java:109)
at com.telstra.javaagent.deps.org.objectweb.asm.ClassReader.b(Unknown
Source)
at com.telstra.javaagent.deps.org.objectweb.asm.ClassReader.accept(Unknown
Source)
at com.telstra.javaagent.deps.org.objectweb.asm.ClassReader.accept(Unknown
Source)
at
com.telstra.javaagent.jms.WeblogicThreadTransformer.transform(WeblogicThreadTransformer.java:87)
I reckon this is a bit weird :-)
On 20 May 2015 at 18:00, Romain Manni-Bucau <rm...@gmail.com> wrote:
> Hello
>
> Just curious, how can you get it?
> ---------- Message transféré ----------
> De : <ol...@apache.org>
> Date : 20 mai 2015 05:00
> Objet : svn commit: r1680445 -
>
> /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> À : <co...@sirona.incubator.apache.org>
> Cc :
>
> Author: olamy
> Date: Wed May 20 03:00:02 2015
> New Revision: 1680445
>
> URL: http://svn.apache.org/r1680445
> Log:
> prevent NPE with null key
>
> Modified:
>
>
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
>
> Modified:
>
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> URL:
>
> http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1680445&r1=1680444&r2=1680445&view=diff
>
> ==============================================================================
> ---
>
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> (original)
> +++
>
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> Wed May 20 03:00:02 2015
> @@ -60,6 +60,8 @@ public class AgentContext {
>
> private static final Object[] EMPTY_ARRAY = new Object[0];
>
> + private static final InvocationListener[] EMPTY_LISTENERS_ARRAY = new
> InvocationListener[0];
> +
> public static void addAgentParameter( String key, String value){
> AGENT_PARAMETERS.put(key, value);
> }
> @@ -131,6 +133,9 @@ public class AgentContext {
> }
>
> public static InvocationListener[] listeners(final String key, final
> byte[] buffer) {
> + if (key == null){
> + return EMPTY_LISTENERS_ARRAY;
> + }
> InvocationListener[] listeners = LISTENERS_BY_KEY.get(key);
> if (listeners == null && buffer != null) {
> listeners = findListeners(key, buffer);
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy