You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2010/04/22 17:43:15 UTC

Re: svn commit: r936802 - /subversion/trunk/subversion/tests/svn_test_main.c

On Thu, Apr 22, 2010 at 08:03,  <st...@apache.org> wrote:
> Author: stsp
> Date: Thu Apr 22 12:03:40 2010
> New Revision: 936802
>
> URL: http://svn.apache.org/viewvc?rev=936802&view=rev
> Log:
> * subversion/tests/svn_test_main.c
>  (main): Override the default malfunction handler to avoid abort()
>   in the C tests. If SVN_ERR_ASSERT() fails in a C test, we should
>   treat this as XFAIL rather than dumping core.

You're not supposed to use SVN_ERR_ASSERT for test conditions. Those
should continue to validate assumptions scattered throughout our code.

For *testing*, you should be using SVN_TEST_ASSERT() and
SVN_TEST_STRING_ASSERT(), found in tests/svn_test.h.

>...

Cheers,
-g