You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Karl Wright (JIRA)" <ji...@apache.org> on 2017/08/21 11:23:00 UTC
[jira] [Commented] (LUCENE-7936) Extend Geoshape interfaces so
objects can be copied/serialized
[ https://issues.apache.org/jira/browse/LUCENE-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135047#comment-16135047 ]
Karl Wright commented on LUCENE-7936:
-------------------------------------
Hi [~ivera], I'm not happy with exposing internal representational information everywhere.
For copying, I greatly prefer that objects know how to copy themselves. Implementing Cloneable is one standard way to do that, rather than make lots of public accessors. Same goes for serialization -- you can either implement Serializable, which has a lot of problems, or you can use one of the java serialization frameworks.
The issue is that I don't know what standards Lucene uses elsewhere. I will do some asking around and get back to you on that.
> Extend Geoshape interfaces so objects can be copied/serialized
> --------------------------------------------------------------
>
> Key: LUCENE-7936
> URL: https://issues.apache.org/jira/browse/LUCENE-7936
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-7936.patch
>
>
> Hi [~david.wright@bksv.com],
> I would like to propose to extends the GeoShape interfaces to be able to copy/serialized the objects. The current status and propose change is as following:
> GeoPoint: It can be serialized by using x, y, z
> GeoCircle: It can be serialized by using getCenter() and getRadius() and getPlanetModel()
> GeoCompositeShape: It can be serialized by accesing shapes using size() and GetShape(int index)
> GeoPath: add methods to the interface getPoints() and getCutoffAngle()
> GeoPolygon: This is the most complicated one as we have different types:
> 1.- GeoCompositePolygon is just a composite
> 2.- GeoConcavePolygon and GeoConvexPolygon: Create a new interface for those polygons which exposes the points, holes, internaledges and concavity/convexity
> 3.- GeoComplexPolygons: Do nothing, they are too complex to be serialize??
> I am intersested in accesing the discreatization of the polygons into convex and concave ones for other reasons as well. I think this should be expose as they end result can be used for other use cases.
> Cheers,
> I.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org