You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/27 08:23:27 UTC

[GitHub] [hudi] yanghua commented on a change in pull request #1644: [HUDI-811] Restructure test packages in hudi-common

yanghua commented on a change in pull request #1644:
URL: https://github.com/apache/hudi/pull/1644#discussion_r430941743



##########
File path: hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestRocksDBDAO.java
##########
@@ -45,7 +45,7 @@
 /**
  * Tests RocksDB manager {@link RocksDBDAO}.
  */
-public class TestRocksDBManager {
+public class TestRocksDBDAO {

Review comment:
       Sorry for the late reply. Yes, your explanation is reasonable. Actually, I'd like to discuss with you about the opinion of renaming `RocksDBDAO ` to `RocksDBManager `. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org