You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 18:46:15 UTC
Re: Review Request 53961: CMake: Move test-specific variables into
StoutTestsConfigure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53961/#review157077
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 20)
<https://reviews.apache.org/r/53961/#comment227495>
Super nit, and technically not your problem since you're moving this, but: I think this line is over 80 characters?
3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 44)
<https://reviews.apache.org/r/53961/#comment227497>
Not your fault, but I believe this is not true with our current version of gtest. :)
- Alex Clemmer
On Nov. 21, 2016, 10:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53961/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 10:08 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These definitions were originally in:
> `3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake`
>
> By consolidating these definitions in `StoutTestsConfigure`, we can
> reuse the same definitions for libprocess and Mesos tests as well.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/StoutTestsConfigure.cmake 2c786c53008d071a44137aa9507794e9860ed6b6
>
> Diff: https://reviews.apache.org/r/53961/diff/
>
>
> Testing
> -------
>
> See next review.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 53961: CMake: Move test-specific variables into
StoutTestsConfigure.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Nov. 28, 2016, 10:46 a.m., Alex Clemmer wrote:
> > 3rdparty/stout/cmake/StoutTestsConfigure.cmake, line 20
> > <https://reviews.apache.org/r/53961/diff/1/?file=1568203#file1568203line20>
> >
> > Super nit, and technically not your problem since you're moving this, but: I think this line is over 80 characters?
We're not as picky in the build files, but I shall rephrase to squeeze it in :)
> On Nov. 28, 2016, 10:46 a.m., Alex Clemmer wrote:
> > 3rdparty/stout/cmake/StoutTestsConfigure.cmake, line 44
> > <https://reviews.apache.org/r/53961/diff/1/?file=1568203#file1568203line44>
> >
> > Not your fault, but I believe this is not true with our current version of gtest. :)
These flags are still very much required (on OSX and BSD apparently).
The flags were last updated about a year ago: https://github.com/apache/mesos/commit/a8970ce78f1abbee3dd4de282d54ced38d0e5fa1
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53961/#review157077
-----------------------------------------------------------
On Nov. 21, 2016, 2:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53961/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 2:08 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These definitions were originally in:
> `3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake`
>
> By consolidating these definitions in `StoutTestsConfigure`, we can
> reuse the same definitions for libprocess and Mesos tests as well.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/StoutTestsConfigure.cmake 2c786c53008d071a44137aa9507794e9860ed6b6
>
> Diff: https://reviews.apache.org/r/53961/diff/
>
>
> Testing
> -------
>
> See next review.
>
>
> Thanks,
>
> Joseph Wu
>
>