You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:31:09 UTC

[GitHub] [arrow-ballista] Ted-Jiang commented on a diff in pull request #59: [Draft] Support for multi-scheduler deployments

Ted-Jiang commented on code in PR #59:
URL: https://github.com/apache/arrow-ballista/pull/59#discussion_r889893816


##########
ballista/rust/scheduler/src/planner.rs:
##########
@@ -59,15 +58,14 @@ impl DistributedPlanner {
     /// Returns a vector of ExecutionPlans, where the root node is a [ShuffleWriterExec].
     /// Plans that depend on the input of other plans will have leaf nodes of type [UnresolvedShuffleExec].
     /// A [ShuffleWriterExec] is created whenever the partitioning changes.
-    pub async fn plan_query_stages<'a>(
+    pub fn plan_query_stages<'a>(

Review Comment:
   Is there some reason remove the `async `🤔
   I think there are some io work in `plan_query_stages ` like save status in db



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org