[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #325: WIP: i18n consumer

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #325:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/325#discussion_r459157578



##########
File path: src/pages/Consumer/Create.tsx
##########
@@ -51,7 +53,7 @@ const Page: React.FC = (props) => {
         .map((item) => item[0]);
       const isValid = Object.keys(plugins).some((name) => authPluginNames.includes(name));
       if (!isValid) {
-        notification.warning({ message: '请启用至少一种身份认证类插件' });
+        notification.warning({ message: formatMessage({ id: 'consumer.create.enable.authentication.plugin' }) });

Review comment:
       .enableAtLeast1AuthenticationPlugin

##########
File path: src/pages/Consumer/Create.tsx
##########
@@ -32,7 +34,7 @@ const Page: React.FC = (props) => {
     const { id } = (props as any).match.params;
     (id ? update(id, data) : create(data))
       .then(() => {
-        notification.success({ message: `${id ? '更新' : '创建'} Consumer 成功` });
+        notification.success({ message: `${id ? formatMessage({ id: 'consumer.create.edit' }) : formatMessage({ id: 'consumer.create.create' })} Consumer ${formatMessage({ id: 'consumer.create.success' })}` });

Review comment:
       global.update & global.create are ok.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org