You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/30 02:46:43 UTC
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: OAP Core
polish, especially storage level
codecov-io edited a comment on issue #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `21.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.93% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28965 -24
Branches 3952 3963 +11
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20449 -174
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `55.00% <0.00%> (+3.43%)` | :arrow_up: |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...4f0eeb8](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services