You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/21 01:55:58 UTC
[GitHub] [incubator-hudi] zhaomin1423 opened a new pull request #1431:
[HUDI-65]commitTime rename to instantTime
zhaomin1423 opened a new pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431
What is the purpose of the pull request
Cleanup nomenclature around commitTime and instantTime
Brief change log
commtTime rename to instantTime
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1431:
[HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#issuecomment-601980537
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=h1) Report
> Merging [#1431](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/83fb9651f368351446bb6ef0c9ebde34cf61b809&el=desc) will **not change** coverage by `%`.
> The diff coverage is `79.73%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1431 +/- ##
=========================================
Coverage 67.56% 67.56%
Complexity 255 255
=========================================
Files 340 340
Lines 16514 16514
Branches 1689 1689
=========================================
Hits 11158 11158
Misses 4618 4618
Partials 738 738
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/hudi/index/HoodieIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvSG9vZGllSW5kZXguamF2YQ==) | `88.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/hudi/index/InMemoryHashIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvSW5NZW1vcnlIYXNoSW5kZXguamF2YQ==) | `87.87% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/hudi/index/bloom/HoodieBloomIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvYmxvb20vSG9vZGllQmxvb21JbmRleC5qYXZh) | `94.73% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/hudi/index/hbase/HBaseIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvaGJhc2UvSEJhc2VJbmRleC5qYXZh) | `84.21% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `78.09% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/hudi/utilities/HoodieSnapshotCopier.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90Q29waWVyLmphdmE=) | `14.10% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...che/hudi/utilities/sources/HiveIncrPullSource.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSGl2ZUluY3JQdWxsU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/hudi/DataSourceUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9EYXRhU291cmNlVXRpbHMuamF2YQ==) | `50.56% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/scala/org/apache/hudi/HoodieSparkSqlWriter.scala](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllU3BhcmtTcWxXcml0ZXIuc2NhbGE=) | `52.79% <63.63%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `72.27% <63.63%> (ø)` | `38.00 <0.00> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=footer). Last update [83fb965...c8d3141](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1431: [HUDI-65]
commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1431: [HUDI-65] commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1431: [HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962585
##########
File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -129,46 +129,46 @@ public static void writePartitionMetadata(FileSystem fs, String[] partitionPaths
* retaining the key if optionally provided.
*
* @param key Hoodie key.
- * @param commitTime Commit time to use.
+ * @param instantTime Commit time to use.
Review comment:
instant time to use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] zhaomin1423 commented on issue #1431:
[HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on issue #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#issuecomment-601999146
I have modified all the above mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1431: [HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962069
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SavepointsCommand.java
##########
@@ -63,36 +63,36 @@ public String showSavepoints() throws IOException {
}
@CliCommand(value = "savepoint create", help = "Savepoint a commit")
- public String savepoint(@CliOption(key = {"commit"}, help = "Commit to savepoint") final String commitTime,
+ public String savepoint(@CliOption(key = {"commit"}, help = "Commit to savepoint") final String instantTime,
Review comment:
this is specifically doing a savepoint for a commit.. so `commitTime` is actually apt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1431: [HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962757
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java
##########
@@ -160,15 +160,15 @@ private boolean isFileSliceCommitted(FileSlice slice) {
}
/**
- * Obtain the latest file slice, upto a commitTime i.e <= maxCommitTime.
+ * Obtain the latest file slice, upto a instantTime i.e <= maxInstantTime.
Review comment:
an instant time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1431:
[HUDI-65] commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1431: [HUDI-65] commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#issuecomment-601980537
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=h1) Report
> Merging [#1431](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/83fb9651f368351446bb6ef0c9ebde34cf61b809&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `79.73%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1431 +/- ##
============================================
+ Coverage 67.56% 67.60% +0.04%
Complexity 255 255
============================================
Files 340 340
Lines 16514 16514
Branches 1689 1689
============================================
+ Hits 11158 11165 +7
+ Misses 4618 4611 -7
Partials 738 738
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/hudi/index/HoodieIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvSG9vZGllSW5kZXguamF2YQ==) | `88.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/hudi/index/InMemoryHashIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvSW5NZW1vcnlIYXNoSW5kZXguamF2YQ==) | `87.87% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/hudi/index/bloom/HoodieBloomIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvYmxvb20vSG9vZGllQmxvb21JbmRleC5qYXZh) | `94.73% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/hudi/index/hbase/HBaseIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvaGJhc2UvSEJhc2VJbmRleC5qYXZh) | `84.21% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `78.09% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/hudi/utilities/HoodieSnapshotCopier.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90Q29waWVyLmphdmE=) | `14.10% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...che/hudi/utilities/sources/HiveIncrPullSource.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSGl2ZUluY3JQdWxsU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/hudi/DataSourceUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9EYXRhU291cmNlVXRpbHMuamF2YQ==) | `50.56% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/scala/org/apache/hudi/HoodieSparkSqlWriter.scala](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllU3BhcmtTcWxXcml0ZXIuc2NhbGE=) | `52.79% <63.63%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `72.27% <63.63%> (ø)` | `38.00 <0.00> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=footer). Last update [83fb965...69cf894](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1431:
[HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#issuecomment-601980537
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=h1) Report
> Merging [#1431](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/83fb9651f368351446bb6ef0c9ebde34cf61b809&el=desc) will **not change** coverage by `%`.
> The diff coverage is `79.73%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1431 +/- ##
=========================================
Coverage 67.56% 67.56%
Complexity 255 255
=========================================
Files 340 340
Lines 16514 16514
Branches 1689 1689
=========================================
Hits 11158 11158
Misses 4618 4618
Partials 738 738
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/hudi/index/HoodieIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvSG9vZGllSW5kZXguamF2YQ==) | `88.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/hudi/index/InMemoryHashIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvSW5NZW1vcnlIYXNoSW5kZXguamF2YQ==) | `87.87% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/hudi/index/bloom/HoodieBloomIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvYmxvb20vSG9vZGllQmxvb21JbmRleC5qYXZh) | `94.73% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/hudi/index/hbase/HBaseIndex.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvaGJhc2UvSEJhc2VJbmRleC5qYXZh) | `84.21% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `78.09% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/hudi/utilities/HoodieSnapshotCopier.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0hvb2RpZVNuYXBzaG90Q29waWVyLmphdmE=) | `14.10% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...che/hudi/utilities/sources/HiveIncrPullSource.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSGl2ZUluY3JQdWxsU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/hudi/DataSourceUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9EYXRhU291cmNlVXRpbHMuamF2YQ==) | `50.56% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/scala/org/apache/hudi/HoodieSparkSqlWriter.scala](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllU3BhcmtTcWxXcml0ZXIuc2NhbGE=) | `52.79% <63.63%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `72.27% <63.63%> (ø)` | `38.00 <0.00> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/incubator-hudi/pull/1431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=footer). Last update [83fb965...c8d3141](https://codecov.io/gh/apache/incubator-hudi/pull/1431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1431: [HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962699
##########
File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -426,12 +426,12 @@ public HoodieRecord generateUpdateRecord(HoodieKey key, String commitTime) throw
/**
* Generates deduped updates of keys previously inserted, randomly distributed across the keys above.
*
- * @param commitTime Commit Timestamp
+ * @param instantTime Commit Timestamp
Review comment:
here too.. can you make a second pass everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] zhaomin1423 commented on a change in pull request
#1431: [HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395964258
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SavepointsCommand.java
##########
@@ -63,36 +63,36 @@ public String showSavepoints() throws IOException {
}
@CliCommand(value = "savepoint create", help = "Savepoint a commit")
- public String savepoint(@CliOption(key = {"commit"}, help = "Commit to savepoint") final String commitTime,
+ public String savepoint(@CliOption(key = {"commit"}, help = "Commit to savepoint") final String instantTime,
Review comment:
Thanks, I will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1431: [HUDI-65]commitTime rename to instantTime
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962682
##########
File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -409,15 +409,15 @@ public HoodieRecord generateUpdateRecord(HoodieKey key, String commitTime) throw
* Generates new updates, randomly distributed across the keys above. There can be duplicates within the returned
* list
*
- * @param commitTime Commit Timestamp
+ * @param instantTime Commit Timestamp
Review comment:
fix param doc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services