[jira] Commented: (MYFACES-2374) UIViewRoot.getBeforePhaseListener() and UIViewRoot.getAfterPhaseListener() could be called on PhaseId.RESTORE_VIEW

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773623#action_12773623 ] 

Leonardo Uribe commented on MYFACES-2374:
-----------------------------------------

The latest patch is incomplete by two reasons:

1. When partial state saving is used, UIViewRoot.processRestoreState is not called. Look how PostRestoreStateEvent is triggered.
2. The patch remove valid code calling PhaseListeners. Look how UIViewRoot.notifyListeners is called.

> UIViewRoot.getBeforePhaseListener() and UIViewRoot.getAfterPhaseListener() could be called on PhaseId.RESTORE_VIEW
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2374
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2374
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>         Attachments: restore_view_phaselistener.patch, restore_view_phaselistener_newest.patch
>
>
> Note that on jsf 1.2 this is not true. The problem with this one is how call UIViewRoot beforePhaseListener before PhaseId.RESTORE_VIEW, because in theory we need to "restore it" before call it. Maybe the solution is call it from the place where the state is restored (JspStateManagerImpl).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.