You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by jb...@apache.org on 2018/09/12 20:39:05 UTC
[geode-native] branch develop updated: GEODE-5730: Fixes
google-explicit-constructor clang-tidy warning (#350)
This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new 1c2646d GEODE-5730: Fixes google-explicit-constructor clang-tidy warning (#350)
1c2646d is described below
commit 1c2646db07a4e4b7c990c212f51b493d00fc585d
Author: Jacob Barrett <jb...@pivotal.io>
AuthorDate: Wed Sep 12 13:39:02 2018 -0700
GEODE-5730: Fixes google-explicit-constructor clang-tidy warning (#350)
---
.clang-format | 26 +++-----------
.clang-tidy | 4 +--
cppcache/include/geode/AttributesMutator.hpp | 2 +-
cppcache/include/geode/CacheableBuiltins.hpp | 12 +++----
cppcache/include/geode/CacheableDate.hpp | 12 +++----
cppcache/include/geode/CacheableFileName.hpp | 5 +--
cppcache/include/geode/CacheableObjectArray.hpp | 2 +-
cppcache/include/geode/CacheableString.hpp | 6 ++--
cppcache/include/geode/CqAttributesFactory.hpp | 3 +-
cppcache/include/geode/CqAttributesMutator.hpp | 2 +-
cppcache/include/geode/Exception.hpp | 4 +--
cppcache/include/geode/Execution.hpp | 2 +-
cppcache/include/geode/ExpirationAttributes.hpp | 2 +-
cppcache/include/geode/PersistenceManager.hpp | 2 +-
cppcache/include/geode/Pool.hpp | 2 +-
cppcache/include/geode/PoolFactory.hpp | 2 +-
cppcache/include/geode/PoolManager.hpp | 2 +-
cppcache/include/geode/Region.hpp | 2 +-
cppcache/include/geode/RegionAttributesFactory.hpp | 2 +-
cppcache/include/geode/SystemProperties.hpp | 4 +--
cppcache/include/geode/TypeRegistry.hpp | 2 +-
.../EnableChunkHandlerThreadTest.cpp | 2 +-
cppcache/integration-test-2/framework/Gfsh.h | 22 ++++++------
.../integration-test-2/framework/GfshExecute.h | 2 +-
cppcache/integration-test/CacheHelper.hpp | 20 +++++------
cppcache/integration-test/CacheImplHelper.hpp | 8 +++--
cppcache/integration-test/CacheableWrapper.hpp | 2 +-
cppcache/integration-test/DeltaEx.hpp | 5 +--
.../integration-test/ThinClientDurableInterest.hpp | 2 +-
cppcache/integration-test/ThinClientHelper.hpp | 2 +-
.../integration-test/ThinClientPdxSerializer.hpp | 2 +-
.../integration-test/ThinClientSecurityHelper.hpp | 3 +-
cppcache/integration-test/TimeBomb.hpp | 2 +-
cppcache/integration-test/fw_helper.hpp | 2 +-
cppcache/integration-test/fw_perf.hpp | 6 ++--
cppcache/integration-test/fw_spawn.hpp | 2 +-
cppcache/src/AutoDelete.hpp | 4 +--
cppcache/src/BucketServerLocation.hpp | 2 +-
cppcache/src/CacheConfig.hpp | 2 +-
cppcache/src/CachePerfStats.hpp | 2 +-
cppcache/src/CacheTransactionManagerImpl.hpp | 2 +-
cppcache/src/CacheXmlParser.hpp | 2 +-
cppcache/src/CacheableObjectPartList.hpp | 2 +-
cppcache/src/CacheableToken.hpp | 2 +-
cppcache/src/ClientConnectionRequest.hpp | 5 +--
cppcache/src/ClientMetadataService.hpp | 6 ++--
cppcache/src/ClientProxyMembershipIDFactory.hpp | 2 +-
cppcache/src/Condition.hpp | 2 +-
cppcache/src/CqServiceVsdStats.hpp | 4 +--
cppcache/src/DataOutputInternal.hpp | 2 +-
cppcache/src/DiskVersionTag.hpp | 2 +-
cppcache/src/EntriesMap.hpp | 3 +-
cppcache/src/EventId.hpp | 9 ++---
cppcache/src/EventIdMap.hpp | 2 +-
cppcache/src/EvictionThread.hpp | 2 +-
cppcache/src/ExecutionImpl.hpp | 10 +++---
cppcache/src/FarSideEntryOp.hpp | 2 +-
cppcache/src/FunctionServiceImpl.hpp | 4 +--
cppcache/src/GetAllServersRequest.hpp | 3 +-
.../src/InternalCacheTransactionManager2PCImpl.hpp | 2 +-
cppcache/src/LRUAction.hpp | 6 ++--
cppcache/src/LRUList.hpp | 4 +--
cppcache/src/LRUMapEntry.hpp | 5 +--
cppcache/src/LocatorListRequest.hpp | 2 +-
cppcache/src/MapEntry.hpp | 16 ++++-----
cppcache/src/MapEntryT.hpp | 3 +-
cppcache/src/MemberListForVersionStamp.hpp | 2 +-
cppcache/src/PdxLocalReader.hpp | 2 +-
cppcache/src/PdxTypeRegistry.hpp | 2 +-
cppcache/src/ProxyRemoteQueryService.hpp | 2 +-
.../src/PutAllPartialResultServerException.hpp | 6 ++--
cppcache/src/Queue.hpp | 2 +-
cppcache/src/ReadWriteLock.hpp | 8 +++--
cppcache/src/RegionCommit.hpp | 2 +-
cppcache/src/RegionConfig.hpp | 2 +-
cppcache/src/RegionGlobalLocks.hpp | 2 +-
cppcache/src/RegionInternal.hpp | 2 +-
cppcache/src/RegionXmlCreation.hpp | 2 +-
cppcache/src/RemoteQueryService.hpp | 3 +-
cppcache/src/ResultSetImpl.hpp | 2 +-
cppcache/src/ServerLocation.hpp | 2 +-
cppcache/src/Set.hpp | 2 +-
cppcache/src/StackTrace.hpp | 2 +-
cppcache/src/TXCleaner.hpp | 2 +-
cppcache/src/TXCommitMessage.hpp | 3 +-
cppcache/src/TXState.hpp | 4 +--
cppcache/src/TcrConnectionManager.hpp | 4 +--
cppcache/src/TcrMessage.hpp | 8 ++---
.../src/ThinClientCacheDistributionManager.hpp | 3 +-
cppcache/src/ThinClientRedundancyManager.hpp | 10 +++---
cppcache/src/ThinClientRegion.hpp | 4 +--
cppcache/src/ThinClientStickyManager.hpp | 2 +-
cppcache/src/ThreadPool.hpp | 4 +--
cppcache/src/UserAttributes.hpp | 2 +-
cppcache/src/VersionTag.hpp | 2 +-
cppcache/src/statistics/GeodeStatisticsFactory.hpp | 2 +-
cppcache/src/statistics/StatArchiveWriter.hpp | 2 +-
cppcache/src/statistics/StatSamplerStats.hpp | 2 +-
cppcache/src/util/Log.hpp | 2 +-
cppcache/test/ByteArray.hpp | 6 ++--
cppcache/test/DataOutputTest.cpp | 2 +-
tests/cpp/fwk/UdpIpc.hpp | 4 +--
tests/cpp/fwklib/ClientTask.hpp | 2 +-
tests/cpp/fwklib/FrameworkTest.hpp | 2 +-
tests/cpp/fwklib/FwkBB.hpp | 2 +-
tests/cpp/fwklib/FwkBBClient.hpp | 3 +-
tests/cpp/fwklib/FwkException.hpp | 6 ++--
tests/cpp/fwklib/FwkObjects.hpp | 42 +++++++++++-----------
tests/cpp/fwklib/FwkStrCvt.hpp | 20 ++++++-----
tests/cpp/fwklib/IpcHandler.hpp | 4 +--
tests/cpp/fwklib/PaceMeter.hpp | 2 +-
tests/cpp/fwklib/PerfFwk.hpp | 3 +-
tests/cpp/fwklib/RegionHelper.hpp | 2 +-
tests/cpp/fwklib/Service.hpp | 7 ++--
tests/cpp/fwklib/TcpIpc.hpp | 7 ++--
tests/cpp/fwklib/TestClient.hpp | 2 +-
tests/cpp/fwklib/TimeSync.hpp | 3 +-
tests/cpp/fwklib/UDPIpc.hpp | 10 +++---
tests/cpp/security/PkcsAuthInit.hpp | 2 +-
tests/cpp/security/Security.hpp | 2 +-
tests/cpp/security/XmlAuthzCredentialGenerator.hpp | 2 +-
tests/cpp/testobject/EqStruct.hpp | 2 +-
tests/cpp/testobject/NestedPdxObject.hpp | 8 ++---
tests/cpp/testobject/PdxClassV1.hpp | 6 ++--
tests/cpp/testobject/PdxClassV2.hpp | 6 ++--
tests/cpp/testobject/PdxVersioned1.hpp | 2 +-
tests/cpp/testobject/PdxVersioned2.hpp | 2 +-
tests/cpp/testobject/Portfolio.hpp | 4 +--
tests/cpp/testobject/PortfolioPdx.hpp | 3 +-
tests/cpp/testobject/Position.hpp | 2 +-
tests/cpp/testobject/PositionPdx.hpp | 2 +-
tests/cpp/testobject/TestObject1.hpp | 2 +-
tests/cpp/testobject/VariousPdxTypes.hpp | 4 +--
133 files changed, 297 insertions(+), 278 deletions(-)
diff --git a/.clang-format b/.clang-format
index 7b7698d..8057f96 100644
--- a/.clang-format
+++ b/.clang-format
@@ -77,20 +77,10 @@ IndentWrappedFunctionNames: false
JavaScriptQuotes: Leave
JavaScriptWrapImports: true
KeepEmptyLinesAtTheStartOfBlocks: false
-MacroBlockBegin: "^\
-BEGIN_TEST|\
-DUNIT_TASK|\
-DUNIT_TASK_DEFINITION|\
-DUNIT_MAIN$"
-MacroBlockEnd: "^\
-END_TEST|\
-ENDTASK|\
-END_TASK|\
-END_TASK_DEFINITION|\
-END_MAIN$"
+MacroBlockBegin: '^BEGIN_TEST|DUNIT_TASK|DUNIT_TASK_DEFINITION|DUNIT_MAIN$'
+MacroBlockEnd: '^END_TEST|ENDTASK|END_TASK|END_TASK_DEFINITION|END_MAIN$'
MaxEmptyLinesToKeep: 1
NamespaceIndentation: None
-ObjCBinPackProtocolList: Never
ObjCBlockIndentWidth: 2
ObjCSpaceAfterProperty: false
ObjCSpaceBeforeProtocolList: true
@@ -103,13 +93,8 @@ PenaltyExcessCharacter: 1000000
PenaltyReturnTypeOnItsOwnLine: 200
PointerAlignment: Left
RawStringFormats:
- - Language: TextProto
- Delimiters:
- - pb
- - PB
- - proto
- - PROTO
- CanonicalDelimiter: ''
+ - Delimiter: pb
+ Language: TextProto
BasedOnStyle: google
ReflowComments: true
#SortIncludes: true
@@ -118,10 +103,7 @@ SortUsingDeclarations: true
SpaceAfterCStyleCast: false
SpaceAfterTemplateKeyword: true
SpaceBeforeAssignmentOperators: true
-SpaceBeforeCtorInitializerColon: true
-SpaceBeforeInheritanceColon: true
SpaceBeforeParens: ControlStatements
-SpaceBeforeRangeBasedForLoopColon: true
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 2
SpacesInAngles: false
diff --git a/.clang-tidy b/.clang-tidy
index 916b0a1..61eb050 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,7 +1,7 @@
---
Checks: '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references'
-WarningsAsErrors: 'google-build-using-namespace,google-readability-redundant-smartptr-get'
-HeaderFilterRegex: '\.(h|hpp)$'
+WarningsAsErrors: 'google-build-using-namespace,google-readability-redundant-smartptr-get,google-explicit-constructor'
+HeaderFilterRegex: '.*'
AnalyzeTemporaryDtors: false
FormatStyle: file
CheckOptions:
diff --git a/cppcache/include/geode/AttributesMutator.hpp b/cppcache/include/geode/AttributesMutator.hpp
index d034769..98ac189 100644
--- a/cppcache/include/geode/AttributesMutator.hpp
+++ b/cppcache/include/geode/AttributesMutator.hpp
@@ -65,7 +65,7 @@ class APACHE_GEODE_EXPORT AttributesMutator {
public:
/** Internal constructor. Use Region::getAttributesMutator() to acquire the
* mutator for a region. */
- AttributesMutator(const std::shared_ptr<Region>& region);
+ explicit AttributesMutator(const std::shared_ptr<Region>& region);
virtual ~AttributesMutator();
diff --git a/cppcache/include/geode/CacheableBuiltins.hpp b/cppcache/include/geode/CacheableBuiltins.hpp
index 495e2d9..48f0ab0 100644
--- a/cppcache/include/geode/CacheableBuiltins.hpp
+++ b/cppcache/include/geode/CacheableBuiltins.hpp
@@ -49,7 +49,7 @@ class APACHE_GEODE_EXPORT CacheableKeyType : public DataSerializablePrimitive,
inline CacheableKeyType()
: m_value(apache::geode::client::serializer::zeroObject<TObj>()) {}
- inline CacheableKeyType(const TObj value) : m_value(value) {}
+ inline explicit CacheableKeyType(const TObj value) : m_value(value) {}
public:
/** Gets the contained value. */
@@ -134,8 +134,7 @@ class APACHE_GEODE_EXPORT CacheableContainerType
public TBase {
protected:
inline CacheableContainerType() : TBase() {}
-
- inline CacheableContainerType(const int32_t n) : TBase(n) {}
+ inline explicit CacheableContainerType(const int32_t n) : TBase(n) {}
public:
// Cacheable methods
@@ -170,7 +169,7 @@ class APACHE_GEODE_EXPORT CacheableContainerType
class APACHE_GEODE_EXPORT k : public _##k { \
public: \
inline k() : _##k() {} \
- inline k(const p value) : _##k(value) {} \
+ inline explicit k(const p value) : _##k(value) {} \
\
/** Factory function registered with serialization registry. */ \
static std::shared_ptr<Serializable> createDeserializable() { \
@@ -203,7 +202,7 @@ class APACHE_GEODE_EXPORT CacheableContainerType
class APACHE_GEODE_EXPORT c : public _##c { \
public: \
inline c() : _##c() {} \
- inline c(const int32_t n) : _##c(n) {} \
+ inline explicit c(const int32_t n) : _##c(n) {} \
\
/** Factory function registered with serialization registry. */ \
static std::shared_ptr<Serializable> createDeserializable() { \
@@ -296,7 +295,8 @@ class APACHE_GEODE_EXPORT CacheableArray : public DataSerializablePrimitive {
inline CacheableArray() = default;
template <typename TT>
- CacheableArray(TT&& value) : m_value(std::forward<TT>(value)) {}
+ inline explicit CacheableArray(TT&& value)
+ : m_value(std::forward<TT>(value)) {}
~CacheableArray() noexcept override = default;
diff --git a/cppcache/include/geode/CacheableDate.hpp b/cppcache/include/geode/CacheableDate.hpp
index 4c14de7..4b3f30b 100644
--- a/cppcache/include/geode/CacheableDate.hpp
+++ b/cppcache/include/geode/CacheableDate.hpp
@@ -56,17 +56,17 @@ class APACHE_GEODE_EXPORT CacheableDate
typedef std::chrono::milliseconds duration;
/** Constructor, used for deserialization. */
- CacheableDate(const time_t value = 0);
+ explicit CacheableDate(const time_t value = 0);
/**
* Construct from std::chrono::time_point<std::chrono::system_clock>.
*/
- CacheableDate(const time_point& value);
+ explicit CacheableDate(const time_point& value);
/**
* Construct from std::chrono::seconds since POSIX epoch.
*/
- CacheableDate(const duration& value);
+ explicit CacheableDate(const duration& value);
~CacheableDate() noexcept override = default;
@@ -101,11 +101,11 @@ class APACHE_GEODE_EXPORT CacheableDate
* @return the hashcode for this object. */
virtual int32_t hashcode() const override;
- operator time_t() const { return m_timevalue / 1000; }
- operator time_point() const {
+ explicit operator time_t() const { return m_timevalue / 1000; }
+ explicit operator time_point() const {
return clock::from_time_t(0) + duration(m_timevalue);
}
- operator duration() const { return duration(m_timevalue); }
+ explicit operator duration() const { return duration(m_timevalue); }
/**
* Factory method for creating an instance of CacheableDate
diff --git a/cppcache/include/geode/CacheableFileName.hpp b/cppcache/include/geode/CacheableFileName.hpp
index 0b974f6..aafa8c6 100644
--- a/cppcache/include/geode/CacheableFileName.hpp
+++ b/cppcache/include/geode/CacheableFileName.hpp
@@ -46,8 +46,9 @@ class Serializable;
class APACHE_GEODE_EXPORT CacheableFileName : public CacheableString {
public:
inline CacheableFileName() = default;
- inline CacheableFileName(const std::string& value) : CacheableString(value) {}
- inline CacheableFileName(std::string&& value)
+ inline explicit CacheableFileName(const std::string& value)
+ : CacheableString(value) {}
+ inline explicit CacheableFileName(std::string&& value)
: CacheableString(std::move(value)) {}
~CacheableFileName() noexcept override = default;
void operator=(const CacheableFileName& other) = delete;
diff --git a/cppcache/include/geode/CacheableObjectArray.hpp b/cppcache/include/geode/CacheableObjectArray.hpp
index 7656712..1c5a645 100644
--- a/cppcache/include/geode/CacheableObjectArray.hpp
+++ b/cppcache/include/geode/CacheableObjectArray.hpp
@@ -51,7 +51,7 @@ class APACHE_GEODE_EXPORT CacheableObjectArray
inline CacheableObjectArray() : std::vector<std::shared_ptr<Cacheable>>() {}
/** Create a vector with n elements allocated. */
- inline CacheableObjectArray(int32_t n)
+ inline explicit CacheableObjectArray(int32_t n)
: std::vector<std::shared_ptr<Cacheable>>(n) {}
~CacheableObjectArray() noexcept override = default;
diff --git a/cppcache/include/geode/CacheableString.hpp b/cppcache/include/geode/CacheableString.hpp
index 5d9395f..a7a5980 100644
--- a/cppcache/include/geode/CacheableString.hpp
+++ b/cppcache/include/geode/CacheableString.hpp
@@ -47,13 +47,13 @@ class APACHE_GEODE_EXPORT CacheableString
mutable int m_hashcode;
public:
- inline CacheableString(DSCode type = DSCode::CacheableASCIIString)
+ inline explicit CacheableString(DSCode type = DSCode::CacheableASCIIString)
: m_str(), m_type(type), m_hashcode(0) {}
- inline CacheableString(const std::string& value)
+ inline explicit CacheableString(const std::string& value)
: CacheableString(std::string(value)) {}
- inline CacheableString(std::string&& value)
+ inline explicit CacheableString(std::string&& value)
: m_str(std::move(value)), m_hashcode(0) {
bool ascii = isAscii(m_str);
diff --git a/cppcache/include/geode/CqAttributesFactory.hpp b/cppcache/include/geode/CqAttributesFactory.hpp
index 5d712c6..bc90c06 100644
--- a/cppcache/include/geode/CqAttributesFactory.hpp
+++ b/cppcache/include/geode/CqAttributesFactory.hpp
@@ -74,7 +74,8 @@ class APACHE_GEODE_EXPORT CqAttributesFactory {
* the <code>CqAttributes</code> used to initialize this
* AttributesFactory
*/
- CqAttributesFactory(const std::shared_ptr<CqAttributes>& cqAttributes);
+ explicit CqAttributesFactory(
+ const std::shared_ptr<CqAttributes>& cqAttributes);
/**
* Adds a CQ listener to the end of the list of cq listeners on this factory.
diff --git a/cppcache/include/geode/CqAttributesMutator.hpp b/cppcache/include/geode/CqAttributesMutator.hpp
index ea9c57d..4e17048 100644
--- a/cppcache/include/geode/CqAttributesMutator.hpp
+++ b/cppcache/include/geode/CqAttributesMutator.hpp
@@ -45,7 +45,7 @@ class APACHE_GEODE_EXPORT CqAttributesMutator {
/** Constructs a <code>CqAttributesMutator</code> with the given {@link
* CqAttributes}.
*/
- CqAttributesMutator(const std::shared_ptr<CqAttributes>& impl);
+ explicit CqAttributesMutator(const std::shared_ptr<CqAttributes>& impl);
/**
* Adds a CQ listener to the end of the list of CQ listeners on this CqQuery.
diff --git a/cppcache/include/geode/Exception.hpp b/cppcache/include/geode/Exception.hpp
index cdd8c39..7345484 100644
--- a/cppcache/include/geode/Exception.hpp
+++ b/cppcache/include/geode/Exception.hpp
@@ -43,8 +43,8 @@ class StackTrace;
class APACHE_GEODE_EXPORT Exception : public std::exception {
public:
explicit Exception(const std::string& message);
- Exception(std::string&& message);
- Exception(const char* message);
+ explicit Exception(std::string&& message);
+ explicit Exception(const char* message);
Exception(const Exception&) = default;
Exception& operator=(const Exception&) = default;
Exception(Exception&&) noexcept = default;
diff --git a/cppcache/include/geode/Execution.hpp b/cppcache/include/geode/Execution.hpp
index 8e16d6d..f250dcd 100644
--- a/cppcache/include/geode/Execution.hpp
+++ b/cppcache/include/geode/Execution.hpp
@@ -119,7 +119,7 @@ class APACHE_GEODE_EXPORT Execution {
private:
std::unique_ptr<ExecutionImpl> impl_;
- Execution(std::unique_ptr<ExecutionImpl> impl);
+ explicit Execution(std::unique_ptr<ExecutionImpl> impl);
friend ExecutionImpl;
friend FunctionService;
diff --git a/cppcache/include/geode/ExpirationAttributes.hpp b/cppcache/include/geode/ExpirationAttributes.hpp
index b919c9f..5044a5c 100644
--- a/cppcache/include/geode/ExpirationAttributes.hpp
+++ b/cppcache/include/geode/ExpirationAttributes.hpp
@@ -69,7 +69,7 @@ class APACHE_GEODE_EXPORT ExpirationAttributes {
* @param expirationAction the action to take when the value expires
* @throws IllegalArgumentException if expirationTime is nonpositive
*/
- ExpirationAttributes(
+ explicit ExpirationAttributes(
const std::chrono::seconds& expirationTime,
const ExpirationAction expirationAction = ExpirationAction::INVALIDATE);
diff --git a/cppcache/include/geode/PersistenceManager.hpp b/cppcache/include/geode/PersistenceManager.hpp
index fb2e4f6..86dc911 100644
--- a/cppcache/include/geode/PersistenceManager.hpp
+++ b/cppcache/include/geode/PersistenceManager.hpp
@@ -126,7 +126,7 @@ class APACHE_GEODE_EXPORT PersistenceManager {
*/
virtual void close() = 0;
- PersistenceManager(const std::shared_ptr<Region>& regionPtr)
+ explicit PersistenceManager(const std::shared_ptr<Region>& regionPtr)
: m_regionPtr(regionPtr) {}
PersistenceManager() = default;
diff --git a/cppcache/include/geode/Pool.hpp b/cppcache/include/geode/Pool.hpp
index 8befcfa..5d345b0 100644
--- a/cppcache/include/geode/Pool.hpp
+++ b/cppcache/include/geode/Pool.hpp
@@ -284,7 +284,7 @@ class APACHE_GEODE_EXPORT Pool : public std::enable_shared_from_this<Pool> {
int getPendingEventCount() const;
protected:
- Pool(std::shared_ptr<PoolAttributes> attr);
+ explicit Pool(std::shared_ptr<PoolAttributes> attr);
std::shared_ptr<PoolAttributes> m_attrs;
private:
diff --git a/cppcache/include/geode/PoolFactory.hpp b/cppcache/include/geode/PoolFactory.hpp
index 33489ca..ffe7cca 100644
--- a/cppcache/include/geode/PoolFactory.hpp
+++ b/cppcache/include/geode/PoolFactory.hpp
@@ -536,7 +536,7 @@ class APACHE_GEODE_EXPORT PoolFactory {
PoolFactory(const PoolFactory&) = default;
private:
- PoolFactory(const Cache& cache);
+ explicit PoolFactory(const Cache& cache);
PoolFactory& addCheck(const std::string& host, int port);
std::shared_ptr<PoolAttributes> m_attrs;
bool m_isSubscriptionRedundancy;
diff --git a/cppcache/include/geode/PoolManager.hpp b/cppcache/include/geode/PoolManager.hpp
index 18a4e88..fe57e04 100644
--- a/cppcache/include/geode/PoolManager.hpp
+++ b/cppcache/include/geode/PoolManager.hpp
@@ -116,7 +116,7 @@ class APACHE_GEODE_EXPORT PoolManager {
std::shared_ptr<PoolManagerImpl> m_pimpl;
- PoolManager(CacheImpl* cache);
+ explicit PoolManager(CacheImpl* cache);
friend Cache;
friend CacheImpl;
diff --git a/cppcache/include/geode/Region.hpp b/cppcache/include/geode/Region.hpp
index 8b5a254..d7d1493 100644
--- a/cppcache/include/geode/Region.hpp
+++ b/cppcache/include/geode/Region.hpp
@@ -1478,7 +1478,7 @@ class APACHE_GEODE_EXPORT Region : public std::enable_shared_from_this<Region> {
Region& operator=(const Region&) = delete;
protected:
- Region(CacheImpl* cacheImpl);
+ explicit Region(CacheImpl* cacheImpl);
virtual ~Region();
CacheImpl* m_cacheImpl;
diff --git a/cppcache/include/geode/RegionAttributesFactory.hpp b/cppcache/include/geode/RegionAttributesFactory.hpp
index 42f294a..357133c 100644
--- a/cppcache/include/geode/RegionAttributesFactory.hpp
+++ b/cppcache/include/geode/RegionAttributesFactory.hpp
@@ -175,7 +175,7 @@ class APACHE_GEODE_EXPORT RegionAttributesFactory {
* @param regionAttributes the <code>RegionAttributes</code> used to
* initialize this RegionAttributesFactory
*/
- RegionAttributesFactory(const RegionAttributes regionAttributes);
+ explicit RegionAttributesFactory(const RegionAttributes regionAttributes);
RegionAttributesFactory(const RegionAttributesFactory&) = default;
diff --git a/cppcache/include/geode/SystemProperties.hpp b/cppcache/include/geode/SystemProperties.hpp
index 4cb4e44..ed18c4e 100644
--- a/cppcache/include/geode/SystemProperties.hpp
+++ b/cppcache/include/geode/SystemProperties.hpp
@@ -51,8 +51,8 @@ class APACHE_GEODE_EXPORT SystemProperties {
* If useMemType is true, use the given member type; if false, always set
* member type to SERVER.
*/
- SystemProperties(const std::shared_ptr<Properties>& propertiesPtr,
- const std::string& configFile = "");
+ explicit SystemProperties(const std::shared_ptr<Properties>& propertiesPtr,
+ const std::string& configFile = "");
SystemProperties(const SystemProperties& rhs) = delete;
void operator=(const SystemProperties& rhs) = delete;
diff --git a/cppcache/include/geode/TypeRegistry.hpp b/cppcache/include/geode/TypeRegistry.hpp
index c7da804..30817e5 100644
--- a/cppcache/include/geode/TypeRegistry.hpp
+++ b/cppcache/include/geode/TypeRegistry.hpp
@@ -34,7 +34,7 @@ class PdxSerializer;
class APACHE_GEODE_EXPORT TypeRegistry {
public:
- TypeRegistry(CacheImpl* cache);
+ explicit TypeRegistry(CacheImpl* cache);
/**
* @brief register an instance factory method for a given type.
diff --git a/cppcache/integration-test-2/EnableChunkHandlerThreadTest.cpp b/cppcache/integration-test-2/EnableChunkHandlerThreadTest.cpp
index 3f16fd0..3d6cefd 100644
--- a/cppcache/integration-test-2/EnableChunkHandlerThreadTest.cpp
+++ b/cppcache/integration-test-2/EnableChunkHandlerThreadTest.cpp
@@ -40,7 +40,7 @@ class SerializableWithThreadId : public PdxSerializable {
public:
SerializableWithThreadId() : SerializableWithThreadId(0) {}
- SerializableWithThreadId(uint32_t id) : id_(id) {}
+ explicit SerializableWithThreadId(uint32_t id) : id_(id) {}
~SerializableWithThreadId() noexcept override = default;
diff --git a/cppcache/integration-test-2/framework/Gfsh.h b/cppcache/integration-test-2/framework/Gfsh.h
index a5bec28..3198f90 100644
--- a/cppcache/integration-test-2/framework/Gfsh.h
+++ b/cppcache/integration-test-2/framework/Gfsh.h
@@ -48,7 +48,7 @@ class Gfsh {
class Verb {
public:
protected:
- Verb(Gfsh &gfsh) : gfsh_(gfsh) {}
+ explicit Verb(Gfsh &gfsh) : gfsh_(gfsh) {}
Gfsh &gfsh_;
};
@@ -66,7 +66,7 @@ class Gfsh {
class Start {
public:
- Start(Gfsh &gfsh) : gfsh_(gfsh) {}
+ explicit Start(Gfsh &gfsh) : gfsh_(gfsh) {}
class Server;
Server server() { return Server{gfsh_}; };
@@ -76,7 +76,7 @@ class Gfsh {
class Locator : public Command<void> {
public:
- Locator(Gfsh &gfsh) : Command(gfsh, "start locator") {}
+ explicit Locator(Gfsh &gfsh) : Command(gfsh, "start locator") {}
Locator &withName(const std::string &name) {
command_ += " --name=" + name;
@@ -122,7 +122,7 @@ class Gfsh {
class Server : public Command<void> {
public:
- Server(Gfsh &gfsh) : Command(gfsh, "start server") {}
+ explicit Server(Gfsh &gfsh) : Command(gfsh, "start server") {}
Server &withName(const std::string &name) {
command_ += " --name=" + name;
@@ -166,7 +166,7 @@ class Gfsh {
class Stop {
public:
- Stop(Gfsh &gfsh) : gfsh_(gfsh) {}
+ explicit Stop(Gfsh &gfsh) : gfsh_(gfsh) {}
class Server;
Server server() { return Server{gfsh_}; };
@@ -176,7 +176,7 @@ class Gfsh {
class Locator : public Command<void> {
public:
- Locator(Gfsh &gfsh) : Command(gfsh, "stop locator") {}
+ explicit Locator(Gfsh &gfsh) : Command(gfsh, "stop locator") {}
Locator &withName(const std::string &name) {
command_ += " --name=" + name;
@@ -191,7 +191,7 @@ class Gfsh {
class Server : public Command<void> {
public:
- Server(Gfsh &gfsh) : Command(gfsh, "stop server") {}
+ explicit Server(Gfsh &gfsh) : Command(gfsh, "stop server") {}
Server &withName(const std::string &name) {
command_ += " --name=" + name;
@@ -210,14 +210,14 @@ class Gfsh {
class Create : public Verb {
public:
- Create(Gfsh &gfsh) : Verb{gfsh} {}
+ explicit Create(Gfsh &gfsh) : Verb{gfsh} {}
class Region;
Region region() { return Region{gfsh_}; };
class Region : public Command<void> {
public:
- Region(Gfsh &gfsh) : Command(gfsh, "create region") {}
+ explicit Region(Gfsh &gfsh) : Command(gfsh, "create region") {}
Region &withName(const std::string &name) {
command_ += " --name=" + name;
@@ -233,7 +233,7 @@ class Gfsh {
class Connect : public Command<void> {
public:
- Connect(Gfsh &gfsh) : Command{gfsh, "connect"} {}
+ explicit Connect(Gfsh &gfsh) : Command{gfsh, "connect"} {}
Connect &withJmxManager(const std::string &jmxManager) {
command_ += " --jmx-manager=" + jmxManager;
@@ -243,7 +243,7 @@ class Gfsh {
class Shutdown : public Command<void> {
public:
- Shutdown(Gfsh &gfsh) : Command{gfsh, "shutdown"} {}
+ explicit Shutdown(Gfsh &gfsh) : Command{gfsh, "shutdown"} {}
Shutdown &withIncludeLocators(bool includeLocators) {
command_ += " --include-locators=" +
diff --git a/cppcache/integration-test-2/framework/GfshExecute.h b/cppcache/integration-test-2/framework/GfshExecute.h
index 07a3237..d44cccc 100644
--- a/cppcache/integration-test-2/framework/GfshExecute.h
+++ b/cppcache/integration-test-2/framework/GfshExecute.h
@@ -47,7 +47,7 @@ class GfshExecute : public Gfsh {
class Connect : public Command<void> {
public:
- Connect(Gfsh &gfsh) : Command{gfsh, "connect"} {}
+ explicit Connect(Gfsh &gfsh) : Command{gfsh, "connect"} {}
Connect &withJmxManager(const std::string &jmxManager) {
command_ += " --jmx-manager=" + jmxManager;
diff --git a/cppcache/integration-test/CacheHelper.hpp b/cppcache/integration-test/CacheHelper.hpp
index 0d999ae..c91212e 100644
--- a/cppcache/integration-test/CacheHelper.hpp
+++ b/cppcache/integration-test/CacheHelper.hpp
@@ -63,20 +63,20 @@ class CacheHelper {
static std::string unitTestOutputFile();
static int getNumLocatorListUpdates(const char* s);
- CacheHelper(const char* member_id,
- const std::shared_ptr<Properties>& configPtr = nullptr,
- const bool noRootRegion = false);
+ explicit CacheHelper(const char* member_id,
+ const std::shared_ptr<Properties>& configPtr = nullptr,
+ const bool noRootRegion = false);
/** rootRegionPtr will still be null... */
CacheHelper(const char* member_id, const char* cachexml,
const std::shared_ptr<Properties>& configPtr = nullptr);
- CacheHelper(const std::shared_ptr<Properties>& configPtr = nullptr,
- const bool noRootRegion = false);
+ explicit CacheHelper(const std::shared_ptr<Properties>& configPtr = nullptr,
+ const bool noRootRegion = false);
- CacheHelper(const bool isThinclient,
- const std::shared_ptr<Properties>& configPtr = nullptr,
- const bool noRootRegion = false);
+ explicit CacheHelper(const bool isThinclient,
+ const std::shared_ptr<Properties>& configPtr = nullptr,
+ const bool noRootRegion = false);
CacheHelper(const bool isThinclient,
const std::shared_ptr<AuthInitialize>& authInitialize,
@@ -95,8 +95,8 @@ class CacheHelper {
int loadConditioningInterval = -1, bool isMultiuserMode = false,
bool prSingleHop = false, bool threadLocal = false);
- CacheHelper(const int redundancyLevel,
- const std::shared_ptr<Properties>& configPtr = nullptr);
+ explicit CacheHelper(const int redundancyLevel,
+ const std::shared_ptr<Properties>& configPtr = nullptr);
virtual ~CacheHelper();
diff --git a/cppcache/integration-test/CacheImplHelper.hpp b/cppcache/integration-test/CacheImplHelper.hpp
index 7f449ca..573cec6 100644
--- a/cppcache/integration-test/CacheImplHelper.hpp
+++ b/cppcache/integration-test/CacheImplHelper.hpp
@@ -41,11 +41,13 @@ using unitTests::TestUtils;
class CacheImplHelper : public CacheHelper {
public:
- CacheImplHelper(const char* member_id,
- const std::shared_ptr<Properties>& configPtr = nullptr)
+ explicit CacheImplHelper(
+ const char* member_id,
+ const std::shared_ptr<Properties>& configPtr = nullptr)
: CacheHelper(member_id, configPtr) {}
- CacheImplHelper(const std::shared_ptr<Properties>& configPtr = nullptr)
+ explicit CacheImplHelper(
+ const std::shared_ptr<Properties>& configPtr = nullptr)
: CacheHelper(configPtr) {}
virtual void createRegion(const char* regionName,
diff --git a/cppcache/integration-test/CacheableWrapper.hpp b/cppcache/integration-test/CacheableWrapper.hpp
index 249abe1..2e4ae4e 100644
--- a/cppcache/integration-test/CacheableWrapper.hpp
+++ b/cppcache/integration-test/CacheableWrapper.hpp
@@ -35,7 +35,7 @@ class CacheableWrapper {
std::shared_ptr<Cacheable> m_cacheableObject;
public:
- CacheableWrapper(const std::shared_ptr<Cacheable> cacheableObject)
+ explicit CacheableWrapper(const std::shared_ptr<Cacheable> cacheableObject)
: m_cacheableObject(cacheableObject) {}
virtual std::shared_ptr<Cacheable> getCacheable() const {
diff --git a/cppcache/integration-test/DeltaEx.hpp b/cppcache/integration-test/DeltaEx.hpp
index 7bc586b..ebcd2a8 100644
--- a/cppcache/integration-test/DeltaEx.hpp
+++ b/cppcache/integration-test/DeltaEx.hpp
@@ -51,7 +51,7 @@ class DeltaEx : public DataSerializable, public Delta {
static int fromDataCount;
static int cloneCount;
DeltaEx() : Delta(), counter(1), isDelta(false) {}
- DeltaEx(int count) : Delta(), counter(count), isDelta(false) {}
+ explicit DeltaEx(int count) : Delta(), counter(count), isDelta(false) {}
DeltaEx(const DeltaEx& rhs) = default;
virtual bool hasDelta() const override { return isDelta; }
@@ -103,7 +103,8 @@ class PdxDeltaEx : public PdxSerializable, public Delta {
static int m_fromDataCount;
static int m_cloneCount;
PdxDeltaEx() : Delta(), m_counter(1), m_isDelta(false) {}
- PdxDeltaEx(int count) : Delta(), m_counter(count), m_isDelta(false) {}
+ explicit PdxDeltaEx(int count)
+ : Delta(), m_counter(count), m_isDelta(false) {}
PdxDeltaEx(const PdxDeltaEx& rhs)
: Delta(), m_counter(rhs.m_counter), m_isDelta(rhs.m_isDelta) {}
virtual bool hasDelta() const override { return m_isDelta; }
diff --git a/cppcache/integration-test/ThinClientDurableInterest.hpp b/cppcache/integration-test/ThinClientDurableInterest.hpp
index fd5f08a..f20e4b1 100644
--- a/cppcache/integration-test/ThinClientDurableInterest.hpp
+++ b/cppcache/integration-test/ThinClientDurableInterest.hpp
@@ -71,7 +71,7 @@ class OperMonitor : public CacheListener {
public:
OperMonitor() : m_ops(0), m_id(-1) {}
- OperMonitor(int id) : m_ops(0), m_id(id) {
+ explicit OperMonitor(int id) : m_ops(0), m_id(id) {
LOGINFO("Inside OperMonitor %d ", m_id);
}
diff --git a/cppcache/integration-test/ThinClientHelper.hpp b/cppcache/integration-test/ThinClientHelper.hpp
index e86d622..d9a950a 100644
--- a/cppcache/integration-test/ThinClientHelper.hpp
+++ b/cppcache/integration-test/ThinClientHelper.hpp
@@ -674,7 +674,7 @@ void destroyRegion(const std::string& name) {
class RegionOperations {
public:
- RegionOperations(const char* name)
+ explicit RegionOperations(const char* name)
: m_regionPtr(getHelper()->getRegion(name)) {}
void putOp(int keys = 1,
diff --git a/cppcache/integration-test/ThinClientPdxSerializer.hpp b/cppcache/integration-test/ThinClientPdxSerializer.hpp
index 8d0aa9e..869c021 100644
--- a/cppcache/integration-test/ThinClientPdxSerializer.hpp
+++ b/cppcache/integration-test/ThinClientPdxSerializer.hpp
@@ -178,7 +178,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, JavaPutGet)
auto regionGetSuccess =
std::dynamic_pointer_cast<CacheableBoolean>(region0->get("success"));
- bool actualValue = regionGetSuccess.get()->value();
+ bool actualValue = regionGetSuccess->value();
ASSERT(actualValue == true,
"Task JavaPutGet:Objects of type NonPdxType should be equal");
diff --git a/cppcache/integration-test/ThinClientSecurityHelper.hpp b/cppcache/integration-test/ThinClientSecurityHelper.hpp
index d3c0a96..2a9df6f 100644
--- a/cppcache/integration-test/ThinClientSecurityHelper.hpp
+++ b/cppcache/integration-test/ThinClientSecurityHelper.hpp
@@ -175,7 +175,8 @@ void initClientAuth(char UserType) {
class putThread : public ACE_Task_Base {
public:
- putThread(std::shared_ptr<Region> r, bool regInt = false, int waitTime = 0) {
+ explicit putThread(std::shared_ptr<Region> r, bool regInt = false,
+ int waitTime = 0) {
m_reg = r;
m_regInt = regInt;
m_numthreads = 1;
diff --git a/cppcache/integration-test/TimeBomb.hpp b/cppcache/integration-test/TimeBomb.hpp
index f09eee5..cf02bcc 100644
--- a/cppcache/integration-test/TimeBomb.hpp
+++ b/cppcache/integration-test/TimeBomb.hpp
@@ -68,7 +68,7 @@ class TimeBomb : public ACE_Task_Base {
public:
ACE_Time_Value m_sleep;
- TimeBomb(void (*cleanupFunc)() = nullptr)
+ explicit TimeBomb(void (*cleanupFunc)() = nullptr)
: m_sleep(0) /* UNUSED , m_numberOfClient( -1 )*/
{
char* sleepEnv = ACE_OS::getenv("TIMEBOMB");
diff --git a/cppcache/integration-test/fw_helper.hpp b/cppcache/integration-test/fw_helper.hpp
index 10b4ca3..2c4c10e 100644
--- a/cppcache/integration-test/fw_helper.hpp
+++ b/cppcache/integration-test/fw_helper.hpp
@@ -173,7 +173,7 @@ class TestOp {
class SuiteMember {
public:
- SuiteMember(TestOp* test) : m_test(test) {}
+ explicit SuiteMember(TestOp* test) : m_test(test) {}
TestOp* m_test;
};
diff --git a/cppcache/integration-test/fw_perf.hpp b/cppcache/integration-test/fw_perf.hpp
index a18e1f1..558457f 100644
--- a/cppcache/integration-test/fw_perf.hpp
+++ b/cppcache/integration-test/fw_perf.hpp
@@ -70,7 +70,7 @@ class Semaphore {
volatile int m_count;
public:
- Semaphore(int count);
+ explicit Semaphore(int count);
~Semaphore();
void acquire(int t = 1);
void release(int t = 1);
@@ -88,7 +88,7 @@ class TimeStamp {
public:
TimeStamp();
TimeStamp(const TimeStamp& other);
- TimeStamp(int64_t msec);
+ explicit TimeStamp(int64_t msec);
TimeStamp& operator=(const TimeStamp& other);
~TimeStamp();
@@ -133,7 +133,7 @@ class PerfSuite {
RecordMap m_records;
public:
- PerfSuite(const char* suiteName);
+ explicit PerfSuite(const char* suiteName);
void addRecord(std::string testName, const long ops, const TimeStamp& start,
const TimeStamp& stop);
diff --git a/cppcache/integration-test/fw_spawn.hpp b/cppcache/integration-test/fw_spawn.hpp
index b4d7745..30d630b 100644
--- a/cppcache/integration-test/fw_spawn.hpp
+++ b/cppcache/integration-test/fw_spawn.hpp
@@ -44,7 +44,7 @@
// Listing 1 code/ch10
class Manager : virtual public ACE_Process {
public:
- Manager(const ACE_TCHAR *program_name) : ACE_Process() {
+ explicit Manager(const ACE_TCHAR *program_name) : ACE_Process() {
ACE_OS::strcpy(programName_, program_name);
}
diff --git a/cppcache/src/AutoDelete.hpp b/cppcache/src/AutoDelete.hpp
index 1126870..7aa13bd 100644
--- a/cppcache/src/AutoDelete.hpp
+++ b/cppcache/src/AutoDelete.hpp
@@ -32,7 +32,7 @@ class DeleteObject {
bool m_cond;
public:
- DeleteObject(T*& p) : m_p(p), m_cond(true) {}
+ explicit DeleteObject(T*& p) : m_p(p), m_cond(true) {}
inline void noDelete() { m_cond = false; }
@@ -52,7 +52,7 @@ class DeleteArray {
bool m_cond;
public:
- DeleteArray(T*& p) : m_p(p), m_cond(true) {}
+ explicit DeleteArray(T*& p) : m_p(p), m_cond(true) {}
inline T operator[](int32_t index) { return m_p[index]; }
diff --git a/cppcache/src/BucketServerLocation.hpp b/cppcache/src/BucketServerLocation.hpp
index 3efe75b..ac27d08 100644
--- a/cppcache/src/BucketServerLocation.hpp
+++ b/cppcache/src/BucketServerLocation.hpp
@@ -47,7 +47,7 @@ class BucketServerLocation : public ServerLocation {
m_serverGroups(nullptr),
m_numServerGroups(static_cast<int8_t>(0)) {}
- BucketServerLocation(std::string host)
+ explicit BucketServerLocation(std::string host)
: ServerLocation(host),
m_bucketId(-1),
m_isPrimary(false),
diff --git a/cppcache/src/CacheConfig.hpp b/cppcache/src/CacheConfig.hpp
index 51010d3..69b9bf7 100644
--- a/cppcache/src/CacheConfig.hpp
+++ b/cppcache/src/CacheConfig.hpp
@@ -50,7 +50,7 @@ typedef std::map<std::string, std::shared_ptr<RegionConfig>> RegionConfigMapT;
class APACHE_GEODE_EXPORT CacheConfig {
public:
- CacheConfig(const char* xmlFileName);
+ explicit CacheConfig(const char* xmlFileName);
bool parse();
diff --git a/cppcache/src/CachePerfStats.hpp b/cppcache/src/CachePerfStats.hpp
index 3268fbe..31fd92e 100644
--- a/cppcache/src/CachePerfStats.hpp
+++ b/cppcache/src/CachePerfStats.hpp
@@ -38,7 +38,7 @@ using statistics::StatisticsFactory;
/** hold statistics for cache.. */
class APACHE_GEODE_EXPORT CachePerfStats {
public:
- CachePerfStats(StatisticsFactory* factory) {
+ explicit CachePerfStats(StatisticsFactory* factory) {
auto statsType = factory->findType("CachePerfStats");
if (statsType == nullptr) {
diff --git a/cppcache/src/CacheTransactionManagerImpl.hpp b/cppcache/src/CacheTransactionManagerImpl.hpp
index 7b65a71..3e577ce 100644
--- a/cppcache/src/CacheTransactionManagerImpl.hpp
+++ b/cppcache/src/CacheTransactionManagerImpl.hpp
@@ -35,7 +35,7 @@ enum commitOp { BEFORE_COMMIT, AFTER_COMMIT };
class CacheTransactionManagerImpl : public virtual CacheTransactionManager {
public:
- CacheTransactionManagerImpl(CacheImpl* cache);
+ explicit CacheTransactionManagerImpl(CacheImpl* cache);
virtual ~CacheTransactionManagerImpl() override;
virtual void begin() override;
diff --git a/cppcache/src/CacheXmlParser.hpp b/cppcache/src/CacheXmlParser.hpp
index 0798d4f..7bc4527 100644
--- a/cppcache/src/CacheXmlParser.hpp
+++ b/cppcache/src/CacheXmlParser.hpp
@@ -77,7 +77,7 @@ class APACHE_GEODE_EXPORT CacheXmlParser : public CacheXml {
void handleParserErrors(int res);
public:
- CacheXmlParser(Cache* cache);
+ explicit CacheXmlParser(Cache* cache);
~CacheXmlParser();
static CacheXmlParser* parse(const char* cachexml, Cache* cache);
void parseFile(const char* filename);
diff --git a/cppcache/src/CacheableObjectPartList.hpp b/cppcache/src/CacheableObjectPartList.hpp
index 1dcd368..11e3e08 100644
--- a/cppcache/src/CacheableObjectPartList.hpp
+++ b/cppcache/src/CacheableObjectPartList.hpp
@@ -75,7 +75,7 @@ class CacheableObjectPartList : public internal::DataSerializableFixedId {
m_destroyTracker(0),
m_addToLocalCache(false) {}
- inline CacheableObjectPartList(ThinClientRegion* region)
+ inline explicit CacheableObjectPartList(ThinClientRegion* region)
: m_keys(nullptr),
m_keysOffset(nullptr),
m_values(nullptr),
diff --git a/cppcache/src/CacheableToken.hpp b/cppcache/src/CacheableToken.hpp
index 67ca715..a800332 100644
--- a/cppcache/src/CacheableToken.hpp
+++ b/cppcache/src/CacheableToken.hpp
@@ -115,7 +115,7 @@ class APACHE_GEODE_EXPORT CacheableToken
virtual size_t objectSize() const override;
CacheableToken(); // used for deserialization.
- CacheableToken(TokenType value);
+ explicit CacheableToken(TokenType value);
private:
// never implemented.
diff --git a/cppcache/src/ClientConnectionRequest.hpp b/cppcache/src/ClientConnectionRequest.hpp
index 91a1ef7..760fc94 100644
--- a/cppcache/src/ClientConnectionRequest.hpp
+++ b/cppcache/src/ClientConnectionRequest.hpp
@@ -32,8 +32,9 @@ namespace client {
class ClientConnectionRequest : public ServerLocationRequest {
public:
- ClientConnectionRequest(const std::set<ServerLocation>& excludeServergroup,
- std::string servergroup = "")
+ explicit ClientConnectionRequest(
+ const std::set<ServerLocation>& excludeServergroup,
+ std::string servergroup = "")
: ServerLocationRequest(),
m_servergroup(servergroup),
m_excludeServergroup_serverLocation(excludeServergroup) {}
diff --git a/cppcache/src/ClientMetadataService.hpp b/cppcache/src/ClientMetadataService.hpp
index ce6209d..cb85c18 100644
--- a/cppcache/src/ClientMetadataService.hpp
+++ b/cppcache/src/ClientMetadataService.hpp
@@ -81,7 +81,9 @@ class PRbuckets {
BucketStatus* m_buckets;
public:
- PRbuckets(int32_t nBuckets) { m_buckets = new BucketStatus[nBuckets]; }
+ explicit PRbuckets(int32_t nBuckets) {
+ m_buckets = new BucketStatus[nBuckets];
+ }
~PRbuckets() { delete[] m_buckets; }
bool isBucketTimedOut(int32_t bucketId, std::chrono::milliseconds millis) {
@@ -96,7 +98,7 @@ class ClientMetadataService : public ACE_Task_Base,
private NonAssignable {
public:
~ClientMetadataService();
- ClientMetadataService(Pool* pool);
+ explicit ClientMetadataService(Pool* pool);
inline void start() {
m_run = true;
diff --git a/cppcache/src/ClientProxyMembershipIDFactory.hpp b/cppcache/src/ClientProxyMembershipIDFactory.hpp
index 08b833a..063938e 100644
--- a/cppcache/src/ClientProxyMembershipIDFactory.hpp
+++ b/cppcache/src/ClientProxyMembershipIDFactory.hpp
@@ -30,7 +30,7 @@ namespace client {
class ClientProxyMembershipIDFactory {
public:
- ClientProxyMembershipIDFactory(std::string dsName);
+ explicit ClientProxyMembershipIDFactory(std::string dsName);
std::unique_ptr<ClientProxyMembershipID> create(
const char* hostname, uint32_t hostAddr, uint32_t hostPort,
diff --git a/cppcache/src/Condition.hpp b/cppcache/src/Condition.hpp
index 55fb779..d918f3e 100644
--- a/cppcache/src/Condition.hpp
+++ b/cppcache/src/Condition.hpp
@@ -40,7 +40,7 @@ class APACHE_GEODE_EXPORT Condition {
/**
* Create a Condition protected by the mutex provided.
*/
- Condition(ACE_Recursive_Thread_Mutex& mutex);
+ explicit Condition(ACE_Recursive_Thread_Mutex& mutex);
~Condition() {}
diff --git a/cppcache/src/CqServiceVsdStats.hpp b/cppcache/src/CqServiceVsdStats.hpp
index 7c5071c..9f6c898 100644
--- a/cppcache/src/CqServiceVsdStats.hpp
+++ b/cppcache/src/CqServiceVsdStats.hpp
@@ -41,8 +41,8 @@ using util::concurrent::spinlock_mutex;
class APACHE_GEODE_EXPORT CqServiceVsdStats : public CqServiceStatistics {
public:
/** hold statistics for a cq. */
- CqServiceVsdStats(statistics::StatisticsFactory* factory,
- const std::string& cqName = "CqServiceVsdStats");
+ explicit CqServiceVsdStats(statistics::StatisticsFactory* factory,
+ const std::string& cqName = "CqServiceVsdStats");
/** disable stat collection for this item. */
virtual ~CqServiceVsdStats();
diff --git a/cppcache/src/DataOutputInternal.hpp b/cppcache/src/DataOutputInternal.hpp
index 3f6abbf..d091e55 100644
--- a/cppcache/src/DataOutputInternal.hpp
+++ b/cppcache/src/DataOutputInternal.hpp
@@ -35,7 +35,7 @@ class DataOutputInternal : public DataOutput {
public:
DataOutputInternal() : DataOutput(nullptr, nullptr) {}
- DataOutputInternal(CacheImpl* cache) : DataOutput(cache, nullptr) {}
+ explicit DataOutputInternal(CacheImpl* cache) : DataOutput(cache, nullptr) {}
inline static Pool* getPool(const DataOutput& dataOutput) {
return dataOutput.getPool();
diff --git a/cppcache/src/DiskVersionTag.hpp b/cppcache/src/DiskVersionTag.hpp
index bfeee2c..4001dad 100644
--- a/cppcache/src/DiskVersionTag.hpp
+++ b/cppcache/src/DiskVersionTag.hpp
@@ -51,7 +51,7 @@ class DiskVersionTag : public VersionTag {
}
public:
- DiskVersionTag(MemberListForVersionStamp& memberListForVersionStamp)
+ explicit DiskVersionTag(MemberListForVersionStamp& memberListForVersionStamp)
: VersionTag(memberListForVersionStamp) {}
DSFid getDSFID() const override { return DSFid::DiskVersionTag; }
diff --git a/cppcache/src/EntriesMap.hpp b/cppcache/src/EntriesMap.hpp
index 39d9343..7454e5b 100644
--- a/cppcache/src/EntriesMap.hpp
+++ b/cppcache/src/EntriesMap.hpp
@@ -43,7 +43,8 @@ namespace client {
*/
class APACHE_GEODE_EXPORT EntriesMap {
public:
- EntriesMap(std::unique_ptr<EntryFactory> entryFactory) : m_entryFactory(std::move(entryFactory)) {}
+ explicit EntriesMap(std::unique_ptr<EntryFactory> entryFactory)
+ : m_entryFactory(std::move(entryFactory)) {}
virtual ~EntriesMap() {}
/**
diff --git a/cppcache/src/EventId.hpp b/cppcache/src/EventId.hpp
index c6c3a05..8494f0e 100644
--- a/cppcache/src/EventId.hpp
+++ b/cppcache/src/EventId.hpp
@@ -104,10 +104,11 @@ class APACHE_GEODE_EXPORT EventId
/** Constructor, given the values. */
EventId(char* memId, uint32_t memIdLen, int64_t thr, int64_t seq);
/** Constructor, used for deserialization. */
- EventId(bool doInit = true, uint32_t reserveSize = 0,
- bool fullValueAfterDeltaFail = false); // set init=false if we dont
- // want to inc sequence (for
- // de-serialization)
+ explicit EventId(
+ bool doInit = true, uint32_t reserveSize = 0,
+ bool fullValueAfterDeltaFail = false); // set init=false if we dont
+ // want to inc sequence (for
+ // de-serialization)
protected:
void initFromTSS(); // init from TSS and increment per-thread sequence number
diff --git a/cppcache/src/EventIdMap.hpp b/cppcache/src/EventIdMap.hpp
index bfa27c6..f1e5446 100644
--- a/cppcache/src/EventIdMap.hpp
+++ b/cppcache/src/EventIdMap.hpp
@@ -143,7 +143,7 @@ class APACHE_GEODE_EXPORT EventSequence {
void clear();
EventSequence();
- EventSequence(int64_t seqNum);
+ explicit EventSequence(int64_t seqNum);
~EventSequence();
// update deadline
diff --git a/cppcache/src/EvictionThread.hpp b/cppcache/src/EvictionThread.hpp
index d2472c2..90c2e26 100644
--- a/cppcache/src/EvictionThread.hpp
+++ b/cppcache/src/EvictionThread.hpp
@@ -39,7 +39,7 @@ typedef IntQueue<int64_t> HeapSizeInfoQueue;
class APACHE_GEODE_EXPORT EvictionThread : public ACE_Task_Base {
public:
- EvictionThread(EvictionController* parent);
+ explicit EvictionThread(EvictionController* parent);
inline void start() {
m_run = true;
diff --git a/cppcache/src/ExecutionImpl.hpp b/cppcache/src/ExecutionImpl.hpp
index 45f43c5..bed43c3 100644
--- a/cppcache/src/ExecutionImpl.hpp
+++ b/cppcache/src/ExecutionImpl.hpp
@@ -39,9 +39,9 @@ typedef std::map<std::string, std::vector<int8_t>*>
class ExecutionImpl {
public:
- ExecutionImpl(std::shared_ptr<Region> rptr = nullptr,
- AuthenticatedView* authenticatedView = nullptr,
- std::shared_ptr<Pool> pp = nullptr)
+ explicit ExecutionImpl(std::shared_ptr<Region> rptr = nullptr,
+ AuthenticatedView* authenticatedView = nullptr,
+ std::shared_ptr<Pool> pp = nullptr)
: m_routingObj(nullptr),
m_args(nullptr),
m_rc(nullptr),
@@ -49,8 +49,8 @@ class ExecutionImpl {
m_allServer(false),
m_pool(pp),
m_authenticatedView(authenticatedView) {}
- ExecutionImpl(std::shared_ptr<Pool> pool, bool allServer = false,
- AuthenticatedView* authenticatedView = nullptr)
+ explicit ExecutionImpl(std::shared_ptr<Pool> pool, bool allServer = false,
+ AuthenticatedView* authenticatedView = nullptr)
: m_routingObj(nullptr),
m_args(nullptr),
m_rc(nullptr),
diff --git a/cppcache/src/FarSideEntryOp.hpp b/cppcache/src/FarSideEntryOp.hpp
index d8583b6..c1b3b85 100644
--- a/cppcache/src/FarSideEntryOp.hpp
+++ b/cppcache/src/FarSideEntryOp.hpp
@@ -85,7 +85,7 @@ class RegionCommit;
class FarSideEntryOp {
public:
- FarSideEntryOp(MemberListForVersionStamp& memberListForVersionStamp);
+ explicit FarSideEntryOp(MemberListForVersionStamp& memberListForVersionStamp);
virtual ~FarSideEntryOp() = default;
void fromData(DataInput& input, bool largeModCount, uint16_t memId);
diff --git a/cppcache/src/FunctionServiceImpl.hpp b/cppcache/src/FunctionServiceImpl.hpp
index d5f791a..4d50a39 100644
--- a/cppcache/src/FunctionServiceImpl.hpp
+++ b/cppcache/src/FunctionServiceImpl.hpp
@@ -38,12 +38,12 @@ namespace client {
class APACHE_GEODE_EXPORT FunctionServiceImpl : public FunctionService {
public:
- FunctionServiceImpl(AuthenticatedView* authenticatedView);
+ explicit FunctionServiceImpl(AuthenticatedView* authenticatedView);
virtual ~FunctionServiceImpl() {}
private:
- FunctionServiceImpl(const FunctionService&);
+ explicit FunctionServiceImpl(const FunctionService&);
FunctionServiceImpl& operator=(const FunctionService&);
static std::shared_ptr<FunctionService> getFunctionService(
diff --git a/cppcache/src/GetAllServersRequest.hpp b/cppcache/src/GetAllServersRequest.hpp
index 732fe66..d4ac760 100644
--- a/cppcache/src/GetAllServersRequest.hpp
+++ b/cppcache/src/GetAllServersRequest.hpp
@@ -38,7 +38,8 @@ class GetAllServersRequest : public internal::DataSerializableFixedId_t<
std::shared_ptr<CacheableString> m_serverGroup;
public:
- GetAllServersRequest(const std::string& serverGroup) : Serializable() {
+ explicit GetAllServersRequest(const std::string& serverGroup)
+ : Serializable() {
m_serverGroup = CacheableString::create(serverGroup);
}
void toData(DataOutput& output) const override;
diff --git a/cppcache/src/InternalCacheTransactionManager2PCImpl.hpp b/cppcache/src/InternalCacheTransactionManager2PCImpl.hpp
index 64a1f34..3284eec 100644
--- a/cppcache/src/InternalCacheTransactionManager2PCImpl.hpp
+++ b/cppcache/src/InternalCacheTransactionManager2PCImpl.hpp
@@ -31,7 +31,7 @@ class InternalCacheTransactionManager2PCImpl
: public CacheTransactionManagerImpl,
public InternalCacheTransactionManager2PC {
public:
- InternalCacheTransactionManager2PCImpl(CacheImpl* cache);
+ explicit InternalCacheTransactionManager2PCImpl(CacheImpl* cache);
virtual ~InternalCacheTransactionManager2PCImpl() override;
virtual void prepare() override;
diff --git a/cppcache/src/LRUAction.hpp b/cppcache/src/LRUAction.hpp
index 87d5d37..cd50115 100644
--- a/cppcache/src/LRUAction.hpp
+++ b/cppcache/src/LRUAction.hpp
@@ -98,7 +98,8 @@ class APACHE_GEODE_EXPORT LRUDestroyAction : public virtual LRUAction {
private:
RegionInternal* m_regionPtr;
- LRUDestroyAction(RegionInternal* regionPtr) : m_regionPtr(regionPtr) {
+ explicit LRUDestroyAction(RegionInternal* regionPtr)
+ : m_regionPtr(regionPtr) {
m_destroys = true;
m_distributes = true;
}
@@ -134,7 +135,8 @@ class APACHE_GEODE_EXPORT LRULocalInvalidateAction : public virtual LRUAction {
private:
RegionInternal* m_regionPtr;
- LRULocalInvalidateAction(RegionInternal* regionPtr) : m_regionPtr(regionPtr) {
+ explicit LRULocalInvalidateAction(RegionInternal* regionPtr)
+ : m_regionPtr(regionPtr) {
m_invalidates = true;
}
diff --git a/cppcache/src/LRUList.hpp b/cppcache/src/LRUList.hpp
index 35aa3f5..8608a84 100644
--- a/cppcache/src/LRUList.hpp
+++ b/cppcache/src/LRUList.hpp
@@ -69,7 +69,7 @@ class APACHE_GEODE_EXPORT LRUEntryProperties {
protected:
// this constructor deliberately skips initializing any fields
- inline LRUEntryProperties(bool) {}
+ inline explicit LRUEntryProperties(bool) {}
private:
std::atomic<uint32_t> m_bits;
@@ -93,7 +93,7 @@ class LRUList {
*/
class LRUListNode {
public:
- inline LRUListNode(const std::shared_ptr<TEntry>& entry)
+ inline explicit LRUListNode(const std::shared_ptr<TEntry>& entry)
: m_entry(entry), m_nextLRUListNode(nullptr) {}
inline ~LRUListNode() {}
diff --git a/cppcache/src/LRUMapEntry.hpp b/cppcache/src/LRUMapEntry.hpp
index 7174070..ece4a6e 100644
--- a/cppcache/src/LRUMapEntry.hpp
+++ b/cppcache/src/LRUMapEntry.hpp
@@ -78,7 +78,7 @@ class APACHE_GEODE_EXPORT LRUMapEntry : public MapEntryImpl,
inline explicit LRUMapEntry(bool)
: MapEntryImpl(true), LRUEntryProperties(true) {}
- inline LRUMapEntry(const std::shared_ptr<CacheableKey>& key)
+ inline explicit LRUMapEntry(const std::shared_ptr<CacheableKey>& key)
: MapEntryImpl(key) {}
private:
@@ -97,7 +97,8 @@ class APACHE_GEODE_EXPORT VersionedLRUMapEntry : public LRUMapEntry,
protected:
inline explicit VersionedLRUMapEntry(bool) : LRUMapEntry(true) {}
- inline VersionedLRUMapEntry(const std::shared_ptr<CacheableKey>& key) : LRUMapEntry(key) {}
+ inline explicit VersionedLRUMapEntry(const std::shared_ptr<CacheableKey>& key)
+ : LRUMapEntry(key) {}
private:
// disabled
diff --git a/cppcache/src/LocatorListRequest.hpp b/cppcache/src/LocatorListRequest.hpp
index 3bc040f..04a7d92 100644
--- a/cppcache/src/LocatorListRequest.hpp
+++ b/cppcache/src/LocatorListRequest.hpp
@@ -35,7 +35,7 @@ class LocatorListRequest : public ServerLocationRequest {
std::string m_servergroup;
public:
- LocatorListRequest(const std::string& servergroup = "");
+ explicit LocatorListRequest(const std::string& servergroup = "");
~LocatorListRequest() override = default;
void toData(DataOutput& output) const override;
diff --git a/cppcache/src/MapEntry.hpp b/cppcache/src/MapEntry.hpp
index 56e4156..c37fb12 100644
--- a/cppcache/src/MapEntry.hpp
+++ b/cppcache/src/MapEntry.hpp
@@ -52,11 +52,10 @@ class APACHE_GEODE_EXPORT ExpEntryProperties {
public:
typedef std::chrono::system_clock::time_point time_point;
- inline ExpEntryProperties(ExpiryTaskManager* expiryTaskManager)
- :
- m_lastAccessTime(0),
- m_lastModifiedTime(0),
- m_expiryTaskId(-1),
+ inline explicit ExpEntryProperties(ExpiryTaskManager* expiryTaskManager)
+ : m_lastAccessTime(0),
+ m_lastModifiedTime(0),
+ m_expiryTaskId(-1),
m_expiryTaskManager(expiryTaskManager) {
// The reactor always gives +ve id while scheduling.
// -1 will indicate that an expiry task has not been scheduled
@@ -259,7 +258,7 @@ class MapEntryImpl : public MapEntry,
protected:
inline explicit MapEntryImpl(bool) : MapEntry(true) {}
- inline MapEntryImpl(const std::shared_ptr<CacheableKey>& key)
+ inline explicit MapEntryImpl(const std::shared_ptr<CacheableKey>& key)
: MapEntry(), m_key(key) {}
std::shared_ptr<Cacheable> m_value;
@@ -276,7 +275,8 @@ class APACHE_GEODE_EXPORT VersionedMapEntryImpl : public MapEntryImpl,
protected:
inline explicit VersionedMapEntryImpl(bool) : MapEntryImpl(true) {}
- inline VersionedMapEntryImpl(const std::shared_ptr<CacheableKey>& key)
+ inline explicit VersionedMapEntryImpl(
+ const std::shared_ptr<CacheableKey>& key)
: MapEntryImpl(key) {}
private:
@@ -287,7 +287,7 @@ class APACHE_GEODE_EXPORT VersionedMapEntryImpl : public MapEntryImpl,
class APACHE_GEODE_EXPORT EntryFactory {
public:
- EntryFactory(const bool concurrencyChecksEnabled)
+ explicit EntryFactory(const bool concurrencyChecksEnabled)
: m_concurrencyChecksEnabled(concurrencyChecksEnabled) {}
virtual ~EntryFactory() {}
diff --git a/cppcache/src/MapEntryT.hpp b/cppcache/src/MapEntryT.hpp
index 23d356f..776f2a9 100644
--- a/cppcache/src/MapEntryT.hpp
+++ b/cppcache/src/MapEntryT.hpp
@@ -126,7 +126,8 @@ class MapEntryT final : public TBase {
return std::make_shared<MapEntryT>(expiryTaskManager, key);
}
- inline MapEntryT(const std::shared_ptr<CacheableKey>& key) : TBase(key) {}
+ inline explicit MapEntryT(const std::shared_ptr<CacheableKey>& key)
+ : TBase(key) {}
inline MapEntryT(ExpiryTaskManager* expiryTaskManager,
const std::shared_ptr<CacheableKey>& key)
: TBase(expiryTaskManager, key) {}
diff --git a/cppcache/src/MemberListForVersionStamp.hpp b/cppcache/src/MemberListForVersionStamp.hpp
index 6a0571f..45840d8 100644
--- a/cppcache/src/MemberListForVersionStamp.hpp
+++ b/cppcache/src/MemberListForVersionStamp.hpp
@@ -32,7 +32,7 @@ namespace geode {
namespace client {
struct DistributedMemberWithIntIdentifier {
public:
- DistributedMemberWithIntIdentifier(
+ explicit DistributedMemberWithIntIdentifier(
std::shared_ptr<DSMemberForVersionStamp> dsmember = nullptr,
uint16_t id = 0) {
this->m_member = dsmember;
diff --git a/cppcache/src/PdxLocalReader.hpp b/cppcache/src/PdxLocalReader.hpp
index b1c04c9..e48bb4d 100644
--- a/cppcache/src/PdxLocalReader.hpp
+++ b/cppcache/src/PdxLocalReader.hpp
@@ -50,7 +50,7 @@ class PdxLocalReader : public PdxReader {
void resettoPdxHead();
public:
- PdxLocalReader(std::shared_ptr<PdxTypeRegistry> pdxTypeRegistry);
+ explicit PdxLocalReader(std::shared_ptr<PdxTypeRegistry> pdxTypeRegistry);
PdxLocalReader(DataInput& input, std::shared_ptr<PdxType> remoteType,
int32_t pdxLen,
diff --git a/cppcache/src/PdxTypeRegistry.hpp b/cppcache/src/PdxTypeRegistry.hpp
index f3bf4f6..444378d 100644
--- a/cppcache/src/PdxTypeRegistry.hpp
+++ b/cppcache/src/PdxTypeRegistry.hpp
@@ -88,7 +88,7 @@ class APACHE_GEODE_EXPORT PdxTypeRegistry
std::shared_ptr<CacheableHashMap> intToEnum;
public:
- PdxTypeRegistry(CacheImpl* cache);
+ explicit PdxTypeRegistry(CacheImpl* cache);
PdxTypeRegistry(const PdxTypeRegistry& other) = delete;
virtual ~PdxTypeRegistry();
diff --git a/cppcache/src/ProxyRemoteQueryService.hpp b/cppcache/src/ProxyRemoteQueryService.hpp
index 9372f08..cbdec33 100644
--- a/cppcache/src/ProxyRemoteQueryService.hpp
+++ b/cppcache/src/ProxyRemoteQueryService.hpp
@@ -38,7 +38,7 @@ class ThinClientPoolDM;
class APACHE_GEODE_EXPORT ProxyRemoteQueryService : public QueryService {
public:
- ProxyRemoteQueryService(AuthenticatedView* cptr);
+ explicit ProxyRemoteQueryService(AuthenticatedView* cptr);
virtual ~ProxyRemoteQueryService() = default;
std::shared_ptr<Query> newQuery(std::string querystring) override;
diff --git a/cppcache/src/PutAllPartialResultServerException.hpp b/cppcache/src/PutAllPartialResultServerException.hpp
index ae84695..50428b6 100644
--- a/cppcache/src/PutAllPartialResultServerException.hpp
+++ b/cppcache/src/PutAllPartialResultServerException.hpp
@@ -41,7 +41,8 @@ class APACHE_GEODE_EXPORT PutAllPartialResultServerException
* @brief public methods
*/
public:
- PutAllPartialResultServerException(std::shared_ptr<PutAllPartialResult> result);
+ explicit PutAllPartialResultServerException(
+ std::shared_ptr<PutAllPartialResult> result);
PutAllPartialResultServerException();
@@ -74,7 +75,8 @@ class APACHE_GEODE_EXPORT PutAllPartialResultServerException
/**
* @brief constructors
*/
- PutAllPartialResultServerException(std::shared_ptr<CacheableString> msg);
+ explicit PutAllPartialResultServerException(
+ std::shared_ptr<CacheableString> msg);
/**
*@brief return as std::shared_ptr<CacheableString> the Exception name
diff --git a/cppcache/src/Queue.hpp b/cppcache/src/Queue.hpp
index 7e6babf..4f6a356 100644
--- a/cppcache/src/Queue.hpp
+++ b/cppcache/src/Queue.hpp
@@ -37,7 +37,7 @@ class APACHE_GEODE_EXPORT Queue {
* Constructor with parameter to specify whether the contained objects
* should be deleted in the destructor, and maximum size of queue.
*/
- Queue(bool deleteObjs = true, const uint32_t maxSize = 0)
+ explicit Queue(bool deleteObjs = true, const uint32_t maxSize = 0)
: m_cond(m_mutex),
m_deleteObjs(deleteObjs),
m_maxSize(maxSize),
diff --git a/cppcache/src/ReadWriteLock.hpp b/cppcache/src/ReadWriteLock.hpp
index 17d45f7..dba5157 100644
--- a/cppcache/src/ReadWriteLock.hpp
+++ b/cppcache/src/ReadWriteLock.hpp
@@ -44,7 +44,9 @@ class TimedTryWriteGuard {
class APACHE_GEODE_EXPORT ReadGuard {
public:
- ReadGuard(ACE_RW_Thread_Mutex& lock) : lock_(lock) { lock_.acquire_read(); }
+ explicit ReadGuard(ACE_RW_Thread_Mutex& lock) : lock_(lock) {
+ lock_.acquire_read();
+ }
~ReadGuard() { lock_.release(); }
bool isAcquired() { return true; }
@@ -55,7 +57,9 @@ class APACHE_GEODE_EXPORT ReadGuard {
class WriteGuard {
public:
- WriteGuard(ACE_RW_Thread_Mutex& lock) : lock_(lock) { lock_.acquire_write(); }
+ explicit WriteGuard(ACE_RW_Thread_Mutex& lock) : lock_(lock) {
+ lock_.acquire_write();
+ }
~WriteGuard() { lock_.release(); }
diff --git a/cppcache/src/RegionCommit.hpp b/cppcache/src/RegionCommit.hpp
index a47c88e..4a656b0 100644
--- a/cppcache/src/RegionCommit.hpp
+++ b/cppcache/src/RegionCommit.hpp
@@ -38,7 +38,7 @@ namespace client {
class RegionCommit {
public:
- RegionCommit(MemberListForVersionStamp& memberListForVersionStamp)
+ explicit RegionCommit(MemberListForVersionStamp& memberListForVersionStamp)
: m_memberListForVersionStamp(memberListForVersionStamp){};
virtual ~RegionCommit(){};
diff --git a/cppcache/src/RegionConfig.hpp b/cppcache/src/RegionConfig.hpp
index 7a8a63e..ce568d6 100644
--- a/cppcache/src/RegionConfig.hpp
+++ b/cppcache/src/RegionConfig.hpp
@@ -41,7 +41,7 @@ class RegionConfig;
class APACHE_GEODE_EXPORT RegionConfig {
public:
- RegionConfig(const std::string& capacity);
+ explicit RegionConfig(const std::string& capacity);
unsigned long entries();
void setConcurrency(const std::string& str);
diff --git a/cppcache/src/RegionGlobalLocks.hpp b/cppcache/src/RegionGlobalLocks.hpp
index e065e2e..5b61833 100644
--- a/cppcache/src/RegionGlobalLocks.hpp
+++ b/cppcache/src/RegionGlobalLocks.hpp
@@ -28,7 +28,7 @@ namespace client {
class APACHE_GEODE_EXPORT RegionGlobalLocks {
public:
- RegionGlobalLocks(LocalRegion* region, bool isFailover = true)
+ explicit RegionGlobalLocks(LocalRegion* region, bool isFailover = true)
: m_region(region), m_isFailover(isFailover) {
m_region->acquireGlobals(m_isFailover);
}
diff --git a/cppcache/src/RegionInternal.hpp b/cppcache/src/RegionInternal.hpp
index 8116826..265afcb 100644
--- a/cppcache/src/RegionInternal.hpp
+++ b/cppcache/src/RegionInternal.hpp
@@ -56,7 +56,7 @@ class CacheEventFlags {
static const uint8_t GF_NOCACHEWRITER = 0x80;
// private constructor
- inline CacheEventFlags(const uint8_t flags) : m_flags(flags) {}
+ inline explicit CacheEventFlags(const uint8_t flags) : m_flags(flags) {}
// disable constructors and assignment
CacheEventFlags();
diff --git a/cppcache/src/RegionXmlCreation.hpp b/cppcache/src/RegionXmlCreation.hpp
index 746480e..fead376 100644
--- a/cppcache/src/RegionXmlCreation.hpp
+++ b/cppcache/src/RegionXmlCreation.hpp
@@ -73,7 +73,7 @@ class APACHE_GEODE_EXPORT RegionXmlCreation {
/**
* Creates a new <code>RegionCreation</code> with the given name.
*/
- RegionXmlCreation(const char* name, bool isRoot = false);
+ explicit RegionXmlCreation(const char* name, bool isRoot = false);
/**
* Adds a subregion with the given name to this region
diff --git a/cppcache/src/RemoteQueryService.hpp b/cppcache/src/RemoteQueryService.hpp
index be54244..a6c8c94 100644
--- a/cppcache/src/RemoteQueryService.hpp
+++ b/cppcache/src/RemoteQueryService.hpp
@@ -43,7 +43,8 @@ class APACHE_GEODE_EXPORT RemoteQueryService
: public QueryService,
public std::enable_shared_from_this<RemoteQueryService> {
public:
- RemoteQueryService(CacheImpl* cptr, ThinClientPoolDM* poolDM = nullptr);
+ explicit RemoteQueryService(CacheImpl* cptr,
+ ThinClientPoolDM* poolDM = nullptr);
virtual ~RemoteQueryService() = default;
void init();
diff --git a/cppcache/src/ResultSetImpl.hpp b/cppcache/src/ResultSetImpl.hpp
index 1c103a5..d2daeb3 100644
--- a/cppcache/src/ResultSetImpl.hpp
+++ b/cppcache/src/ResultSetImpl.hpp
@@ -32,7 +32,7 @@ namespace client {
class APACHE_GEODE_EXPORT ResultSetImpl : public ResultSet {
public:
- ResultSetImpl(const std::shared_ptr<CacheableVector>& response);
+ explicit ResultSetImpl(const std::shared_ptr<CacheableVector>& response);
~ResultSetImpl() noexcept override = default;
size_t size() const override;
diff --git a/cppcache/src/ServerLocation.hpp b/cppcache/src/ServerLocation.hpp
index 409eff7..2f22736 100644
--- a/cppcache/src/ServerLocation.hpp
+++ b/cppcache/src/ServerLocation.hpp
@@ -52,7 +52,7 @@ class APACHE_GEODE_EXPORT ServerLocation
m_port(-1) // Default constructor for deserialiozation.
{}
- ServerLocation(std::string name) {
+ explicit ServerLocation(std::string name) {
/*
name = Utils::convertHostToCanonicalForm(name.c_str());
*/
diff --git a/cppcache/src/Set.hpp b/cppcache/src/Set.hpp
index 62a9a0e..ba6d703 100644
--- a/cppcache/src/Set.hpp
+++ b/cppcache/src/Set.hpp
@@ -52,7 +52,7 @@ class APACHE_GEODE_EXPORT Set : private NonAssignable {
Set<T>& m_set;
typename std::unordered_set<T>::const_iterator m_iter;
- Iterator(Set<T>& set) : m_set(set) {
+ explicit Iterator(Set<T>& set) : m_set(set) {
m_set.m_mutex.acquire();
m_iter = set.m_set.begin();
}
diff --git a/cppcache/src/StackTrace.hpp b/cppcache/src/StackTrace.hpp
index 4254e70..d618dc3 100644
--- a/cppcache/src/StackTrace.hpp
+++ b/cppcache/src/StackTrace.hpp
@@ -31,7 +31,7 @@ namespace client {
class StackTrace {
public:
- StackTrace(size_t skip = 0);
+ explicit StackTrace(size_t skip = 0);
~StackTrace() noexcept;
std::string getString() const;
diff --git a/cppcache/src/TXCleaner.hpp b/cppcache/src/TXCleaner.hpp
index a554d70..7ce0f9a 100644
--- a/cppcache/src/TXCleaner.hpp
+++ b/cppcache/src/TXCleaner.hpp
@@ -36,7 +36,7 @@ namespace client {
class TXCleaner {
public:
- TXCleaner(CacheTransactionManagerImpl* cacheTxMgr);
+ explicit TXCleaner(CacheTransactionManagerImpl* cacheTxMgr);
~TXCleaner();
void clean();
diff --git a/cppcache/src/TXCommitMessage.hpp b/cppcache/src/TXCommitMessage.hpp
index cc61826..fd79a61 100644
--- a/cppcache/src/TXCommitMessage.hpp
+++ b/cppcache/src/TXCommitMessage.hpp
@@ -31,7 +31,8 @@ namespace client {
class TXCommitMessage
: public DataSerializableFixedId_t<DSFid::TXCommitMessage> {
public:
- TXCommitMessage(MemberListForVersionStamp& memberListForVersionStamp);
+ explicit TXCommitMessage(
+ MemberListForVersionStamp& memberListForVersionStamp);
~TXCommitMessage() override = default;
void fromData(DataInput& input) override;
diff --git a/cppcache/src/TXState.hpp b/cppcache/src/TXState.hpp
index f9e2ced..d9b7ce7 100644
--- a/cppcache/src/TXState.hpp
+++ b/cppcache/src/TXState.hpp
@@ -37,7 +37,7 @@ namespace client {
class ThinClientPoolDM;
class TXState {
public:
- TXState(CacheImpl* cacheImpl);
+ explicit TXState(CacheImpl* cacheImpl);
virtual ~TXState();
TXId& getTransactionId();
@@ -87,7 +87,7 @@ class TXState {
long m_suspendedExpiryTaskId;
class ReplayControl {
public:
- ReplayControl(TXState* txState) : m_txState(txState) {
+ explicit ReplayControl(TXState* txState) : m_txState(txState) {
m_txState->startReplay();
};
virtual ~ReplayControl() { m_txState->endReplay(); };
diff --git a/cppcache/src/TcrConnectionManager.hpp b/cppcache/src/TcrConnectionManager.hpp
index 9380dff..7bd9b76 100644
--- a/cppcache/src/TcrConnectionManager.hpp
+++ b/cppcache/src/TcrConnectionManager.hpp
@@ -53,7 +53,7 @@ class ThinClientRegion;
*/
class APACHE_GEODE_EXPORT TcrConnectionManager {
public:
- TcrConnectionManager(CacheImpl* cache);
+ explicit TcrConnectionManager(CacheImpl* cache);
~TcrConnectionManager();
void init(bool isPool = false);
void startFailoverAndCleanupThreads(bool isPool = false);
@@ -204,7 +204,7 @@ class DistManagersLockGuard {
TcrConnectionManager& m_tccm;
public:
- DistManagersLockGuard(TcrConnectionManager& tccm) : m_tccm(tccm) {
+ explicit DistManagersLockGuard(TcrConnectionManager& tccm) : m_tccm(tccm) {
m_tccm.m_distMngrsLock.acquire();
}
diff --git a/cppcache/src/TcrMessage.hpp b/cppcache/src/TcrMessage.hpp
index db0cced..f4637d4 100644
--- a/cppcache/src/TcrMessage.hpp
+++ b/cppcache/src/TcrMessage.hpp
@@ -883,7 +883,7 @@ class TcrMessageTxSynchronization : public TcrMessage {
class TcrMessageClientReady : public TcrMessage {
public:
- TcrMessageClientReady(DataOutput* dataOutput);
+ explicit TcrMessageClientReady(DataOutput* dataOutput);
virtual ~TcrMessageClientReady() {}
@@ -892,7 +892,7 @@ class TcrMessageClientReady : public TcrMessage {
class TcrMessageCommit : public TcrMessage {
public:
- TcrMessageCommit(DataOutput* dataOutput);
+ explicit TcrMessageCommit(DataOutput* dataOutput);
virtual ~TcrMessageCommit() {}
@@ -901,7 +901,7 @@ class TcrMessageCommit : public TcrMessage {
class TcrMessageRollback : public TcrMessage {
public:
- TcrMessageRollback(DataOutput* dataOutput);
+ explicit TcrMessageRollback(DataOutput* dataOutput);
virtual ~TcrMessageRollback() {}
@@ -910,7 +910,7 @@ class TcrMessageRollback : public TcrMessage {
class TcrMessageTxFailover : public TcrMessage {
public:
- TcrMessageTxFailover(DataOutput* dataOutput);
+ explicit TcrMessageTxFailover(DataOutput* dataOutput);
virtual ~TcrMessageTxFailover() {}
diff --git a/cppcache/src/ThinClientCacheDistributionManager.hpp b/cppcache/src/ThinClientCacheDistributionManager.hpp
index 4e67444..5c0feaa 100644
--- a/cppcache/src/ThinClientCacheDistributionManager.hpp
+++ b/cppcache/src/ThinClientCacheDistributionManager.hpp
@@ -36,7 +36,8 @@ class TcrConnection;
class APACHE_GEODE_EXPORT ThinClientCacheDistributionManager
: public ThinClientDistributionManager {
public:
- ThinClientCacheDistributionManager(TcrConnectionManager& connManager);
+ explicit ThinClientCacheDistributionManager(
+ TcrConnectionManager& connManager);
~ThinClientCacheDistributionManager(){};
void init();
diff --git a/cppcache/src/ThinClientRedundancyManager.hpp b/cppcache/src/ThinClientRedundancyManager.hpp
index 7a38383..43c5b03 100644
--- a/cppcache/src/ThinClientRedundancyManager.hpp
+++ b/cppcache/src/ThinClientRedundancyManager.hpp
@@ -50,11 +50,11 @@ class ThinClientRedundancyManager {
void close();
void sendNotificationCloseMsgs();
- ThinClientRedundancyManager(TcrConnectionManager* theConnManager,
- int redundencyLevel = 0,
- ThinClientPoolHADM* poolHADM = nullptr,
- bool sentReadyForEvents = false,
- bool globalProcessedMarker = false);
+ explicit ThinClientRedundancyManager(TcrConnectionManager* theConnManager,
+ int redundencyLevel = 0,
+ ThinClientPoolHADM* poolHADM = nullptr,
+ bool sentReadyForEvents = false,
+ bool globalProcessedMarker = false);
GfErrType sendSyncRequestRegisterInterest(TcrMessage& request,
TcrMessageReply& reply,
bool attemptFailover,
diff --git a/cppcache/src/ThinClientRegion.hpp b/cppcache/src/ThinClientRegion.hpp
index 3d97e45..ba9dd3c 100644
--- a/cppcache/src/ThinClientRegion.hpp
+++ b/cppcache/src/ThinClientRegion.hpp
@@ -438,7 +438,7 @@ class ChunkedQueryResponse : public TcrChunkedResult {
ChunkedQueryResponse& operator=(const ChunkedQueryResponse&);
public:
- inline ChunkedQueryResponse(TcrMessage& msg)
+ inline explicit ChunkedQueryResponse(TcrMessage& msg)
: TcrChunkedResult(),
m_msg(msg),
m_queryResults(CacheableVector::create()) {}
@@ -674,7 +674,7 @@ class ChunkedDurableCQListResponse : public TcrChunkedResult {
ChunkedDurableCQListResponse& operator=(const ChunkedDurableCQListResponse&);
public:
- inline ChunkedDurableCQListResponse(TcrMessage& msg)
+ inline explicit ChunkedDurableCQListResponse(TcrMessage& msg)
: TcrChunkedResult(),
m_msg(msg),
m_resultList(CacheableArrayList::create()) {}
diff --git a/cppcache/src/ThinClientStickyManager.hpp b/cppcache/src/ThinClientStickyManager.hpp
index ab7ef9d..a39c689 100644
--- a/cppcache/src/ThinClientStickyManager.hpp
+++ b/cppcache/src/ThinClientStickyManager.hpp
@@ -34,7 +34,7 @@ class TcrConnection;
class TcrEndpoint;
class ThinClientStickyManager {
public:
- ThinClientStickyManager(ThinClientPoolDM* poolDM) : m_dm(poolDM) {}
+ explicit ThinClientStickyManager(ThinClientPoolDM* poolDM) : m_dm(poolDM) {}
bool getStickyConnection(TcrConnection*& conn, GfErrType* error,
std::set<ServerLocation>& excludeServers,
bool forTransaction);
diff --git a/cppcache/src/ThreadPool.hpp b/cppcache/src/ThreadPool.hpp
index 91812b2..eefa6bd 100644
--- a/cppcache/src/ThreadPool.hpp
+++ b/cppcache/src/ThreadPool.hpp
@@ -104,7 +104,7 @@ class IThreadPool {
class ThreadPoolWorker : public ACE_Task<ACE_MT_SYNCH> {
public:
- ThreadPoolWorker(IThreadPool* manager);
+ explicit ThreadPoolWorker(IThreadPool* manager);
virtual ~ThreadPoolWorker();
int perform(ACE_Method_Request* req);
int shutDown(void);
@@ -123,7 +123,7 @@ class ThreadPool : public ACE_Task_Base, IThreadPool {
friend class ACE_Singleton<ThreadPool, ACE_Recursive_Thread_Mutex>;
public:
- ThreadPool(uint32_t threadPoolSize);
+ explicit ThreadPool(uint32_t threadPoolSize);
virtual ~ThreadPool();
int perform(ACE_Method_Request* req);
int svc(void);
diff --git a/cppcache/src/UserAttributes.hpp b/cppcache/src/UserAttributes.hpp
index ff05b72..bee74fb 100644
--- a/cppcache/src/UserAttributes.hpp
+++ b/cppcache/src/UserAttributes.hpp
@@ -142,7 +142,7 @@ class GuardUserAttributes {
public:
GuardUserAttributes();
- GuardUserAttributes(AuthenticatedView* const authenticatedView);
+ explicit GuardUserAttributes(AuthenticatedView* const authenticatedView);
void setAuthenticatedView(AuthenticatedView* const authenticatedView);
diff --git a/cppcache/src/VersionTag.hpp b/cppcache/src/VersionTag.hpp
index ddfa49b..5c62dd2 100644
--- a/cppcache/src/VersionTag.hpp
+++ b/cppcache/src/VersionTag.hpp
@@ -55,7 +55,7 @@ class VersionTag : public DataSerializableFixedId {
virtual void readMembers(uint16_t flags, DataInput& input);
public:
- VersionTag(MemberListForVersionStamp& memberListForVersionStamp);
+ explicit VersionTag(MemberListForVersionStamp& memberListForVersionStamp);
~VersionTag() override = default;
diff --git a/cppcache/src/statistics/GeodeStatisticsFactory.hpp b/cppcache/src/statistics/GeodeStatisticsFactory.hpp
index a97354c..82ed66a 100644
--- a/cppcache/src/statistics/GeodeStatisticsFactory.hpp
+++ b/cppcache/src/statistics/GeodeStatisticsFactory.hpp
@@ -65,7 +65,7 @@ class GeodeStatisticsFactory : public StatisticsFactory {
StatisticsTypeImpl* addType(StatisticsTypeImpl* t);
public:
- GeodeStatisticsFactory(StatisticsManager* statMngr);
+ explicit GeodeStatisticsFactory(StatisticsManager* statMngr);
~GeodeStatisticsFactory() override;
const std::string& getName() const override;
diff --git a/cppcache/src/statistics/StatArchiveWriter.hpp b/cppcache/src/statistics/StatArchiveWriter.hpp
index 369ff1d..736bcb6 100644
--- a/cppcache/src/statistics/StatArchiveWriter.hpp
+++ b/cppcache/src/statistics/StatArchiveWriter.hpp
@@ -84,7 +84,7 @@ using std::chrono::system_clock;
class APACHE_GEODE_EXPORT StatDataOutput {
public:
- StatDataOutput(CacheImpl* cache);
+ explicit StatDataOutput(CacheImpl *cache);
StatDataOutput(std::string, CacheImpl* cache);
~StatDataOutput();
/**
diff --git a/cppcache/src/statistics/StatSamplerStats.hpp b/cppcache/src/statistics/StatSamplerStats.hpp
index 4df7ea9..a7aa169 100644
--- a/cppcache/src/statistics/StatSamplerStats.hpp
+++ b/cppcache/src/statistics/StatSamplerStats.hpp
@@ -45,7 +45,7 @@ class APACHE_GEODE_EXPORT StatSamplerStats {
StatisticDescriptor** statDescriptorArr;
public:
- StatSamplerStats(StatisticsFactory* statFactory);
+ explicit StatSamplerStats(StatisticsFactory* statFactory);
void tookSample(int64_t nanosSpentWorking);
void close();
void setInitialValues();
diff --git a/cppcache/src/util/Log.hpp b/cppcache/src/util/Log.hpp
index 2800ba5..98184b5 100644
--- a/cppcache/src/util/Log.hpp
+++ b/cppcache/src/util/Log.hpp
@@ -556,7 +556,7 @@ class LogFn {
LogLevel m_level;
public:
- LogFn(const char* functionName, LogLevel level = LogLevel::Finest)
+ explicit LogFn(const char* functionName, LogLevel level = LogLevel::Finest)
: m_functionName(functionName), m_level(level) {
if (Log::enabled(m_level)) Log::enterFn(m_level, m_functionName);
}
diff --git a/cppcache/test/ByteArray.hpp b/cppcache/test/ByteArray.hpp
index af9972c..b32944e 100644
--- a/cppcache/test/ByteArray.hpp
+++ b/cppcache/test/ByteArray.hpp
@@ -45,9 +45,11 @@ class ByteArray {
ByteArray &operator=(const ByteArray &other);
- operator const uint8_t *() const { return m_bytes.get(); }
+ uint8_t operator[](const size_t index) const { return m_bytes.get()[index]; }
- operator uint8_t *() { return m_bytes.get(); }
+ explicit operator const uint8_t *() const { return m_bytes.get(); }
+
+ explicit operator uint8_t *() { return m_bytes.get(); }
const uint8_t *get() const { return m_bytes.get(); }
diff --git a/cppcache/test/DataOutputTest.cpp b/cppcache/test/DataOutputTest.cpp
index f376815..9eb85e7 100644
--- a/cppcache/test/DataOutputTest.cpp
+++ b/cppcache/test/DataOutputTest.cpp
@@ -40,7 +40,7 @@ using apache::geode::client::SerializationRegistry;
class TestDataOutput : public DataOutputInternal {
public:
- TestDataOutput(Cache*)
+ explicit TestDataOutput(Cache*)
: DataOutputInternal(nullptr),
m_byteArray(nullptr),
m_serializationRegistry() {
diff --git a/tests/cpp/fwk/UdpIpc.hpp b/tests/cpp/fwk/UdpIpc.hpp
index c09df74..bdf33bd 100644
--- a/tests/cpp/fwk/UdpIpc.hpp
+++ b/tests/cpp/fwk/UdpIpc.hpp
@@ -43,7 +43,7 @@ namespace testframework {
class UdpIpc : public FrameworkTest {
public:
- UdpIpc(const char* initArgs) : FrameworkTest(initArgs) {}
+ explicit UdpIpc(const char* initArgs) : FrameworkTest(initArgs) {}
virtual ~UdpIpc() {}
@@ -59,7 +59,7 @@ class TestProcessor : public ServiceTask {
bool m_sendReply;
public:
- TestProcessor(UDPMessageQueues* shared, bool sendReply = false)
+ explicit TestProcessor(UDPMessageQueues* shared, bool sendReply = false)
: ServiceTask(shared), m_sendReply(sendReply) {
m_queues = dynamic_cast<UDPMessageQueues*>(m_shared);
}
diff --git a/tests/cpp/fwklib/ClientTask.hpp b/tests/cpp/fwklib/ClientTask.hpp
index 7292ec2..c4c3151 100644
--- a/tests/cpp/fwklib/ClientTask.hpp
+++ b/tests/cpp/fwklib/ClientTask.hpp
@@ -45,7 +45,7 @@ class ClientTask {
int32_t m_Loop;
public:
- ClientTask(int32_t iterations = 0)
+ explicit ClientTask(int32_t iterations = 0)
: m_Exit(false), m_Run(true), m_Iterations(iterations), m_Loop(-1) {}
virtual ~ClientTask() {}
diff --git a/tests/cpp/fwklib/FrameworkTest.hpp b/tests/cpp/fwklib/FrameworkTest.hpp
index 24b37cb..e1d6552 100644
--- a/tests/cpp/fwklib/FrameworkTest.hpp
+++ b/tests/cpp/fwklib/FrameworkTest.hpp
@@ -53,7 +53,7 @@ class FrameworkTest // Base class all test classes written for xml testing
static spinlock_mutex m_lck;
public:
- FrameworkTest(const char* initArgs);
+ explicit FrameworkTest(const char* initArgs);
~FrameworkTest();
int32_t initialize() { return FWK_SUCCESS; }
diff --git a/tests/cpp/fwklib/FwkBB.hpp b/tests/cpp/fwklib/FwkBB.hpp
index f1ecac0..17f869b 100644
--- a/tests/cpp/fwklib/FwkBB.hpp
+++ b/tests/cpp/fwklib/FwkBB.hpp
@@ -82,7 +82,7 @@ namespace testframework {
*/
class FwkBBMessage {
public:
- FwkBBMessage(const char* cmd) : m_cmd(cmd) {}
+ explicit FwkBBMessage(const char* cmd) : m_cmd(cmd) {}
FwkBBMessage() {}
virtual ~FwkBBMessage() {}
diff --git a/tests/cpp/fwklib/FwkBBClient.hpp b/tests/cpp/fwklib/FwkBBClient.hpp
index 730da66..db441fc 100644
--- a/tests/cpp/fwklib/FwkBBClient.hpp
+++ b/tests/cpp/fwklib/FwkBBClient.hpp
@@ -53,7 +53,8 @@ namespace testframework {
*/
class FwkBBClient {
public:
- FwkBBClient(std::string serverAddr) : m_client(serverAddr), m_messageId(0) {}
+ explicit FwkBBClient(std::string serverAddr)
+ : m_client(serverAddr), m_messageId(0) {}
~FwkBBClient() {}
diff --git a/tests/cpp/fwklib/FwkException.hpp b/tests/cpp/fwklib/FwkException.hpp
index b1f395c..3f6ec12 100644
--- a/tests/cpp/fwklib/FwkException.hpp
+++ b/tests/cpp/fwklib/FwkException.hpp
@@ -46,10 +46,12 @@ namespace testframework {
class FwkException {
public:
/** @brief exception message to handle */
- inline FwkException(const std::string& sMessage) : m_sMessage(sMessage) {}
+ inline explicit FwkException(const std::string& sMessage)
+ : m_sMessage(sMessage) {}
/** @brief exception message to handle */
- inline FwkException(const char* pszMessage) : m_sMessage(pszMessage) {}
+ inline explicit FwkException(const char* pszMessage)
+ : m_sMessage(pszMessage) {}
/** @brief get message */
inline const char* getMessage() const { return m_sMessage.c_str(); }
diff --git a/tests/cpp/fwklib/FwkObjects.hpp b/tests/cpp/fwklib/FwkObjects.hpp
index fdc194b..7ad24bf 100644
--- a/tests/cpp/fwklib/FwkObjects.hpp
+++ b/tests/cpp/fwklib/FwkObjects.hpp
@@ -263,13 +263,13 @@ typedef std::vector<std::string> StringVector;
*/
class XMLStringConverter {
public:
- XMLStringConverter(const char* const toTranscode) {
+ explicit XMLStringConverter(const char* const toTranscode) {
m_charForm = nullptr;
// Call the private transcoding method
m_unicodeForm = XMLString::transcode(toTranscode);
}
- XMLStringConverter(const XMLCh* toTranscode) {
+ explicit XMLStringConverter(const XMLCh* toTranscode) {
m_unicodeForm = nullptr;
m_charForm = XMLString::transcode(toTranscode);
}
@@ -314,7 +314,7 @@ class ActionPair {
}
public:
- ActionPair(const DOMNode* node);
+ explicit ActionPair(const DOMNode* node);
const char* getLibraryName() { return m_libraryName.c_str(); }
const char* getLibraryFunctionName() { return m_libraryFunctionName.c_str(); }
@@ -344,7 +344,7 @@ class ExpiryAttributes {
}
public:
- ExpiryAttributes(const DOMNode* node);
+ explicit ExpiryAttributes(const DOMNode* node);
ExpirationAction getAction() { return m_action; }
std::chrono::seconds getTimeout() { return m_timeout; }
@@ -365,7 +365,7 @@ class PersistManager {
void addProperty(const DOMNode* node);
public:
- PersistManager(const DOMNode* node);
+ explicit PersistManager(const DOMNode* node);
~PersistManager() { m_properties = nullptr; }
const char* getLibraryName() { return m_libraryName.c_str(); }
@@ -449,7 +449,7 @@ class Attributes {
ExpiryAttributes* getExpiryAttributes(const DOMNode* node);
public:
- Attributes(const DOMNode* node);
+ explicit Attributes(const DOMNode* node);
RegionAttributes getAttributes() { return m_factory.create(); }
@@ -477,7 +477,7 @@ class FwkRegion {
void setAttributes(Attributes* attributes) { m_attributes = attributes; }
public:
- FwkRegion(const DOMNode* node);
+ explicit FwkRegion(const DOMNode* node);
~FwkRegion() {
if (m_attributes != nullptr) {
delete m_attributes;
@@ -596,7 +596,7 @@ class FwkPool {
void setServersFlag(std::string val) { m_servers = FwkStrCvt::toBool(val); }
public:
- FwkPool(const DOMNode* node);
+ explicit FwkPool(const DOMNode* node);
~FwkPool() = default;
bool isPoolWithLocators() { return m_locators; }
bool isPoolWithServers() { return m_servers; }
@@ -647,7 +647,7 @@ class DataSnippet {
void setPool(FwkPool* pool) { m_pool = pool; }
public:
- DataSnippet(const DOMNode* node);
+ explicit DataSnippet(const DOMNode* node);
~DataSnippet() {
if (m_region != nullptr) {
delete m_region;
@@ -675,7 +675,7 @@ class DataOneof {
std::string m_empty;
public:
- DataOneof(const DOMNode* node);
+ explicit DataOneof(const DOMNode* node);
~DataOneof() { m_values.clear(); }
@@ -733,7 +733,7 @@ class DataList {
}
public:
- DataList(const DOMNode* node);
+ explicit DataList(const DOMNode* node);
~DataList() {
m_map.clear();
@@ -779,7 +779,7 @@ class DataRange {
void setHigh(double high) { m_high = high; }
public:
- DataRange(const DOMNode* node);
+ explicit DataRange(const DOMNode* node);
const std::string getValue() const {
return FwkStrCvt(GsRandom::random(m_low, m_high)).asString();
@@ -797,7 +797,7 @@ class DataRange {
*/
class FwkData : public FwkObject {
public:
- FwkData(const DOMNode* node);
+ explicit FwkData(const DOMNode* node);
~FwkData() {
if (m_dataList != nullptr) {
@@ -928,7 +928,7 @@ class FwkData : public FwkObject {
class FwkDataSet : public TFwkSet<FwkData> {
public:
FwkDataSet() {}
- FwkDataSet(const DOMNode* node);
+ explicit FwkDataSet(const DOMNode* node);
};
// ----------------------------------------------------------------------------
@@ -940,9 +940,9 @@ class FwkDataSet : public TFwkSet<FwkData> {
*/
class FwkClient : public FwkObject {
public:
- FwkClient(const DOMNode* node);
+ explicit FwkClient(const DOMNode* node);
- FwkClient(std::string name)
+ explicit FwkClient(std::string name)
: m_program(nullptr), m_arguments(nullptr), m_remaining(false) {
setName(name);
}
@@ -1017,7 +1017,7 @@ class FwkClientSet : public TFwkSet<FwkClient> {
FwkClientSet()
: m_exclude(false), m_count(1), m_begin(1), m_remaining(false) {}
- FwkClientSet(const DOMNode* node);
+ explicit FwkClientSet(const DOMNode* node);
void setExclude(bool exclude) { m_exclude = exclude; }
@@ -1057,7 +1057,7 @@ class FwkTest;
*/
class FwkTask : public FwkObject {
public:
- FwkTask(const DOMNode* node);
+ explicit FwkTask(const DOMNode* node);
~FwkTask() {
if (m_clientSet != nullptr) {
@@ -1291,7 +1291,7 @@ class TestDriver;
*/
class FwkTest : public FwkObject {
public:
- FwkTest(const DOMNode* node);
+ explicit FwkTest(const DOMNode* node);
/** brief Get FwkDataSet pointer */
const FwkDataSet* getDataSet(const char* name) const;
@@ -1395,7 +1395,7 @@ class LocalFile : public FwkObject {
void setAppend(std::string append) { m_append = FwkStrCvt::toBool(append); }
public:
- LocalFile(const DOMNode* node);
+ explicit LocalFile(const DOMNode* node);
const std::string& getContent() const { return m_content; }
@@ -1522,7 +1522,7 @@ class TestDriver {
}
public:
- TestDriver(const char* file);
+ explicit TestDriver(const char* file);
~TestDriver() {
m_clients.setNoDelete();
m_tasks.setNoDelete();
diff --git a/tests/cpp/fwklib/FwkStrCvt.hpp b/tests/cpp/fwklib/FwkStrCvt.hpp
index 471cd89..a1c55d1 100644
--- a/tests/cpp/fwklib/FwkStrCvt.hpp
+++ b/tests/cpp/fwklib/FwkStrCvt.hpp
@@ -74,13 +74,13 @@ class FwkStrCvt {
static char* hexify(uint8_t* buff, int32_t len);
/** @brief convert from string value */
- FwkStrCvt(const std::string& text) { m_sText = text; };
+ explicit FwkStrCvt(const std::string& text) { m_sText = text; };
/** @brief convert from string value */
- FwkStrCvt(const char* pszText) {
+ explicit FwkStrCvt(const char* pszText) {
if (pszText) m_sText = pszText;
};
/** @brief convert from double value */
- FwkStrCvt(const double dValue) {
+ explicit FwkStrCvt(const double dValue) {
char szText[50];
if (ACE_OS::snprintf(szText, sizeof(szText) - 1, "%lf", dValue)) {
m_sText = szText;
@@ -89,7 +89,7 @@ class FwkStrCvt {
}
};
/** @brief convert from float value */
- FwkStrCvt(const float fValue) {
+ explicit FwkStrCvt(const float fValue) {
char szText[50];
if (ACE_OS::snprintf(szText, sizeof(szText) - 1, "%f", fValue)) {
m_sText = szText;
@@ -98,7 +98,7 @@ class FwkStrCvt {
}
};
/** @brief convert from uint32_t value */
- FwkStrCvt(const uint32_t uiValue) {
+ explicit FwkStrCvt(const uint32_t uiValue) {
char szText[50];
if (ACE_OS::snprintf(szText, sizeof(szText) - 1, "%u", uiValue)) {
m_sText = szText;
@@ -107,7 +107,7 @@ class FwkStrCvt {
}
};
/** @brief convert from int32_t value */
- FwkStrCvt(const int32_t iValue) {
+ explicit FwkStrCvt(const int32_t iValue) {
char szText[50];
if (ACE_OS::snprintf(szText, sizeof(szText) - 1, "%d", iValue)) {
m_sText = szText;
@@ -116,10 +116,12 @@ class FwkStrCvt {
}
};
/** @brief convert from bool value */
- FwkStrCvt(const bool bValue) { m_sText = (bValue) ? "true" : "false"; };
+ explicit FwkStrCvt(const bool bValue) {
+ m_sText = (bValue) ? "true" : "false";
+ };
/** @brief convert from uint64_t value */
- FwkStrCvt(const uint64_t uiValue) {
+ explicit FwkStrCvt(const uint64_t uiValue) {
char szText[100];
if (ACE_OS::snprintf(szText, sizeof(szText) - 1, UInt64_FMT, uiValue)) {
m_sText = szText;
@@ -129,7 +131,7 @@ class FwkStrCvt {
}
/** @brief convert from int64_t value */
- FwkStrCvt(const int64_t iValue) {
+ explicit FwkStrCvt(const int64_t iValue) {
char szText[100];
if (ACE_OS::snprintf(szText, sizeof(szText) - 1, Int64_FMT, iValue)) {
m_sText = szText;
diff --git a/tests/cpp/fwklib/IpcHandler.hpp b/tests/cpp/fwklib/IpcHandler.hpp
index 1c54887..7c9ab13 100644
--- a/tests/cpp/fwklib/IpcHandler.hpp
+++ b/tests/cpp/fwklib/IpcHandler.hpp
@@ -59,9 +59,9 @@ class IpcHandler {
IpcMsg readIpcMsg(int32_t waitSeconds);
public:
- IpcHandler(const ACE_INET_Addr &driver, int32_t maxWaitSecs = 0);
+ explicit IpcHandler(const ACE_INET_Addr &driver, int32_t maxWaitSecs = 0);
- inline IpcHandler(ACE_SOCK_Stream *io) : m_io(io) {
+ inline explicit IpcHandler(ACE_SOCK_Stream *io) : m_io(io) {
ACE_OS::signal(SIGPIPE, SIG_IGN); // Ignore broken pipe
}
diff --git a/tests/cpp/fwklib/PaceMeter.hpp b/tests/cpp/fwklib/PaceMeter.hpp
index 589c8c5..2ef0eb3 100644
--- a/tests/cpp/fwklib/PaceMeter.hpp
+++ b/tests/cpp/fwklib/PaceMeter.hpp
@@ -66,7 +66,7 @@ class PaceMeter {
ACE_Time_Value m_timeLimit;
public:
- PaceMeter(int32_t ops, int32_t seconds = 1)
+ explicit PaceMeter(int32_t ops, int32_t seconds = 1)
: m_opsLimit(0),
m_current(0),
m_waitSeconds(0),
diff --git a/tests/cpp/fwklib/PerfFwk.hpp b/tests/cpp/fwklib/PerfFwk.hpp
index aba34df..0886bea 100644
--- a/tests/cpp/fwklib/PerfFwk.hpp
+++ b/tests/cpp/fwklib/PerfFwk.hpp
@@ -72,7 +72,8 @@ class Semaphore {
public:
Semaphore() : m_mutex(), m_cond(m_mutex), m_count(0) {}
- Semaphore(int32_t count) : m_mutex(), m_cond(m_mutex), m_count(count) {}
+ explicit Semaphore(int32_t count)
+ : m_mutex(), m_cond(m_mutex), m_count(count) {}
// Semaphore( const Semaphore& other ) : m_mutex(), m_cond( m_mutex ),
// m_count( other.getCount() ) {}
diff --git a/tests/cpp/fwklib/RegionHelper.hpp b/tests/cpp/fwklib/RegionHelper.hpp
index b075af9..be4e09f 100644
--- a/tests/cpp/fwklib/RegionHelper.hpp
+++ b/tests/cpp/fwklib/RegionHelper.hpp
@@ -52,7 +52,7 @@ class RegionHelper {
public:
/** Fill in this instance of RegionHelper based on the spec named by sname.
*/
- RegionHelper(const FrameworkTest* test) : m_region(nullptr) {
+ explicit RegionHelper(const FrameworkTest* test) : m_region(nullptr) {
m_spec = test->getStringValue("regionSpec");
if (m_spec.empty()) {
FWKEXCEPTION("Failed to find regionSpec definition.");
diff --git a/tests/cpp/fwklib/Service.hpp b/tests/cpp/fwklib/Service.hpp
index c2e1f77..3edd310 100644
--- a/tests/cpp/fwklib/Service.hpp
+++ b/tests/cpp/fwklib/Service.hpp
@@ -50,7 +50,8 @@ class ServiceTask {
SharedTaskObject* m_shared;
public:
- ServiceTask(SharedTaskObject* shared) : m_run(nullptr), m_shared(shared) {}
+ explicit ServiceTask(SharedTaskObject* shared)
+ : m_run(nullptr), m_shared(shared) {}
virtual ~ServiceTask() {}
@@ -82,7 +83,7 @@ class Service : public ACE_Task_Base {
}
public:
- Service(int32_t threadCnt);
+ explicit Service(int32_t threadCnt);
inline ~Service() { stopThreads(); }
@@ -142,7 +143,7 @@ class IPCMessage {
public:
IPCMessage() {}
- IPCMessage(std::string content) { m_msg = content; }
+ explicit IPCMessage(std::string content) { m_msg = content; }
virtual ~IPCMessage() {}
diff --git a/tests/cpp/fwklib/TcpIpc.hpp b/tests/cpp/fwklib/TcpIpc.hpp
index d5f2ada..6300e33 100644
--- a/tests/cpp/fwklib/TcpIpc.hpp
+++ b/tests/cpp/fwklib/TcpIpc.hpp
@@ -42,14 +42,15 @@ class TcpIpc {
int32_t getSize(ACE_HANDLE sock, int32_t flag);
public:
- TcpIpc(std::string& ipaddr, int32_t sockBufferSize = 0) : m_ipaddr(ipaddr) {
+ explicit TcpIpc(std::string& ipaddr, int32_t sockBufferSize = 0)
+ : m_ipaddr(ipaddr) {
init(sockBufferSize);
}
- TcpIpc(char* ipaddr, int32_t sockBufferSize = 0) : m_ipaddr(ipaddr) {
+ explicit TcpIpc(char* ipaddr, int32_t sockBufferSize = 0) : m_ipaddr(ipaddr) {
init(sockBufferSize);
}
- TcpIpc(int32_t sockBufferSize = 0) { init(sockBufferSize); }
+ explicit TcpIpc(int32_t sockBufferSize = 0) { init(sockBufferSize); }
~TcpIpc();
diff --git a/tests/cpp/fwklib/TestClient.hpp b/tests/cpp/fwklib/TestClient.hpp
index 53ecbc3..78e858a 100644
--- a/tests/cpp/fwklib/TestClient.hpp
+++ b/tests/cpp/fwklib/TestClient.hpp
@@ -70,7 +70,7 @@ class TestClient : public ACE_Task_Base {
return until;
}
- TestClient(int32_t threadCnt);
+ explicit TestClient(int32_t threadCnt);
inline ~TestClient() {
stopThreads();
diff --git a/tests/cpp/fwklib/TimeSync.hpp b/tests/cpp/fwklib/TimeSync.hpp
index ddc16b2..4855bdf 100644
--- a/tests/cpp/fwklib/TimeSync.hpp
+++ b/tests/cpp/fwklib/TimeSync.hpp
@@ -57,7 +57,8 @@ class TimeSync : public ACE_Task_Base {
void recvTimeSync();
public:
- inline TimeSync(int32_t port, int32_t* delta = nullptr, bool report = false)
+ inline explicit TimeSync(int32_t port, int32_t* delta = nullptr,
+ bool report = false)
: m_delta(delta),
m_done(false),
m_port(port),
diff --git a/tests/cpp/fwklib/UDPIpc.hpp b/tests/cpp/fwklib/UDPIpc.hpp
index e79130c..9586652 100644
--- a/tests/cpp/fwklib/UDPIpc.hpp
+++ b/tests/cpp/fwklib/UDPIpc.hpp
@@ -78,13 +78,13 @@ class UDPMessage : public IPCMessage {
m_msg.clear();
}
- UDPMessage(UdpCmds cmd) {
+ explicit UDPMessage(UdpCmds cmd) {
clearHdr();
m_msg.clear();
setCmd(cmd);
}
- UDPMessage(std::string content) : IPCMessage(content) { clearHdr(); }
+ explicit UDPMessage(std::string content) : IPCMessage(content) { clearHdr(); }
UDPMessage(UDPMessage& msg) : IPCMessage(msg.what()) {
clearHdr();
@@ -141,7 +141,7 @@ class UDPMessageClient {
ACE_SOCK_Dgram m_io;
public:
- UDPMessageClient(std::string server);
+ explicit UDPMessageClient(std::string server);
~UDPMessageClient() { m_io.close(); }
@@ -162,7 +162,7 @@ class UDPMessageQueues : public SharedTaskObject {
std::string m_label;
public:
- UDPMessageQueues(std::string label) : m_label(label) {}
+ explicit UDPMessageQueues(std::string label) : m_label(label) {}
~UDPMessageQueues() {
FWKINFO(m_label << "MessageQueues::Inbound count: " << m_cntInbound);
FWKINFO(m_label << "MessageQueues::Processed count: " << m_cntProcessed);
@@ -253,7 +253,7 @@ class Processor : public ServiceTask {
// UNUSED bool m_sendReply;
public:
- Processor(UDPMessageQueues* shared) : ServiceTask(shared) {
+ explicit Processor(UDPMessageQueues* shared) : ServiceTask(shared) {
m_queues = dynamic_cast<UDPMessageQueues*>(m_shared);
}
diff --git a/tests/cpp/security/PkcsAuthInit.hpp b/tests/cpp/security/PkcsAuthInit.hpp
index c8a424d..4ea235d 100644
--- a/tests/cpp/security/PkcsAuthInit.hpp
+++ b/tests/cpp/security/PkcsAuthInit.hpp
@@ -68,7 +68,7 @@ namespace client {
class PKCSAuthInitInternal : public AuthInitialize {
public:
- PKCSAuthInitInternal(bool makeString = false)
+ explicit PKCSAuthInitInternal(bool makeString = false)
: m_stringCredentials(makeString) {}
~PKCSAuthInitInternal() noexcept override = default;
diff --git a/tests/cpp/security/Security.hpp b/tests/cpp/security/Security.hpp
index 7a9c0af..8a62a4b 100644
--- a/tests/cpp/security/Security.hpp
+++ b/tests/cpp/security/Security.hpp
@@ -59,7 +59,7 @@ namespace security {
class Security : public FrameworkTest {
public:
- Security(const char* initArgs)
+ explicit Security(const char* initArgs)
: FrameworkTest(initArgs),
m_KeysA(nullptr),
m_MaxKeys(0),
diff --git a/tests/cpp/security/XmlAuthzCredentialGenerator.hpp b/tests/cpp/security/XmlAuthzCredentialGenerator.hpp
index 9199fa8..a123fb0 100644
--- a/tests/cpp/security/XmlAuthzCredentialGenerator.hpp
+++ b/tests/cpp/security/XmlAuthzCredentialGenerator.hpp
@@ -64,7 +64,7 @@ class XmlAuthzCredentialGenerator {
stringList QueryRegions;
public:
- XmlAuthzCredentialGenerator(ID id)
+ explicit XmlAuthzCredentialGenerator(ID id)
: m_id(id),
Readers(RArr, RArr + sizeof RArr / sizeof *RArr),
Writers(WArr, WArr + sizeof WArr / sizeof *WArr),
diff --git a/tests/cpp/testobject/EqStruct.hpp b/tests/cpp/testobject/EqStruct.hpp
index 002b601..41d5a75 100644
--- a/tests/cpp/testobject/EqStruct.hpp
+++ b/tests/cpp/testobject/EqStruct.hpp
@@ -98,7 +98,7 @@ class TESTOBJECT_EXPORT EqStruct : public TimestampedObject {
public:
EqStruct() {}
- EqStruct(int index);
+ explicit EqStruct(int index);
~EqStruct() override = default;
virtual void toData(apache::geode::client::DataOutput& output) const override;
virtual void fromData(apache::geode::client::DataInput& input) override;
diff --git a/tests/cpp/testobject/NestedPdxObject.hpp b/tests/cpp/testobject/NestedPdxObject.hpp
index ade430b..9c2e04c 100644
--- a/tests/cpp/testobject/NestedPdxObject.hpp
+++ b/tests/cpp/testobject/NestedPdxObject.hpp
@@ -51,7 +51,7 @@ class TESTOBJECT_EXPORT ChildPdx : public PdxSerializable {
public:
ChildPdx() {}
- ChildPdx(int id) {
+ explicit ChildPdx(int id) {
m_childId = id;
m_childName = "name-" + std::to_string(id);
m_enum = CacheableEnum::create("Gender", "female", 5);
@@ -101,7 +101,7 @@ class TESTOBJECT_EXPORT ParentPdx : public PdxSerializable {
public:
ParentPdx() {}
- ParentPdx(int id) {
+ explicit ParentPdx(int id) {
m_parentId = id;
m_parentName = "name-" + std::to_string(id);
m_childPdx = std::make_shared<ChildPdx>(id /** 1393*/);
@@ -166,7 +166,7 @@ class TESTOBJECT_EXPORT PdxEnumTestClass : public PdxSerializable {
std::shared_ptr<CacheableEnum> getEnumID() { return m_enumid; }
- PdxEnumTestClass(int id) {
+ explicit PdxEnumTestClass(int id) {
m_id = id;
switch (m_id) {
case 0:
@@ -230,7 +230,7 @@ class TESTOBJECT_EXPORT SerializePdx : public PdxSerializable {
public:
SerializePdx() {}
- SerializePdx(bool init) {
+ explicit SerializePdx(bool init) {
if (init) {
i1 = 1;
i2 = 2;
diff --git a/tests/cpp/testobject/PdxClassV1.hpp b/tests/cpp/testobject/PdxClassV1.hpp
index 2c38b19..43f5de2 100644
--- a/tests/cpp/testobject/PdxClassV1.hpp
+++ b/tests/cpp/testobject/PdxClassV1.hpp
@@ -341,7 +341,7 @@ class TESTOBJECT_EXPORT PdxVersionedV1 : public PdxSerializable {
public:
PdxVersionedV1();
- PdxVersionedV1(int32_t size);
+ explicit PdxVersionedV1(int32_t size);
~PdxVersionedV1() noexcept override;
@@ -377,7 +377,7 @@ class TESTOBJECT_EXPORT TestKeyV1 {
public:
TestKeyV1();
- TestKeyV1(char* id);
+ explicit TestKeyV1(char* id);
};
/************************************************************
@@ -392,7 +392,7 @@ class TESTOBJECT_EXPORT TestDiffTypePdxSV1 {
public:
TestDiffTypePdxSV1();
- TestDiffTypePdxSV1(bool init);
+ explicit TestDiffTypePdxSV1(bool init);
bool equals(const TestDiffTypePdxSV1& obj);
};
diff --git a/tests/cpp/testobject/PdxClassV2.hpp b/tests/cpp/testobject/PdxClassV2.hpp
index d9bcfe1..3c10180 100644
--- a/tests/cpp/testobject/PdxClassV2.hpp
+++ b/tests/cpp/testobject/PdxClassV2.hpp
@@ -366,7 +366,7 @@ class TESTOBJECT_EXPORT PdxVersionedV2 : public PdxSerializable {
public:
PdxVersionedV2();
- PdxVersionedV2(int32_t size);
+ explicit PdxVersionedV2(int32_t size);
~PdxVersionedV2() noexcept override;
@@ -402,7 +402,7 @@ class TESTOBJECT_EXPORT TestKeyV2 {
public:
TestKeyV2();
- TestKeyV2(char* id);
+ explicit TestKeyV2(char* id);
};
/************************************************************
@@ -419,7 +419,7 @@ class TESTOBJECT_EXPORT TestDiffTypePdxSV2 {
public:
TestDiffTypePdxSV2();
- TestDiffTypePdxSV2(bool init);
+ explicit TestDiffTypePdxSV2(bool init);
bool equals(const TestDiffTypePdxSV2& obj);
};
diff --git a/tests/cpp/testobject/PdxVersioned1.hpp b/tests/cpp/testobject/PdxVersioned1.hpp
index 9132d0e..e50c343 100644
--- a/tests/cpp/testobject/PdxVersioned1.hpp
+++ b/tests/cpp/testobject/PdxVersioned1.hpp
@@ -109,7 +109,7 @@ class TESTOBJECT_EXPORT PdxVersioned1 : public PdxSerializable {
init(key);
}*/
PdxVersioned1() { init("def"); }
- PdxVersioned1(const char* key);
+ explicit PdxVersioned1(const char* key);
void init(const char* key);
inline bool compareBool(bool b, bool b2) {
if (b == b2) return b;
diff --git a/tests/cpp/testobject/PdxVersioned2.hpp b/tests/cpp/testobject/PdxVersioned2.hpp
index 56e1d73..7bd05fd 100644
--- a/tests/cpp/testobject/PdxVersioned2.hpp
+++ b/tests/cpp/testobject/PdxVersioned2.hpp
@@ -113,7 +113,7 @@ class TESTOBJECT_EXPORT PdxVersioned2 : public PdxSerializable {
}
*/
PdxVersioned2() { init("abc"); }
- PdxVersioned2(const char* key);
+ explicit PdxVersioned2(const char* key);
void init(const char* key);
inline bool compareBool(bool b, bool b2) {
if (b == b2) return b;
diff --git a/tests/cpp/testobject/Portfolio.hpp b/tests/cpp/testobject/Portfolio.hpp
index 1e26e05..1ef669d 100644
--- a/tests/cpp/testobject/Portfolio.hpp
+++ b/tests/cpp/testobject/Portfolio.hpp
@@ -66,8 +66,8 @@ class TESTOBJECT_EXPORT Portfolio : public DataSerializable {
creationDate(nullptr),
arrayNull(nullptr),
arrayZeroSize(nullptr) {}
- Portfolio(int32_t id, uint32_t size = 0,
- std::shared_ptr<CacheableStringArray> nm = nullptr);
+ explicit Portfolio(int32_t id, uint32_t size = 0,
+ std::shared_ptr<CacheableStringArray> nm = nullptr);
~Portfolio() noexcept override;
size_t objectSize() const override {
diff --git a/tests/cpp/testobject/PortfolioPdx.hpp b/tests/cpp/testobject/PortfolioPdx.hpp
index edcbec0..c1f9ed6 100644
--- a/tests/cpp/testobject/PortfolioPdx.hpp
+++ b/tests/cpp/testobject/PortfolioPdx.hpp
@@ -62,7 +62,8 @@ class TESTOBJECT_EXPORT PortfolioPdx : public PdxSerializable {
arrayNull(),
arrayZeroSize() {}
- PortfolioPdx(int32_t id, int32_t size = 0, std::vector<std::string> nm = {});
+ explicit PortfolioPdx(int32_t id, int32_t size = 0,
+ std::vector<std::string> nm = {});
int32_t getID() { return id; }
diff --git a/tests/cpp/testobject/Position.hpp b/tests/cpp/testobject/Position.hpp
index 0cafe21..4b30e85 100644
--- a/tests/cpp/testobject/Position.hpp
+++ b/tests/cpp/testobject/Position.hpp
@@ -68,7 +68,7 @@ class TESTOBJECT_EXPORT Position : public DataSerializable {
Position();
Position(const char* id, int32_t out);
// This constructor is just for some internal data validation test
- Position(int32_t iForExactVal);
+ explicit Position(int32_t iForExactVal);
~Position() override = default;
void toData(DataOutput& output) const override;
void fromData(DataInput& input) override;
diff --git a/tests/cpp/testobject/PositionPdx.hpp b/tests/cpp/testobject/PositionPdx.hpp
index 83fa29b..dc1ab0e 100644
--- a/tests/cpp/testobject/PositionPdx.hpp
+++ b/tests/cpp/testobject/PositionPdx.hpp
@@ -65,7 +65,7 @@ class TESTOBJECT_EXPORT PositionPdx : public PdxSerializable {
PositionPdx();
PositionPdx(const char* id, int32_t out);
// This constructor is just for some internal data validation test
- PositionPdx(int32_t iForExactVal);
+ explicit PositionPdx(int32_t iForExactVal);
~PositionPdx() override = default;
using PdxSerializable::fromData;
diff --git a/tests/cpp/testobject/TestObject1.hpp b/tests/cpp/testobject/TestObject1.hpp
index a8ade99..6edcb80 100644
--- a/tests/cpp/testobject/TestObject1.hpp
+++ b/tests/cpp/testobject/TestObject1.hpp
@@ -43,7 +43,7 @@ class TESTOBJECT_EXPORT TestObject1 : public DataSerializable {
public:
TestObject1();
- TestObject1(int32_t id)
+ explicit TestObject1(int32_t id)
: name(nullptr),
arr(CacheableBytes::create(std::vector<int8_t>(4 * 1024))),
identifier(id) {}
diff --git a/tests/cpp/testobject/VariousPdxTypes.hpp b/tests/cpp/testobject/VariousPdxTypes.hpp
index 18c5d83..9325661 100644
--- a/tests/cpp/testobject/VariousPdxTypes.hpp
+++ b/tests/cpp/testobject/VariousPdxTypes.hpp
@@ -451,7 +451,7 @@ class TESTOBJECT_EXPORT NestedPdx : public PdxSerializable {
public:
NestedPdx();
- NestedPdx(char* key);
+ explicit NestedPdx(char* key);
~NestedPdx() noexcept override;
@@ -498,7 +498,7 @@ class TESTOBJECT_EXPORT MixedVersionNestedPdx : public PdxSerializable {
public:
MixedVersionNestedPdx();
- MixedVersionNestedPdx(char* key);
+ explicit MixedVersionNestedPdx(char* key);
~MixedVersionNestedPdx() noexcept override;