You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xap-commits@incubator.apache.org by mt...@apache.org on 2006/09/18 19:22:10 UTC
svn commit: r447511 -
/incubator/xap/trunk/src/xap/taghandling/PluginRegistryImpl.js
Author: mturyn
Date: Mon Sep 18 12:22:10 2006
New Revision: 447511
URL: http://svn.apache.org/viewvc?view=rev&rev=447511
Log:
1.) Added session parameter to lifecycle object creation, needed by xap.data.DataNamespaceHandler and doesn't hurt any of the others.
2.) Put a "return" statement into getPluginDefinition().
Modified:
incubator/xap/trunk/src/xap/taghandling/PluginRegistryImpl.js
Modified: incubator/xap/trunk/src/xap/taghandling/PluginRegistryImpl.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/taghandling/PluginRegistryImpl.js?view=diff&rev=447511&r1=447510&r2=447511
==============================================================================
--- incubator/xap/trunk/src/xap/taghandling/PluginRegistryImpl.js (original)
+++ incubator/xap/trunk/src/xap/taghandling/PluginRegistryImpl.js Mon Sep 18 12:22:10 2006
@@ -121,7 +121,10 @@
try{
Xap.require(lifecycleClassName);
//TODO we need a generic "load this bean" type of method
- var lifecycleObject = eval("new " + lifecycleClassName + "()");
+ // Only DataNamespaceHandler seems to need
+ // this, but it doesn't hurt the others...
+ var lifecycleObject = eval("new " + lifecycleClassName + "(this._session)");
+
//TODO maybe we should just have a container for lifecycle objects
//so that you can look them up and the notification is done via
@@ -144,7 +147,8 @@
* plugin file representing this tag/namespace combo
*/
xap.taghandling.PluginRegistryImpl.prototype.getPluginDefinition = function( tagName, nameSpace, documentName){
- this._tagDefinitions.get(xap.taghandling.PluginRegistryImpl._createHashtableKey(tagName,nameSpace,documentName));
+ var theKey = xap.taghandling.PluginRegistryImpl._createHashtableKey(tagName,nameSpace,documentName) ;
+ return this._tagDefinitions.get(theKey);
}