[GitHub] [royale-compiler] joshtynjala commented on issue #95: Unneeded dependency on XML in every JS file

[GitBox <gi...@apache.org>]

joshtynjala commented on issue #95: Unneeded dependency on XML in every JS file
URL: https://github.com/apache/royale-compiler/issues/95#issuecomment-530476454
 
 
   I fixed the issue where `goog.require('XML')` was being incorrectly added to externs.
   
   The behavior where it is being added to all other files still remains. I'd need to dig in compiler and figure out if it's doing that on purpose or not. I see that it's inserting `goog.require('org.apache.royale.utils.Language')` only in files where that one is necessary, and I would have expected that these two would be handled in the same way. The fact that they're not means that XML may have some complicated reason why it's being required everywhere.
   
   However, I also don't think that adding `goog.require('XML')` has any bad side effects. It's just some extra unnecessary code that gets cleaned up in a release build anyway. With that in mind, it's probably not a very high priority.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services