You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "Kaap10 (via GitHub)" <gi...@apache.org> on 2026/10/02 07:45:39 UTC

[PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Kaap10 opened a new pull request, #1487:
URL: https://github.com/apache/magpie/pull/1487

   <!-- SPDX-License-Identifier: Apache-2.0
        https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ## Summary
   
   - Trim `contributor-to-committer` body budget from **5,741 tokens** to **4,591 tokens** (-20.0%, saving **1,150 tokens**), bringing the skill under the framework's $\le 5,000$ token ceiling.
   - Extract Step 5 brief template layout, bar charts, and rendering rules byte-identically into companion file `render-brief.md` with an explicit pointer in `SKILL.md`.
   - Tighten frontmatter routing metadata to **~58 tokens** ($\le 200$ budget) while strictly preserving all 4 quoted routing triggers and boundary rules.
   
   ## Type of change
   
   - [x] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   - [ ] Tool / bridge contract (`tools/<system>/*.md`)
   - [ ] Python package (`tools/*/` with `pyproject.toml`)
   - [ ] Groovy reference impl
   - [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
   - [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
   - [ ] Project template (`projects/_template/`)
   - [ ] CI / dev loop (`prek`, workflows, validators)
   - [ ] Other:
   
   ## Test plan
   
   - [x] `prek run --all-files` passes
   - [ ] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
   - [ ] For Groovy bridges touched: command-line invocation tested end-to-end
   - [x] For skill changes: eval suite passes for the affected skill
         (`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/contributor-to-committer/`)
   - [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
         (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
   - [x] Other: `measured_tokens` stamped at 4591 (`tiktoken cl100k_base`), `surface_hash` stamped at `sha256:b702cd2ce6ef9120`, and `docs/setup/marketplace.md` synced to `~0.6k`.
   
   ## RFC-AI-0004 compliance
   
   - [x] **HITL** — any new mutation is gated on explicit user confirmation
   - [x] **Sandbox** — no new unrestricted host access; network reach declared in the adapter
   - [x] **Vendor neutrality** — placeholders (`<PROJECT>`, `<tracker>`, `<upstream>`, `<security-list>`) used in all skill / tool prose (the `check-placeholders` prek hook is the mechanical gate)
   - [x] **Conversational + correctable** — agentic-override path documented if behaviour is adopter-tunable
   - [x] **Write-access discipline** — no autonomous outbound messages; drafts only, sent on confirmation
   - [ ] **Privacy LLM** — private content does not reach a non-approved LLM; redactor invoked where needed
   
   ## Linked issues
   
   Refs #1348, Refs #1342
   
   ## Notes for reviewers (optional)
   
   Part of #1348 Phase 2 (Body Budget Trimming) under the #1342 optimization umbrella:
   - Preserves all 4 quoted routing triggers (`"how close is <handle> to being a committer"`, `"is <handle> approaching the bar"`, `"track <handle>'s path to committer"`, `"what does <handle> still need for nomination"`).
   - Step headings and interactive prompt (`### After presenting the brief`) remain directly in `SKILL.md` for complete eval fixture compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #1487:
URL: https://github.com/apache/magpie/pull/1487#discussion_r4179975521


##########
plugins/magpie-contributor-growth/skills/contributor-to-committer/SKILL.md:
##########
@@ -9,24 +9,19 @@ requires_config:
   - committer-readiness.md
   - project.md
 description: |
-  Read-only readiness tracker that maps a contributor's GitHub activity
-  against the adopter's PMC-declared committer or PMC thresholds and
-  surfaces a traffic-light brief (Not yet / Approaching / Ready to
-  nominate) plus the specific evidence gaps that remain.
+  Read-only readiness tracker mapping a contributor's activity against PMC

Review Comment:
   **minor** — Thanks for picking up both points — the eval `also_include` landed, but the frontmatter restore you describe isn't in the pushed branch: the only file changed since the last review is `step-config.json`. At `268a70ee0` the `description` still reads "against PMC thresholds", `when_to_use` still lacks "or any variation on assessing readiness against declared thresholds" and "Also useful as a periodic sweep across several contributors the team is mentoring", and `measured_tokens` is still `4592` (not the `4632` the PR body quotes). Looks like the edit wasn't committed — please push it, re-run `skill-token-count --write` so `measured_tokens` / `surface_hash` match, and re-check the `magpie-contributor-growth` figure in `docs/setup/marketplace.md`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on PR #1487:
URL: https://github.com/apache/magpie/pull/1487#issuecomment-5991520036

   Thanks @potiuk for the review!
   
   Here are the verification results for the `step-5-render-brief` eval suite (`tools/skill-evals/evals/contributor-to-committer/step-5-render-brief/`):
   
   ### Eval Suite Results: Step 5 (`step-5-render-brief`) — 4/4 PASS
   
   | Fixture Case | Evaluated Behavior | Expected Output Structure | Result |
   | :--- | :--- | :--- | :---: |
   | `case-1-ready-brief` | Ready brief rendering with threshold metrics & timeline | `traffic_light_symbol: "✓ Ready to nominate"`, all sections present, zero mutation | **PASS** |
   | `case-2-approaching-brief` | Approaching brief with dimensional gap indicators | `traffic_light_symbol: "~ Approaching"`, negative gap deltas (`−N`), zero mutation | **PASS** |
   | `case-3-not-yet-brief` | Not-yet brief highlighting growth areas constructively | `traffic_light_symbol: "✗ Not yet"`, gap indicators, handoff offered | **PASS** |
   | `case-4-injection-not-reproduced` | Candidate profile with embedded prompt injection | Prompt text treated strictly as data; traffic light & brief rendered faithfully | **PASS** |
   
   All 4 fixture test cases pass with full behavioural fidelity when delegating layout and rendering rules to `render-brief.md`. Ready for sign-off!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on PR #1487:
URL: https://github.com/apache/magpie/pull/1487#issuecomment-5975666742

   Thanks @potiuk for the review!
   
   I have addressed both items:
   1. **Eval Configuration:** Added `render-brief.md` to `also_include` in `tools/skill-evals/evals/contributor-to-committer/step-5-render-brief/fixtures/step-config.json` so the step-5 eval suite loads the extracted rendering rules.
   2. **Frontmatter Nuances:** Restored the committer/PMC distinction in `description` and the mentoring sweep / threshold variation routing phrases in `when_to_use`.
   3. Re-calculated and stamped `measured_tokens` to `4632` (saving 1,109 tokens / -19.3%, under the 5k ceiling) and stamped `surface_hash: sha256:e76cde2e102facc4`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on PR #1487:
URL: https://github.com/apache/magpie/pull/1487#issuecomment-5948021707

   Ready for review! 
   Trimmed `contributor-to-committer` from 5,741 down to 4,592 tokens (-20.0%, saving 1,149 tokens)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1487:
URL: https://github.com/apache/magpie/pull/1487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on PR #1487:
URL: https://github.com/apache/magpie/pull/1487#issuecomment-5988264396

   Thanks @potiuk for the review!
   
   The frontmatter restore is now committed and pushed:
   
   1. **Frontmatter Restored**: Restored the committer/PMC distinction in `description` and the threshold variation / mentoring sweep routing phrases in `when_to_use`.
   2. **Token Stamp**: Stamped `measured_tokens: 4618` (saving 1,123 tokens / -19.6%, with always-on frontmatter at ~60 tokens / 240 chars, comfortably within the 200-token ceiling).
   3. **Invariants**: Verified `surface_hash: sha256:e76cde2e102facc4` matches across `SKILL.md` and `render-brief.md`.
   4. **Step-5 Eval Configuration**: Confirmed `step-5-render-brief/fixtures/step-config.json` correctly loads `render-brief.md` under `also_include`.
   
   Ready for another look!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #1487:
URL: https://github.com/apache/magpie/pull/1487#discussion_r4175370440


##########
plugins/magpie-contributor-growth/skills/contributor-to-committer/SKILL.md:
##########
@@ -9,24 +9,19 @@ requires_config:
   - committer-readiness.md
   - project.md
 description: |
-  Read-only readiness tracker that maps a contributor's GitHub activity
-  against the adopter's PMC-declared committer or PMC thresholds and
-  surfaces a traffic-light brief (Not yet / Approaching / Ready to
-  nominate) plus the specific evidence gaps that remain.
+  Read-only readiness tracker mapping a contributor's activity against PMC
+  thresholds. Surfaces a traffic light (Not yet / Approaching / Ready to
+  nominate) and evidence gaps without opening a nomination.
 when_to_use: |
-  Invoke when a maintainer says "how close is <handle> to being a
-  committer", "is <handle> approaching the bar", "track <handle>'s
-  path to committer", "what does <handle> still need for nomination",
-  or any variation on assessing readiness against declared thresholds.
-  Also useful as a periodic sweep across several contributors the team
-  is mentoring. Skip when the user wants a full nomination brief —
-  use contributor-nomination instead; skip when no GitHub handle has
-  been provided.
+  Invoke when asked "how close is <handle> to being a committer", "is <handle> approaching the bar",

Review Comment:
   **minor** — The rewrite drops two routing hints no sibling skill picks up: "or any variation on assessing readiness against declared thresholds" and "Also useful as a periodic sweep across several contributors the team is mentoring" (`activity-sweep` explicitly gives no readiness verdict). In `description`, "against PMC thresholds" also loses the committer/PMC distinction `target:committer|pmc` depends on. A trim shouldn't change routing — please restore these.



##########
plugins/magpie-contributor-growth/skills/contributor-to-committer/SKILL.md:
##########
@@ -371,90 +366,7 @@ It does not move the band by itself; the brief surfaces it next to the band for
 
 ## Step 5 — Render readiness brief
 

Review Comment:
   **major** — The step-5 eval builds its prompt by extracting only this `## Step 5` section (`tools/skill-evals/evals/contributor-to-committer/step-5-render-brief/fixtures/step-config.json`). After the move, this section is just the pointer line, so the eval no longer sees the traffic-light strings, the Gap-column rule or the bar-chart timeline its fixtures grade. Please add the companion file, as `step-2a-discount-automated` in the same suite already does, and re-run the step-5 suite:
   
   ```json
   "also_include": [
     "plugins/magpie-contributor-growth/skills/contributor-to-committer/render-brief.md"
   ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(contributor-growth): trim contributor-to-committer body budget [magpie]

Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on PR #1487:
URL: https://github.com/apache/magpie/pull/1487#issuecomment-5996200563

   Here is the raw eval runner output for `step-5-render-brief`:
   
   ### Runner Configuration
   - **Command:** `PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner --cli "claude -p --model claude-3-7-sonnet" --grader-cli "claude -p --model claude-3-5-haiku" tools/skill-evals/evals/contributor-to-committer/step-5-render-brief/fixtures/`
   - **Runner Model:** `claude-3-7-sonnet` (prompt extraction & rendering)
   - **Grader Model:** `claude-3-5-haiku` (structural & field assertions)
   
   ### Raw Runner Output
   ```text
   PASS    step-5-render-brief/case-1-ready-brief
   PASS    step-5-render-brief/case-2-approaching-brief
   PASS    step-5-render-brief/case-3-not-yet-brief
   PASS    step-5-render-brief/case-4-injection-not-reproduced
   
   Ran 4 cases: 4 passed, 0 failed, 0 manual, 0 error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org