You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/09 14:18:59 UTC
[GitHub] [spark] peter-toth opened a new pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
peter-toth opened a new pull request #29988:
URL: https://github.com/apache/spark/pull/29988
### What changes were proposed in this pull request?
Fix `InConversion` rule by finding the common wider type of list expressions first and then the final common type for comparison between the value and the list expressions.
Before this PR the query `SELECT * FROM t WHERE c IN ('2')` where c is `Int` generated the following filter:
```
Filter cast(c#31 as string) IN (cast(2 as string))
```
After this PR it generates:
```
Filter cast(c#31 as int) IN (cast(2 as int))
```
that is identical to what a `WHERE c = '2'` would do.
### Why are the changes needed?
To make `In` behave like `=` and avoid issues described in https://issues.apache.org/jira/browse/SPARK-33098
### Does this PR introduce _any_ user-facing change?
Yes, some queries will not fail.
### How was this patch tested?
Existing UTs and I will add some new ones as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706302368
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129587/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706260942
> > Does it duplicate #22038?
>
> Hmm, it might be the case. Unfortunately, I didn't notice that old PR. Let check how they relate to each other.
It is a duplicate indeed. I will close my PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706241991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706232957
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34192/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706220043
> Does it duplicate #22038?
Hmm, it might be the case. Unfortunately, I didn't notice that old PR. Let check how they relate to each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706210206
**[Test build #129587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129587/testReport)** for PR 29988 at commit [`558c032`](https://github.com/apache/spark/commit/558c032edf2ce9784933aa049a7445f99a5fae89).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706301975
**[Test build #129587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129587/testReport)** for PR 29988 at commit [`558c032`](https://github.com/apache/spark/commit/558c032edf2ce9784933aa049a7445f99a5fae89).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706302352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706302352
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth closed pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
peter-toth closed pull request #29988:
URL: https://github.com/apache/spark/pull/29988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706210206
**[Test build #129587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129587/testReport)** for PR 29988 at commit [`558c032`](https://github.com/apache/spark/commit/558c032edf2ce9784933aa049a7445f99a5fae89).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706241964
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34192/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706217155
Does it duplicate #22038?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29988: [WIP][SPARK-33098][SQL] Fix In expression casts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29988:
URL: https://github.com/apache/spark/pull/29988#issuecomment-706241991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org