You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2021/07/24 22:27:45 UTC
[whimsy] branch family-first updated: Fix obvious errors
This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch family-first
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/family-first by this push:
new 9a297b3 Fix obvious errors
9a297b3 is described below
commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
Author: Sebb <se...@apache.org>
AuthorDate: Sat Jul 24 23:27:37 2021 +0100
Fix obvious errors
- spurious trailing )
- duplicate function name
---
www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
index 4a893a3..656a854 100644
--- a/www/secretary/workbench/views/forms/icla.js.rb
+++ b/www/secretary/workbench/views/forms/icla.js.rb
@@ -258,7 +258,7 @@ class ICLA < Vue
end
# generate file name from the real name
- def genfilename(realname, familyfirst))
+ def genfilename(realname, familyfirst)
nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
if !familyfirst
return nominalname
@@ -280,7 +280,7 @@ class ICLA < Vue
end
# generate LDAP givenName from public name
- def genldapsn(pnamearray, ffirst)
+ def genldapgivenname(pnamearray, ffirst)
if ffirst
return pnamearray[-1]
else
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by Sam Ruby <ru...@intertwingly.net>.
On Sun, Jul 25, 2021 at 7:40 PM Craig Russell <ap...@gmail.com> wrote:
>
> > On Jul 25, 2021, at 2:06 PM, sebb <se...@gmail.com> wrote:
> >
> > AFAICT the code cannot have been tested -- previously it did not even
> > compile, and there was a missing method.
>
> You are completely correct. I made the decision not to invest the few hours needed to set up the workbench (the notes in www/secretary/workbench/README led me to believe that there was an hour of downloading stuff just to get started).
That definitely used to be the case, but Sebb trimmed this down
considerably a while ago. In particular, one used to have a complete
copy of all ICLAs, but that is no more.
I don't know about how long it will take to download just what the
workbench needs, but downloading everything every tool might need is
less than 200MB these days.
I just tried it here after erasing my /srv/svn directory, and was able
to completely download everything in 71 seconds using the command
"rake svn:update". This was across wifi with Spectrum, where my plan
provides me 200Mb/second download speeds.
- Sam Ruby
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by sebb <se...@gmail.com>.
On Mon, 26 Jul 2021 at 00:40, Craig Russell <ap...@gmail.com> wrote:
>
>
>
> > On Jul 25, 2021, at 2:06 PM, sebb <se...@gmail.com> wrote:
> >
> > On Sun, 25 Jul 2021 at 19:32, Craig Russell <apache.clr@gmail.com <ma...@gmail.com>> wrote:
> >>
> >> Hi Sebb,
> >>
> >>> On Jul 25, 2021, at 2:55 AM, sebb <se...@gmail.com> wrote:
> >>>
> >>> On Sat, 24 Jul 2021 at 23:46, Craig Russell <ap...@gmail.com> wrote:
> >>>>
> >>>> Hi Sebb,
> >>>>
> >>>> Thanks for the review.
> >>>>
> >>>> Do you see any harm in merging this branch?
> >>>
> >>> Yes, there are no tests.
> >>
> >> News to me. Where are the tests for the icla panel?
> >
> > I always try to at least run the code locally before making it live.
> > e.g. by testing individual methods in irb or a Ruby script.
>
>
> > Many of the workbench screens can be exercised in a local installation
> > without progressing to a commit.
> > I have not done so with the proposed code.
>
> Same here.
> >
> > AFAICT the code cannot have been tested -- previously it did not even
> > compile, and there was a missing method.
>
> You are completely correct. I made the decision not to invest the few hours needed to set up the workbench (the notes in www/secretary/workbench/README led me to believe that there was an hour of downloading stuff just to get started).
If you already have Docker, it may be less, but it does take a while.
Setting up a Ruby script to test methods takes a few minutes.
> I know that testing a UI application is appallingly difficult but thought that perhaps there were some "unit tests" that the components could use.
There are some tests for various parts of Whimsy:
./www/board/agenda/node_modules/json-schema-traverse/spec
./www/board/agenda/spec
./lib/spec
> Regards
> Craig
> >
> >> Thanks,
> >> Craig
> >>>
> >>>> I'd like to see it in action...
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Craig
> >>>>
> >>>>> On Jul 24, 2021, at 3:27 PM, sebb@apache.org wrote:
> >>>>>
> >>>>> This is an automated email from the ASF dual-hosted git repository.
> >>>>>
> >>>>> sebb pushed a commit to branch family-first
> >>>>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
> >>>>>
> >>>>>
> >>>>> The following commit(s) were added to refs/heads/family-first by this push:
> >>>>> new 9a297b3 Fix obvious errors
> >>>>> 9a297b3 is described below
> >>>>>
> >>>>> commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
> >>>>> Author: Sebb <se...@apache.org>
> >>>>> AuthorDate: Sat Jul 24 23:27:37 2021 +0100
> >>>>>
> >>>>> Fix obvious errors
> >>>>>
> >>>>> - spurious trailing )
> >>>>> - duplicate function name
> >>>>> ---
> >>>>> www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
> >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
> >>>>> index 4a893a3..656a854 100644
> >>>>> --- a/www/secretary/workbench/views/forms/icla.js.rb
> >>>>> +++ b/www/secretary/workbench/views/forms/icla.js.rb
> >>>>> @@ -258,7 +258,7 @@ class ICLA < Vue
> >>>>> end
> >>>>>
> >>>>> # generate file name from the real name
> >>>>> - def genfilename(realname, familyfirst))
> >>>>> + def genfilename(realname, familyfirst)
> >>>>> nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
> >>>>> if !familyfirst
> >>>>> return nominalname
> >>>>> @@ -280,7 +280,7 @@ class ICLA < Vue
> >>>>> end
> >>>>>
> >>>>> # generate LDAP givenName from public name
> >>>>> - def genldapsn(pnamearray, ffirst)
> >>>>> + def genldapgivenname(pnamearray, ffirst)
> >>>>> if ffirst
> >>>>> return pnamearray[-1]
> >>>>> else
> >>>>
> >>>> Craig L Russell
> >>>> clr@apache.org
> >>>>
> >>
> >> Craig L Russell
> >> clr@apache.org
>
> Craig L Russell
> clr@apache.org
>
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by Craig Russell <ap...@gmail.com>.
> On Jul 25, 2021, at 2:06 PM, sebb <se...@gmail.com> wrote:
>
> On Sun, 25 Jul 2021 at 19:32, Craig Russell <apache.clr@gmail.com <ma...@gmail.com>> wrote:
>>
>> Hi Sebb,
>>
>>> On Jul 25, 2021, at 2:55 AM, sebb <se...@gmail.com> wrote:
>>>
>>> On Sat, 24 Jul 2021 at 23:46, Craig Russell <ap...@gmail.com> wrote:
>>>>
>>>> Hi Sebb,
>>>>
>>>> Thanks for the review.
>>>>
>>>> Do you see any harm in merging this branch?
>>>
>>> Yes, there are no tests.
>>
>> News to me. Where are the tests for the icla panel?
>
> I always try to at least run the code locally before making it live.
> e.g. by testing individual methods in irb or a Ruby script.
> Many of the workbench screens can be exercised in a local installation
> without progressing to a commit.
> I have not done so with the proposed code.
Same here.
>
> AFAICT the code cannot have been tested -- previously it did not even
> compile, and there was a missing method.
You are completely correct. I made the decision not to invest the few hours needed to set up the workbench (the notes in www/secretary/workbench/README led me to believe that there was an hour of downloading stuff just to get started).
I know that testing a UI application is appallingly difficult but thought that perhaps there were some "unit tests" that the components could use.
Regards
Craig
>
>> Thanks,
>> Craig
>>>
>>>> I'd like to see it in action...
>>>>
>>>> Thanks,
>>>>
>>>> Craig
>>>>
>>>>> On Jul 24, 2021, at 3:27 PM, sebb@apache.org wrote:
>>>>>
>>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>>
>>>>> sebb pushed a commit to branch family-first
>>>>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>>>>>
>>>>>
>>>>> The following commit(s) were added to refs/heads/family-first by this push:
>>>>> new 9a297b3 Fix obvious errors
>>>>> 9a297b3 is described below
>>>>>
>>>>> commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
>>>>> Author: Sebb <se...@apache.org>
>>>>> AuthorDate: Sat Jul 24 23:27:37 2021 +0100
>>>>>
>>>>> Fix obvious errors
>>>>>
>>>>> - spurious trailing )
>>>>> - duplicate function name
>>>>> ---
>>>>> www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
>>>>> index 4a893a3..656a854 100644
>>>>> --- a/www/secretary/workbench/views/forms/icla.js.rb
>>>>> +++ b/www/secretary/workbench/views/forms/icla.js.rb
>>>>> @@ -258,7 +258,7 @@ class ICLA < Vue
>>>>> end
>>>>>
>>>>> # generate file name from the real name
>>>>> - def genfilename(realname, familyfirst))
>>>>> + def genfilename(realname, familyfirst)
>>>>> nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
>>>>> if !familyfirst
>>>>> return nominalname
>>>>> @@ -280,7 +280,7 @@ class ICLA < Vue
>>>>> end
>>>>>
>>>>> # generate LDAP givenName from public name
>>>>> - def genldapsn(pnamearray, ffirst)
>>>>> + def genldapgivenname(pnamearray, ffirst)
>>>>> if ffirst
>>>>> return pnamearray[-1]
>>>>> else
>>>>
>>>> Craig L Russell
>>>> clr@apache.org
>>>>
>>
>> Craig L Russell
>> clr@apache.org
Craig L Russell
clr@apache.org
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by sebb <se...@gmail.com>.
On Sun, 25 Jul 2021 at 19:32, Craig Russell <ap...@gmail.com> wrote:
>
> Hi Sebb,
>
> > On Jul 25, 2021, at 2:55 AM, sebb <se...@gmail.com> wrote:
> >
> > On Sat, 24 Jul 2021 at 23:46, Craig Russell <ap...@gmail.com> wrote:
> >>
> >> Hi Sebb,
> >>
> >> Thanks for the review.
> >>
> >> Do you see any harm in merging this branch?
> >
> > Yes, there are no tests.
>
> News to me. Where are the tests for the icla panel?
I always try to at least run the code locally before making it live.
e.g. by testing individual methods in irb or a Ruby script.
Many of the workbench screens can be exercised in a local installation
without progressing to a commit.
I have not done so with the proposed code.
AFAICT the code cannot have been tested -- previously it did not even
compile, and there was a missing method.
> Thanks,
> Craig
> >
> >> I'd like to see it in action...
> >>
> >> Thanks,
> >>
> >> Craig
> >>
> >>> On Jul 24, 2021, at 3:27 PM, sebb@apache.org wrote:
> >>>
> >>> This is an automated email from the ASF dual-hosted git repository.
> >>>
> >>> sebb pushed a commit to branch family-first
> >>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
> >>>
> >>>
> >>> The following commit(s) were added to refs/heads/family-first by this push:
> >>> new 9a297b3 Fix obvious errors
> >>> 9a297b3 is described below
> >>>
> >>> commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
> >>> Author: Sebb <se...@apache.org>
> >>> AuthorDate: Sat Jul 24 23:27:37 2021 +0100
> >>>
> >>> Fix obvious errors
> >>>
> >>> - spurious trailing )
> >>> - duplicate function name
> >>> ---
> >>> www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
> >>> index 4a893a3..656a854 100644
> >>> --- a/www/secretary/workbench/views/forms/icla.js.rb
> >>> +++ b/www/secretary/workbench/views/forms/icla.js.rb
> >>> @@ -258,7 +258,7 @@ class ICLA < Vue
> >>> end
> >>>
> >>> # generate file name from the real name
> >>> - def genfilename(realname, familyfirst))
> >>> + def genfilename(realname, familyfirst)
> >>> nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
> >>> if !familyfirst
> >>> return nominalname
> >>> @@ -280,7 +280,7 @@ class ICLA < Vue
> >>> end
> >>>
> >>> # generate LDAP givenName from public name
> >>> - def genldapsn(pnamearray, ffirst)
> >>> + def genldapgivenname(pnamearray, ffirst)
> >>> if ffirst
> >>> return pnamearray[-1]
> >>> else
> >>
> >> Craig L Russell
> >> clr@apache.org
> >>
>
> Craig L Russell
> clr@apache.org
>
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by Craig Russell <ap...@gmail.com>.
Hi Sebb,
> On Jul 25, 2021, at 2:55 AM, sebb <se...@gmail.com> wrote:
>
> On Sat, 24 Jul 2021 at 23:46, Craig Russell <ap...@gmail.com> wrote:
>>
>> Hi Sebb,
>>
>> Thanks for the review.
>>
>> Do you see any harm in merging this branch?
>
> Yes, there are no tests.
News to me. Where are the tests for the icla panel?
Thanks,
Craig
>
>> I'd like to see it in action...
>>
>> Thanks,
>>
>> Craig
>>
>>> On Jul 24, 2021, at 3:27 PM, sebb@apache.org wrote:
>>>
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> sebb pushed a commit to branch family-first
>>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/family-first by this push:
>>> new 9a297b3 Fix obvious errors
>>> 9a297b3 is described below
>>>
>>> commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
>>> Author: Sebb <se...@apache.org>
>>> AuthorDate: Sat Jul 24 23:27:37 2021 +0100
>>>
>>> Fix obvious errors
>>>
>>> - spurious trailing )
>>> - duplicate function name
>>> ---
>>> www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
>>> index 4a893a3..656a854 100644
>>> --- a/www/secretary/workbench/views/forms/icla.js.rb
>>> +++ b/www/secretary/workbench/views/forms/icla.js.rb
>>> @@ -258,7 +258,7 @@ class ICLA < Vue
>>> end
>>>
>>> # generate file name from the real name
>>> - def genfilename(realname, familyfirst))
>>> + def genfilename(realname, familyfirst)
>>> nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
>>> if !familyfirst
>>> return nominalname
>>> @@ -280,7 +280,7 @@ class ICLA < Vue
>>> end
>>>
>>> # generate LDAP givenName from public name
>>> - def genldapsn(pnamearray, ffirst)
>>> + def genldapgivenname(pnamearray, ffirst)
>>> if ffirst
>>> return pnamearray[-1]
>>> else
>>
>> Craig L Russell
>> clr@apache.org
>>
Craig L Russell
clr@apache.org
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by sebb <se...@gmail.com>.
On Sat, 24 Jul 2021 at 23:46, Craig Russell <ap...@gmail.com> wrote:
>
> Hi Sebb,
>
> Thanks for the review.
>
> Do you see any harm in merging this branch?
Yes, there are no tests.
> I'd like to see it in action...
>
> Thanks,
>
> Craig
>
> > On Jul 24, 2021, at 3:27 PM, sebb@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > sebb pushed a commit to branch family-first
> > in repository https://gitbox.apache.org/repos/asf/whimsy.git
> >
> >
> > The following commit(s) were added to refs/heads/family-first by this push:
> > new 9a297b3 Fix obvious errors
> > 9a297b3 is described below
> >
> > commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
> > Author: Sebb <se...@apache.org>
> > AuthorDate: Sat Jul 24 23:27:37 2021 +0100
> >
> > Fix obvious errors
> >
> > - spurious trailing )
> > - duplicate function name
> > ---
> > www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
> > index 4a893a3..656a854 100644
> > --- a/www/secretary/workbench/views/forms/icla.js.rb
> > +++ b/www/secretary/workbench/views/forms/icla.js.rb
> > @@ -258,7 +258,7 @@ class ICLA < Vue
> > end
> >
> > # generate file name from the real name
> > - def genfilename(realname, familyfirst))
> > + def genfilename(realname, familyfirst)
> > nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
> > if !familyfirst
> > return nominalname
> > @@ -280,7 +280,7 @@ class ICLA < Vue
> > end
> >
> > # generate LDAP givenName from public name
> > - def genldapsn(pnamearray, ffirst)
> > + def genldapgivenname(pnamearray, ffirst)
> > if ffirst
> > return pnamearray[-1]
> > else
>
> Craig L Russell
> clr@apache.org
>
Re: [whimsy] branch family-first updated: Fix obvious errors
Posted by Craig Russell <ap...@gmail.com>.
Hi Sebb,
Thanks for the review.
Do you see any harm in merging this branch?
I'd like to see it in action...
Thanks,
Craig
> On Jul 24, 2021, at 3:27 PM, sebb@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> sebb pushed a commit to branch family-first
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/family-first by this push:
> new 9a297b3 Fix obvious errors
> 9a297b3 is described below
>
> commit 9a297b38f1a77b908e939e341248b7a8cd8808b1
> Author: Sebb <se...@apache.org>
> AuthorDate: Sat Jul 24 23:27:37 2021 +0100
>
> Fix obvious errors
>
> - spurious trailing )
> - duplicate function name
> ---
> www/secretary/workbench/views/forms/icla.js.rb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
> index 4a893a3..656a854 100644
> --- a/www/secretary/workbench/views/forms/icla.js.rb
> +++ b/www/secretary/workbench/views/forms/icla.js.rb
> @@ -258,7 +258,7 @@ class ICLA < Vue
> end
>
> # generate file name from the real name
> - def genfilename(realname, familyfirst))
> + def genfilename(realname, familyfirst)
> nominalname = asciize(realname.strip()).downcase().gsub(/\W+/, '-')
> if !familyfirst
> return nominalname
> @@ -280,7 +280,7 @@ class ICLA < Vue
> end
>
> # generate LDAP givenName from public name
> - def genldapsn(pnamearray, ffirst)
> + def genldapgivenname(pnamearray, ffirst)
> if ffirst
> return pnamearray[-1]
> else
Craig L Russell
clr@apache.org