You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2022/08/15 23:17:07 UTC

[trafficserver] branch master updated: Removes unused ProtectedQueue::remove(Event *e) (#9020)

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new c6ec02f26 Removes unused ProtectedQueue::remove(Event *e) (#9020)
c6ec02f26 is described below

commit c6ec02f263a36e43b27ad40446b46a3506667705
Author: cukiernik <pi...@intel.com>
AuthorDate: Tue Aug 16 01:17:01 2022 +0200

    Removes unused ProtectedQueue::remove(Event *e) (#9020)
---
 iocore/eventsystem/I_ProtectedQueue.h |  1 -
 iocore/eventsystem/P_ProtectedQueue.h | 10 ----------
 2 files changed, 11 deletions(-)

diff --git a/iocore/eventsystem/I_ProtectedQueue.h b/iocore/eventsystem/I_ProtectedQueue.h
index 0b31c4f60..0ba671b5c 100644
--- a/iocore/eventsystem/I_ProtectedQueue.h
+++ b/iocore/eventsystem/I_ProtectedQueue.h
@@ -41,7 +41,6 @@ struct ProtectedQueue {
   void signal();
   int try_signal();             // Use non blocking lock and if acquired, signal
   void enqueue_local(Event *e); // Safe when called from the same thread
-  void remove(Event *e);
   Event *dequeue_local();
   void dequeue_external();       // Dequeue any external events.
   void wait(ink_hrtime timeout); // Wait for @a timeout nanoseconds on a condition variable if there are no events.
diff --git a/iocore/eventsystem/P_ProtectedQueue.h b/iocore/eventsystem/P_ProtectedQueue.h
index 09d429bf9..9202a7f80 100644
--- a/iocore/eventsystem/P_ProtectedQueue.h
+++ b/iocore/eventsystem/P_ProtectedQueue.h
@@ -71,16 +71,6 @@ ProtectedQueue::enqueue_local(Event *e)
   localQueue.enqueue(e);
 }
 
-TS_INLINE void
-ProtectedQueue::remove(Event *e)
-{
-  ink_assert(e->in_the_prot_queue);
-  if (!ink_atomiclist_remove(&al, e)) {
-    localQueue.remove(e);
-  }
-  e->in_the_prot_queue = 0;
-}
-
 TS_INLINE Event *
 ProtectedQueue::dequeue_local()
 {