You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "utkarsharma2 (via GitHub)" <gi...@apache.org> on 2023/12/23 07:40:25 UTC

[PR] Add 'uuid_column', 'tenant' params to WeaviateIngestOperator [airflow]

utkarsharma2 opened a new pull request, #36387:
URL: https://github.com/apache/airflow/pull/36387

   Exposing 'uuid_column', and 'tenant' params in WeaviateIngestOperator and fixing the missing `insertion_errors` param issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add 'uuid_column', 'tenant' params to WeaviateIngestOperator [airflow]

Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 merged PR #36387:
URL: https://github.com/apache/airflow/pull/36387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add 'uuid_column', 'tenant' params to WeaviateIngestOperator [airflow]

Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro commented on code in PR #36387:
URL: https://github.com/apache/airflow/pull/36387#discussion_r1435520508


##########
airflow/providers/weaviate/operators/weaviate.py:
##########
@@ -87,11 +91,16 @@ def hook(self) -> WeaviateHook:
         """Return an instance of the WeaviateHook."""
         return WeaviateHook(conn_id=self.conn_id, **self.hook_params)
 
-    def execute(self, context: Context) -> None:
+    def execute(self, context: Context):

Review Comment:
   ```suggestion
       def execute(self, context: Context) -> list:
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org