You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/30 18:45:17 UTC
[GitHub] [superset] villebro commented on a change in pull request #16910: chore: add certified columns to top of list
villebro commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r719669773
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
Does this retain the order within the certified vs non-certified groups? Doing it like it's done here should at least ensure the order is retained.
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
Does the proposed change retain the order within the certified vs non-certified groups? Doing it like it's done here should at least ensure the order is retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org