You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/01 21:24:19 UTC
Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66892/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and radhika jandhyala.
Repository: mesos
Description
-------
This new test checks exercises our `Subprocess::PIPE()` logic more
thoroughly by specifically piping enough data such that a single
memory page is insufficient to hold it. This is especially important
on Windows because the OS-allocated buffer is the size of one memory
page. On Windows, it also tests that the expected end-of-file
condition, `ERROR_BROKEN_PIPE`, is set.
We also fix another use of `os::WindowsFD` in place of `int_fd`, the
public name of the type; added an important note about why we hold
onto the process's handle on Windows; pass the file descriptor structs
by const-ref instead of value; and finally check the return value
`os::close()` in `createChildProcess`.
Diffs
-----
3rdparty/libprocess/src/subprocess.cpp 898326360d6b4f0a50d6ef3f7c86141d0aa70438
3rdparty/libprocess/src/subprocess_windows.hpp 4cc5675621f0846229e9358d70412f44138e7904
3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14
Diff: https://reviews.apache.org/r/66892/diff/1/
Testing
-------
`ctest -V` on Linux and Windows (also running `make check` with Autotools).
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66892/#review202243
-----------------------------------------------------------
PASS: Mesos patch 66892 was successfully built and tested.
Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', '66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', '66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', '66445', '66578', '66641', '66773', '66790', '66834', '66835', '66836', '66892']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66892
- Mesos Reviewbot Windows
On May 1, 2018, 9:24 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66892/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 9:24 p.m.)
>
>
> Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new test checks exercises our `Subprocess::PIPE()` logic more
> thoroughly by specifically piping enough data such that a single
> memory page is insufficient to hold it. This is especially important
> on Windows because the OS-allocated buffer is the size of one memory
> page. On Windows, it also tests that the expected end-of-file
> condition, `ERROR_BROKEN_PIPE`, is set.
>
> We also fix another use of `os::WindowsFD` in place of `int_fd`, the
> public name of the type; added an important note about why we hold
> onto the process's handle on Windows; pass the file descriptor structs
> by const-ref instead of value; and finally check the return value
> `os::close()` in `createChildProcess`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 898326360d6b4f0a50d6ef3f7c86141d0aa70438
> 3rdparty/libprocess/src/subprocess_windows.hpp 4cc5675621f0846229e9358d70412f44138e7904
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14
>
>
> Diff: https://reviews.apache.org/r/66892/diff/1/
>
>
> Testing
> -------
>
> `ctest -V` on Linux and Windows (also running `make check` with Autotools).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66892/#review202224
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On May 1, 2018, 9:24 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66892/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 9:24 p.m.)
>
>
> Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and radhika jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new test checks exercises our `Subprocess::PIPE()` logic more
> thoroughly by specifically piping enough data such that a single
> memory page is insufficient to hold it. This is especially important
> on Windows because the OS-allocated buffer is the size of one memory
> page. On Windows, it also tests that the expected end-of-file
> condition, `ERROR_BROKEN_PIPE`, is set.
>
> We also fix another use of `os::WindowsFD` in place of `int_fd`, the
> public name of the type; added an important note about why we hold
> onto the process's handle on Windows; pass the file descriptor structs
> by const-ref instead of value; and finally check the return value
> `os::close()` in `createChildProcess`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 898326360d6b4f0a50d6ef3f7c86141d0aa70438
> 3rdparty/libprocess/src/subprocess_windows.hpp 4cc5675621f0846229e9358d70412f44138e7904
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14
>
>
> Diff: https://reviews.apache.org/r/66892/diff/1/
>
>
> Testing
> -------
>
> `ctest -V` on Linux and Windows (also running `make check` with Autotools).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66892/#review202236
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On May 1, 2018, 2:24 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66892/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 2:24 p.m.)
>
>
> Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika Jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new test checks exercises our `Subprocess::PIPE()` logic more
> thoroughly by specifically piping enough data such that a single
> memory page is insufficient to hold it. This is especially important
> on Windows because the OS-allocated buffer is the size of one memory
> page. On Windows, it also tests that the expected end-of-file
> condition, `ERROR_BROKEN_PIPE`, is set.
>
> We also fix another use of `os::WindowsFD` in place of `int_fd`, the
> public name of the type; added an important note about why we hold
> onto the process's handle on Windows; pass the file descriptor structs
> by const-ref instead of value; and finally check the return value
> `os::close()` in `createChildProcess`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 898326360d6b4f0a50d6ef3f7c86141d0aa70438
> 3rdparty/libprocess/src/subprocess_windows.hpp 4cc5675621f0846229e9358d70412f44138e7904
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14
>
>
> Diff: https://reviews.apache.org/r/66892/diff/1/
>
>
> Testing
> -------
>
> `ctest -V` on Linux and Windows (also running `make check` with Autotools).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.
Posted by radhika jandhyala via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66892/#review202225
-----------------------------------------------------------
Ship it!
Ship It!
- radhika jandhyala
On May 1, 2018, 9:24 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66892/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 9:24 p.m.)
>
>
> Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and radhika jandhyala.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new test checks exercises our `Subprocess::PIPE()` logic more
> thoroughly by specifically piping enough data such that a single
> memory page is insufficient to hold it. This is especially important
> on Windows because the OS-allocated buffer is the size of one memory
> page. On Windows, it also tests that the expected end-of-file
> condition, `ERROR_BROKEN_PIPE`, is set.
>
> We also fix another use of `os::WindowsFD` in place of `int_fd`, the
> public name of the type; added an important note about why we hold
> onto the process's handle on Windows; pass the file descriptor structs
> by const-ref instead of value; and finally check the return value
> `os::close()` in `createChildProcess`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 898326360d6b4f0a50d6ef3f7c86141d0aa70438
> 3rdparty/libprocess/src/subprocess_windows.hpp 4cc5675621f0846229e9358d70412f44138e7904
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14
>
>
> Diff: https://reviews.apache.org/r/66892/diff/1/
>
>
> Testing
> -------
>
> `ctest -V` on Linux and Windows (also running `make check` with Autotools).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>