Re: [PATCH] commit-email.pl 'stop processing' flag

[Ben Reser <be...@reser.org>]

On Tue, Aug 03, 2004 at 03:54:23PM -0500, Archie Cobbs wrote:
> Hi,
> 
> Below is a patch to commit-email.pl that allows a project to be given
> the '-S' flag which means 'stop processing'. Not the prettiest patch
> in the world (I'm a perl-avoider) but it seems to get the job done.
> 
> For what it's worth...
> 
> The problem
> -----------
> 
> Some subtrees of our project contain sensitive files. We don't
> want commit emails containing diffs of these sensitive files going
> to the normal commit email address. Instead, they should be omitted
> from the email, or go to a different address that directs them to the
> appropriate audience.
> 
> There's no way to do this today because the matching algorithm of
> commit-email.pl's command line is only "additive".
> 
> The ideal solution
> ------------------
> 
> Ideally, it would be nice if you could give commit-email.pl regular
> expressions to select out sensitive files whose diffs you don't
> want to show in the commit email.
> 
> The present solution
> --------------------
> 
> If a '-m' project is given the '-S' flag, then if it matches processing
> stops and subsequent project will not match.
> 
> So now if you are not a special person then instead of getting emails
> with the sensitive diffs removed (ideal solution), you just don't get
> the emails at all (workable solution).

Your change doesn't appear to work quite like you said.  You're checking
for the -S after the email has already been sent...

-- 
Ben Reser <be...@reser.org>
http://ben.reser.org

"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] commit-email.pl 'stop processing' flag

[Ben Reser <be...@reser.org>]

On Wed, Sep 01, 2004 at 05:24:11PM -0500, Archie Cobbs wrote:
> Ben Reser wrote:
> > > If a '-m' project is given the '-S' flag, then if it matches processing
> > > stops and subsequent project will not match.
> > 
> > Your change doesn't appear to work quite like you said.  You're checking
> > for the -S after the email has already been sent...
> 
> Yes, but subsequent emails will not be sent, which is the whole point.

I guess I'm reviewing this without the benefit of actually using this
hook script.  Can someone else who actually uses this script review
this?

-- 
Ben Reser <be...@reser.org>
http://ben.reser.org

"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] commit-email.pl 'stop processing' flag

[Archie Cobbs <ar...@dellroad.org>]

Ben Reser wrote:
> > If a '-m' project is given the '-S' flag, then if it matches processing
> > stops and subsequent project will not match.
> 
> Your change doesn't appear to work quite like you said.  You're checking
> for the -S after the email has already been sent...

Yes, but subsequent emails will not be sent, which is the whole point.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org