You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/11 13:52:09 UTC
[GitHub] [dubbo-go] ljun20160606 opened a new pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
ljun20160606 opened a new pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928
…loat string
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #865
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (e8733bf) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **decrease** coverage by `0.00%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
- Coverage 59.83% 59.83% -0.01%
===========================================
Files 260 260
Lines 12854 12861 +7
===========================================
+ Hits 7691 7695 +4
+ Misses 4202 4198 -4
- Partials 961 968 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `71.21% <75.00%> (-0.92%)` | :arrow_down: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `64.31% <0.00%> (-5.29%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <0.00%> (ø)` | |
| [protocol/jsonrpc/jsonrpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...e3c5cf3](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (c877c39) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.12%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 59.83% 59.95% +0.12%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
+ Hits 7691 7709 +18
+ Misses 4202 4186 -16
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (+4.06%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...8e47677](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (c877c39) into [master](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.01%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 59.83% 59.84% +0.01%
==========================================
Files 260 260
Lines 12854 12858 +4
==========================================
+ Hits 7691 7695 +4
+ Misses 4202 4201 -1
- Partials 961 962 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (+4.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...c877c39](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (fcd410c) into [master](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **decrease** coverage by `0.09%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
- Coverage 59.83% 59.73% -0.10%
==========================================
Files 260 260
Lines 12854 12858 +4
==========================================
- Hits 7691 7681 -10
- Misses 4202 4209 +7
- Partials 961 968 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `75.00% <0.00%> (-4.35%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...c877c39](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (c877c39) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.12%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 59.83% 59.95% +0.12%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
+ Hits 7691 7709 +18
+ Misses 4202 4186 -16
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (+4.06%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...e8733bf](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (c877c39) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.12%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 59.83% 59.95% +0.12%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
+ Hits 7691 7709 +18
+ Misses 4202 4186 -16
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (+4.06%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...e3c5cf3](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (c877c39) into [master](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.12%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 59.83% 59.95% +0.12%
==========================================
Files 260 260
Lines 12854 12858 +4
==========================================
+ Hits 7691 7709 +18
+ Misses 4202 4186 -16
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (+4.06%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...c877c39](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (8e47677) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.06%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 59.83% 59.90% +0.06%
===========================================
Files 260 260
Lines 12854 12861 +7
===========================================
+ Hits 7691 7704 +13
+ Misses 4202 4189 -13
- Partials 961 968 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `71.21% <75.00%> (-0.92%)` | :arrow_down: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...e3c5cf3](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#discussion_r542058579
##########
File path: filter/filter_impl/generic_filter.go
##########
@@ -122,22 +122,34 @@ func struct2MapAll(obj interface{}) interface{} {
}
return newTemps
} else if t.Kind() == reflect.Map {
- var newTempMap = make(map[string]interface{}, v.Len())
+ var newTempMap = make(map[interface{}]interface{}, v.Len())
iter := v.MapRange()
for iter.Next() {
- mapK := iter.Key().String()
if !iter.Value().CanInterface() {
continue
}
+ key := iter.Key()
mapV := iter.Value().Interface()
- newTempMap[mapK] = struct2MapAll(mapV)
+ newTempMap[convertMapKey(key)] = struct2MapAll(mapV)
}
return newTempMap
} else {
return obj
}
}
+func convertMapKey(key reflect.Value) interface{} {
+ switch key.Kind() {
+ case reflect.Bool, reflect.Int, reflect.Int8,
+ reflect.Int16, reflect.Int32, reflect.Int64,
+ reflect.Uint, reflect.Uint8, reflect.Uint16,
+ reflect.Uint32, reflect.Uint64, reflect.Float32,
+ reflect.Float64, reflect.String:
+ return key.Interface()
+ }
+ return key.String()
+}
Review comment:
why not use 'case... default...'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (fcd410c) into [master](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **decrease** coverage by `0.09%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
- Coverage 59.83% 59.73% -0.10%
==========================================
Files 260 260
Lines 12854 12858 +4
==========================================
- Hits 7691 7681 -10
- Misses 4202 4209 +7
- Partials 961 968 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `75.00% <0.00%> (-4.35%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...fcd410c](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ljun20160606 commented on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
ljun20160606 commented on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-744155837
> pls change your target branch to develop.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (e3c5cf3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.14%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 59.83% 59.97% +0.14%
===========================================
Files 260 260
Lines 12854 12861 +7
===========================================
+ Hits 7691 7714 +23
+ Misses 4202 4184 -18
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `71.21% <75.00%> (-0.92%)` | :arrow_down: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <0.00%> (ø)` | |
| [protocol/jsonrpc/jsonrpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <0.00%> (ø)` | |
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <0.00%> (ø)` | |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <0.00%> (+0.16%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...e3c5cf3](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
cityiron commented on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743769980
pls change your target branch to develop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (e3c5cf3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **increase** coverage by `0.08%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 59.83% 59.91% +0.08%
===========================================
Files 260 260
Lines 12854 12861 +7
===========================================
+ Hits 7691 7706 +15
+ Misses 4202 4193 -9
- Partials 961 962 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `71.21% <75.00%> (-0.92%)` | :arrow_down: |
| [metadata/definition/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9tb2NrLmdv) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [protocol/grpc/grpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9ncnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <0.00%> (ø)` | |
| [protocol/jsonrpc/jsonrpc\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX2V4cG9ydGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...e3c5cf3](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org