You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by eo...@apache.org on 2018/12/16 18:17:25 UTC

[maven-checkstyle-plugin] branch MCHECKSTYLE-353 created (now ad8f4da)

This is an automated email from the ASF dual-hosted git repository.

eolivelli pushed a change to branch MCHECKSTYLE-353
in repository https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin.git.


      at ad8f4da  [MCHECKSTYLE-353] - Don't resolve any dependencies

This branch includes the following new commits:

     new ad8f4da  [MCHECKSTYLE-353] - Don't resolve any dependencies

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[maven-checkstyle-plugin] 01/01: [MCHECKSTYLE-353] - Don't resolve any dependencies

Posted by eo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

eolivelli pushed a commit to branch MCHECKSTYLE-353
in repository https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin.git

commit ad8f4da564393a3429471e46a9d99db70b922ccf
Author: Zoran Regvart <zr...@apache.org>
AuthorDate: Mon May 7 15:33:07 2018 +0200

    [MCHECKSTYLE-353] - Don't resolve any dependencies
    
    Not sure why resolving dependencies is needed for running Checkstyle, it
    does slow down the build considerably. For Apache Camel this makes a
    ten fold difference from ~20mins to ~2mins for running
    `mvn checkstyle:check`.
    
    Seems this was introduced with MCHECKSTYLE-163 but subsequently
    integration test was removed in MCHECKSTYLE-272 (#42).
---
 .../apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java b/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
index 8c50001..d171791 100644
--- a/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
+++ b/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
@@ -72,7 +72,7 @@ import com.puppycrawl.tools.checkstyle.api.CheckstyleException;
  * @author <a href="mailto:joakim@erdfelt.net">Joakim Erdfelt</a>
  * @version $Id$
  */
-@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST,
+@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.NONE,
        threadSafe = true )
 public class CheckstyleViolationCheckMojo
     extends AbstractMojo