[GitHub] [ignite-3] zstan commented on a change in pull request #609: IGNITE-16345 Fix unstable KeyValueViewOperationsSimpleSchemaTest.putGetAllTypes

[GitBox <gi...@apache.org>]

zstan commented on a change in pull request #609:
URL: https://github.com/apache/ignite-3/pull/609#discussion_r796532396



##########
File path: modules/table/src/test/java/org/apache/ignite/internal/table/KeyValueViewOperationsSimpleSchemaTest.java
##########
@@ -330,6 +338,119 @@ public void putGetAllTypes() {
         }
     }
 
+    /**
+     * Parametrized test for correctness of empty string insertion.
+     *
+     * @param nullable nullable param for string column.
+     */
+    @ParameterizedTest
+    @ValueSource(booleans = {true, false})
+    public void testSingleStringInsertion(boolean nullable) {

Review comment:
       fixed, also tests that test not passed without my changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org