You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/12/09 10:19:45 UTC
[GitHub] [kylin] codecov-io commented on issue #981: KYLIN-4284:Introducing
redis as a distributed cache for queries
codecov-io commented on issue #981: KYLIN-4284:Introducing redis as a distributed cache for queries
URL: https://github.com/apache/kylin/pull/981#issuecomment-563163034
# [Codecov](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=h1) Report
> Merging [#981](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/4f9406edc21b8f7b6cf098780d4940e0c2893435?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #981 +/- ##
============================================
+ Coverage 25.42% 25.43% +0.01%
- Complexity 6153 6155 +2
============================================
Files 1415 1417 +2
Lines 85877 85891 +14
Branches 12042 12043 +1
============================================
+ Hits 21835 21848 +13
- Misses 61911 61914 +3
+ Partials 2131 2129 -2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/kylin/cache/cachemanager/RemoteCacheManager.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZW1vdGVDYWNoZU1hbmFnZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...n/cache/cachemanager/RedisCacheManagerAdaptor.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZWRpc0NhY2hlTWFuYWdlckFkYXB0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ylin/cache/cachemanager/MemcachedCacheManager.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9NZW1jYWNoZWRDYWNoZU1hbmFnZXIuamF2YQ==) | `43.33% <100%> (ø)` | `7 <1> (ø)` | :arrow_down: |
| [.../cachemanager/RemoteLocalFailOverCacheManager.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZW1vdGVMb2NhbEZhaWxPdmVyQ2FjaGVNYW5hZ2VyLmphdmE=) | `75% <50%> (-9.62%)` | `7 <4> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0%> (+5.26%)` | `7% <0%> (+1%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/kylin/pull/981/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=footer). Last update [4f9406e...c594795](https://codecov.io/gh/apache/kylin/pull/981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services