[jira] [Commented] (LUCENE-7716) Reduce specialization in TopFieldCollector

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898141#comment-15898141 ] 

Hoss Man commented on LUCENE-7716:
----------------------------------

NOTE: this was also committed to branch_6x, but there was a typo so gitbot didn't auto update the issue...

http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/55ddb5f2

> Reduce specialization in TopFieldCollector
> ------------------------------------------
>
>                 Key: LUCENE-7716
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7716
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Adrien Grand
>            Priority: Minor
>             Fix For: master (7.0), 6.5
>
>         Attachments: LUCENE-7716.patch
>
>
> TopFieldCollector optimizes the single-comparator case. I think we could replace this specialization with a MultiLeafFieldComparator wrapper, similarly to how MultiCollector works. This would have the benefit of replacing code duplication of non-trivial logic with a simple wrapper that delegates calls to its sub comparators.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org