You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:34:17 UTC

[GitHub] [dubbo-go-pixiu] dk-lockdown opened a new pull request #281: protocal resolver

dk-lockdown opened a new pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   mysql protocal resolver
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-950467676


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#281](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b79311) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/1663747a0648805768b7efec98b3318270ae680f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1663747) will **increase** coverage by `4.90%`.
   > The diff coverage is `84.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #281      +/-   ##
   ===========================================
   + Coverage    33.15%   38.06%   +4.90%     
   ===========================================
     Files           62       69       +7     
     Lines         3321     3673     +352     
   ===========================================
   + Hits          1101     1398     +297     
   - Misses        2106     2158      +52     
   - Partials       114      117       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/model/mysql.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL215c3FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/sync2/atomic.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9hdG9taWMuZ28=) | `67.18% <67.18%> (ø)` | |
   | [pkg/common/sync2/batcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9iYXRjaGVyLmdv) | `67.85% <67.85%> (ø)` | |
   | [pkg/common/bucketpool/bucketpool.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9idWNrZXRwb29sL2J1Y2tldHBvb2wuZ28=) | `90.90% <90.90%> (ø)` | |
   | [pkg/common/sync2/semaphore.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9zZW1hcGhvcmUuZ28=) | `92.85% <92.85%> (ø)` | |
   | [pkg/common/cache/lru\_cache.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jYWNoZS9scnVfY2FjaGUuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/common/sync2/consolidator.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9jb25zb2xpZGF0b3IuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <100.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1663747...8b79311](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735263794



##########
File path: pkg/common/sync2/consolidator.go
##########
@@ -0,0 +1,177 @@
+/*

Review comment:
       move it to the gost.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-950467676


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#281](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c26ea0) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/495aa90886d28c2aaf6fa49d9bffb2bd8e62dd8d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (495aa90) will **increase** coverage by `4.91%`.
   > The diff coverage is `84.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #281      +/-   ##
   ===========================================
   + Coverage    33.14%   38.06%   +4.91%     
   ===========================================
     Files           62       69       +7     
     Lines         3322     3673     +351     
   ===========================================
   + Hits          1101     1398     +297     
   - Misses        2107     2158      +51     
   - Partials       114      117       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/model/mysql.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL215c3FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/sync2/atomic.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9hdG9taWMuZ28=) | `67.18% <67.18%> (ø)` | |
   | [pkg/common/sync2/batcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9iYXRjaGVyLmdv) | `67.85% <67.85%> (ø)` | |
   | [pkg/common/bucketpool/bucketpool.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9idWNrZXRwb29sL2J1Y2tldHBvb2wuZ28=) | `90.90% <90.90%> (ø)` | |
   | [pkg/common/sync2/semaphore.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9zZW1hcGhvcmUuZ28=) | `92.85% <92.85%> (ø)` | |
   | [pkg/common/cache/lru\_cache.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jYWNoZS9scnVfY2FjaGUuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/common/sync2/consolidator.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9jb25zb2xpZGF0b3IuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [495aa90...5c26ea0](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur closed pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
ztelur closed pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-950467676


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#281](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d16145) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/8080a476f38363ea779a54793e228e97003770f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8080a47) will **increase** coverage by `4.91%`.
   > The diff coverage is `84.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #281      +/-   ##
   ===========================================
   + Coverage    33.14%   38.06%   +4.91%     
   ===========================================
     Files           62       69       +7     
     Lines         3322     3673     +351     
   ===========================================
   + Hits          1101     1398     +297     
   - Misses        2107     2158      +51     
   - Partials       114      117       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/model/mysql.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL215c3FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/sync2/atomic.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9hdG9taWMuZ28=) | `67.18% <67.18%> (ø)` | |
   | [pkg/common/sync2/batcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9iYXRjaGVyLmdv) | `67.85% <67.85%> (ø)` | |
   | [pkg/common/bucketpool/bucketpool.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9idWNrZXRwb29sL2J1Y2tldHBvb2wuZ28=) | `90.90% <90.90%> (ø)` | |
   | [pkg/common/sync2/semaphore.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9zZW1hcGhvcmUuZ28=) | `92.85% <92.85%> (ø)` | |
   | [pkg/common/cache/lru\_cache.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jYWNoZS9scnVfY2FjaGUuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/common/sync2/consolidator.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9jb25zb2xpZGF0b3IuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8080a47...8d16145](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-950467676


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#281](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2c250b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2890fd767072e5abf6c2106ff8a5b03351970fca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2890fd7) will **increase** coverage by `4.91%`.
   > The diff coverage is `84.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #281      +/-   ##
   ===========================================
   + Coverage    33.14%   38.06%   +4.91%     
   ===========================================
     Files           62       69       +7     
     Lines         3322     3673     +351     
   ===========================================
   + Hits          1101     1398     +297     
   - Misses        2107     2158      +51     
   - Partials       114      117       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/model/mysql.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL215c3FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/sync2/atomic.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9hdG9taWMuZ28=) | `67.18% <67.18%> (ø)` | |
   | [pkg/common/sync2/batcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9iYXRjaGVyLmdv) | `67.85% <67.85%> (ø)` | |
   | [pkg/common/bucketpool/bucketpool.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9idWNrZXRwb29sL2J1Y2tldHBvb2wuZ28=) | `90.90% <90.90%> (ø)` | |
   | [pkg/common/sync2/semaphore.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9zZW1hcGhvcmUuZ28=) | `92.85% <92.85%> (ø)` | |
   | [pkg/common/cache/lru\_cache.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jYWNoZS9scnVfY2FjaGUuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/common/sync2/consolidator.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zeW5jMi9jb25zb2xpZGF0b3IuZ28=) | `100.00% <100.00%> (ø)` | |
   | [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2890fd7...b2c250b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735283473



##########
File path: pkg/common/bucketpool/bucketpool.go
##########
@@ -0,0 +1,124 @@
+/*
+Copyright 2019 The Vitess Authors

Review comment:
       add "Copyright 2021 The apache/dubbo-go team"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735266570



##########
File path: pkg/resolver/mysql/mysql.go
##########
@@ -0,0 +1,447 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package mysql
+
+import (

Review comment:
       split it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735264773



##########
File path: pkg/resolver/mysql/conn.go
##########
@@ -0,0 +1,785 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package mysql
+
+import (

Review comment:
       split it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735283120



##########
File path: pkg/common/sync2/consolidator.go
##########
@@ -0,0 +1,177 @@
+/*
+Copyright 2019 The Vitess Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+/*

Review comment:
       pls delete the below two apl2.0 license.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241680



##########
File path: pkg/common/cache/lru_cache.go
##########
@@ -0,0 +1,301 @@
+/*

Review comment:
       plg move it to the gost lib.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241720



##########
File path: pkg/common/bucketpool/bucketpool.go
##########
@@ -0,0 +1,124 @@
+/*

Review comment:
       move it to gost.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241547



##########
File path: pkg/common/sync2/atomic.go
##########
@@ -0,0 +1,203 @@
+/*

Review comment:
       pls using uber atomic instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241084



##########
File path: pkg/model/mysql.go
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package model
+
+import (

Review comment:
       split this import block




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241317



##########
File path: pkg/common/sync2/consolidator.go
##########
@@ -0,0 +1,177 @@
+/*
+Copyright 2019 The Vitess Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package sync2
+
+import (

Review comment:
       split it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735240951



##########
File path: pkg/server/listener.go
##########
@@ -18,7 +18,9 @@
 package server
 
 import (
+	"github.com/apache/dubbo-go-pixiu/pkg/resolver/mysql"

Review comment:
       move it to the 3rd import block




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-955171796


   The impots format problem can be solved with the [tools](https://github.com/dubbogo/tools)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-950467676


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#281](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e54337) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2890fd767072e5abf6c2106ff8a5b03351970fca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2890fd7) will **increase** coverage by `0.65%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #281      +/-   ##
   ===========================================
   + Coverage    33.14%   33.79%   +0.65%     
   ===========================================
     Files           62       62              
     Lines         3322     3178     -144     
   ===========================================
   - Hits          1101     1074      -27     
   + Misses        2107     1992     -115     
   + Partials       114      112       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `67.64% <ø> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <ø> (ø)` | |
   | [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/model/mysql.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL215c3FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <100.00%> (ø)` | |
   | [...adapter/dubboregistry/remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZW1vdGluZy96b29rZWVwZXIvY2xpZW50Lmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2890fd7...1e54337](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241262



##########
File path: pkg/common/sync2/semaphore.go
##########
@@ -0,0 +1,102 @@
+/*

Review comment:
       move this file to gost, pls. as the go std path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735268712



##########
File path: pkg/resolver/mysql/constants.go
##########
@@ -0,0 +1,592 @@
+/*
+Copyright 2019 The Vitess Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */

Review comment:
       please add a blank line btw the license and the package 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735241394



##########
File path: pkg/common/sync2/batcher.go
##########
@@ -0,0 +1,105 @@
+/*

Review comment:
       move it to the gost lib.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#discussion_r735283614



##########
File path: pkg/common/bucketpool/bucketpool.go
##########
@@ -0,0 +1,124 @@
+/*
+Copyright 2019 The Vitess Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+/*

Review comment:
       delete the below apl.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-955177319


   Add Lisence Header pls


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #281: protocal resolver

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #281:
URL: https://github.com/apache/dubbo-go-pixiu/pull/281#issuecomment-950467676


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#281](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2fadd20) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2890fd767072e5abf6c2106ff8a5b03351970fca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2890fd7) will **increase** coverage by `0.65%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #281      +/-   ##
   ===========================================
   + Coverage    33.14%   33.79%   +0.65%     
   ===========================================
     Files           62       62              
     Lines         3322     3178     -144     
   ===========================================
   - Hits          1101     1074      -27     
   + Misses        2107     1992     -115     
   + Partials       114      112       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `67.64% <ø> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <ø> (ø)` | |
   | [pkg/model/base.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL2Jhc2UuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/model/mysql.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21vZGVsL215c3FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `68.81% <100.00%> (ø)` | |
   | [...adapter/dubboregistry/remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZW1vdGluZy96b29rZWVwZXIvY2xpZW50Lmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2890fd7...2fadd20](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org